From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96581C63777 for ; Sat, 28 Nov 2020 21:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A68D22264 for ; Sat, 28 Nov 2020 21:59:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xHy6/9zW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390975AbgK1Vvo (ORCPT ); Sat, 28 Nov 2020 16:51:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731532AbgK1Sw7 (ORCPT ); Sat, 28 Nov 2020 13:52:59 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A420C09427F for ; Fri, 27 Nov 2020 23:39:00 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id l17so6070553pgk.1 for ; Fri, 27 Nov 2020 23:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T/ekApRs2ogDKYVjCc+UT/3pDjFzfqmZDIBl/BKWSPM=; b=xHy6/9zWWW27cJCQ/JrkT6A3rb9sdjWrYUj6KxQIT4bKkVF+AmfMlotzD4qML5fpMW 3tVKHRc83O91CqhhCGGP0Aui+1cVsBqCgVqvQouSXP061eTFUbTkKN2aWCWFFTie727H 4Pry7nt3ZMSPQJpsV0XhMd9LvxiFUWf5qIiBilPDBKuETExgOtgkea69M/UF1W6zjdGU ELrd01YAl6H/DQXQiQwflTEvGqUowmlbWKfwvhCQfM5UwZjLcxTYoewxJ/BpIqn+yuWz EGcftacTmcBccSU7o73bGM/AvbTgJnbHemDlCbLfVjTtR7T+tamuH2eRdpUx/fMnKseQ y7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T/ekApRs2ogDKYVjCc+UT/3pDjFzfqmZDIBl/BKWSPM=; b=RbsL0WJ/e4PtnZTQo8vjENHwLGYKg8qFigSxzh3W3PMLZRJsLYRDM/CPPs3omvhODo W1sxB1D5Ea7al2TE1DhnqNB4WncknZNveEfbOxjUcsc/Zlzyq2NjA68+n6CJ8RJiIvG/ 7BTnUAaAV5uWYfBdNH2m15BjPdm/5dWO90gPSVgWdGY2o5elPYc2M4upJCUhm9grO37d UXY8ph7q1f5KJKDUWAzYv3PSWzAVtJBjFlEPefJjq4BEaFRUGyntyDRCWjBPZk3cpgw5 1lFmFk398XCU1VUp1brH4NQTqSQCb2w5uzb0VXX/A7REwhIg3CEuwanSfeKTFRWKNirh Qn+g== X-Gm-Message-State: AOAM533N0OvAoEETMvjUc1hgIDcX2KTMKLpTbn8FZ2Mjf+T5ougNqSxE zF3uNFHuc6updQ2jtGAF1q11fv6YFEzz X-Google-Smtp-Source: ABdhPJwPU88NKoAJPxNC6799XCujY5nY8nwlbcFm7Prf8dvrO8TN+3L13C+OzCKf+2Cp2s8DefPzeg== X-Received: by 2002:a17:90a:d495:: with SMTP id s21mr14233430pju.42.1606549139947; Fri, 27 Nov 2020 23:38:59 -0800 (PST) Received: from thinkpad ([2409:4072:15:c612:48ab:f1cc:6b16:2820]) by smtp.gmail.com with ESMTPSA id p15sm13569176pjg.21.2020.11.27.23.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 23:38:59 -0800 (PST) Date: Sat, 28 Nov 2020 13:08:51 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support Message-ID: <20201128073851.GC3077@thinkpad> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 01:56:10AM +0200, Cristian Ciocaltea wrote: > Add uSD support for RoseapplePi SBC using a fixed regulator as a > temporary solution until PMIC support becomes available. > > Signed-off-by: Cristian Ciocaltea > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index 800edf5d2d12..fe9ae3619422 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -14,6 +14,7 @@ / { > model = "Roseapple Pi"; > > aliases { > + mmc0 = &mmc0; > serial2 = &uart2; > }; > > @@ -25,6 +26,55 @@ memory@0 { > device_type = "memory"; > reg = <0x0 0x80000000>; /* 2GB */ > }; > + > + /* Fixed regulator used in the absence of PMIC */ > + sd_vcc: sd-vcc { Is this the exact name in the schematics? Thanks, Mani > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.1V"; > + regulator-min-microvolt = <3100000>; > + regulator-max-microvolt = <3100000>; > + regulator-always-on; > + }; > +}; > + > +&pinctrl { > + mmc0_pins: mmc0-pins { > + pinmux { > + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", > + "sd0_cmd_mfp", "sd0_clk_mfp"; > + function = "sd0"; > + }; > + > + drv-pinconf { > + groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv"; > + drive-strength = <8>; > + }; > + > + bias0-pinconf { > + pins = "sd0_d0", "sd0_d1", "sd0_d2", > + "sd0_d3", "sd0_cmd"; > + bias-pull-up; > + }; > + > + bias1-pinconf { > + pins = "sd0_clk"; > + bias-pull-down; > + }; > + }; > +}; > + > +/* uSD */ > +&mmc0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + no-sdio; > + no-mmc; > + no-1-8-v; > + cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + vmmc-supply = <&sd_vcc>; > + vqmmc-supply = <&sd_vcc>; > }; > > &twd_timer { > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B122AC63697 for ; Sat, 28 Nov 2020 07:41:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 170D02087C for ; Sat, 28 Nov 2020 07:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lMJHDNwG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xHy6/9zW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 170D02087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jTJ8m6EcRR23qE1MweLcZoxZLKmJ7IqQEQcWXSvPpcs=; b=lMJHDNwGG175v7NdTIMcFBUUB M2HAqLyCTeV8HR/WWbPWkCtnC0iRPU7rdzBlpf+dY1PCU4Xuuw6NAyQX4cWdtEQb6+E3M7mJhXKSw YyWpx6D4Wr7cLfPRltZAjYSYXEVHvqeIhN+RJg6XG3KU1HYtOFfy/R20fe2vFW4ELQtcSJeyZhwbS e9yDJD7ZZ0TXf8lZPJPz00MyZ2iJiK7LTVtyqB4mAmmC/xOKa7seEbA5W0QoVAoK3G/U0aOECWdBj WKsGj8UoPEndXVBBT1n39duvY6s4EKnXd8ONK0KlhaikRyu0yPU72TqE7iNsRRLicu6q5sWfTeL/w d+BDIYq4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiup4-0005DY-Rr; Sat, 28 Nov 2020 07:39:10 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiuoy-0005Al-Pt for linux-arm-kernel@lists.infradead.org; Sat, 28 Nov 2020 07:39:05 +0000 Received: by mail-pg1-x544.google.com with SMTP id w4so6030509pgg.13 for ; Fri, 27 Nov 2020 23:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T/ekApRs2ogDKYVjCc+UT/3pDjFzfqmZDIBl/BKWSPM=; b=xHy6/9zWWW27cJCQ/JrkT6A3rb9sdjWrYUj6KxQIT4bKkVF+AmfMlotzD4qML5fpMW 3tVKHRc83O91CqhhCGGP0Aui+1cVsBqCgVqvQouSXP061eTFUbTkKN2aWCWFFTie727H 4Pry7nt3ZMSPQJpsV0XhMd9LvxiFUWf5qIiBilPDBKuETExgOtgkea69M/UF1W6zjdGU ELrd01YAl6H/DQXQiQwflTEvGqUowmlbWKfwvhCQfM5UwZjLcxTYoewxJ/BpIqn+yuWz EGcftacTmcBccSU7o73bGM/AvbTgJnbHemDlCbLfVjTtR7T+tamuH2eRdpUx/fMnKseQ y7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T/ekApRs2ogDKYVjCc+UT/3pDjFzfqmZDIBl/BKWSPM=; b=sooRQ6OBBuT/x9R933XEZS+UeQJ9bHRivHT+KPf0T4l66wWsx0sW9mOeg4dUIzH2bo rlIu7Y8UPSvQ5/uKRvfL3qSd+M39ZbV+GPtcnQ5GAMTYGNe9boblaBl7Ih0zN+esjm2J 8I69rMcuDPF9AINvjbCKHneKesc0BZkdj6wWavO6+z5ZVKqpK6CFOHy2TGY9ZjWIbk22 rxnKlOQst+fPD//WWbeV5UUHqxiMWdHTRMxaH9BOgykUyUVv3AShm1Pj76iwoAA93UAm q5g7CWi64aNfIEYjed1lrAUGwE1FtTTQTmopq7z7Gw/dN77Tkd3UjP3FAhqt2IpQsm/l RcRQ== X-Gm-Message-State: AOAM532PzEBY6DtktTl2E4fzbBzmFjfTNdC1kBZOXR27P9Q7cCkfWrzr BrbDhJmXQ64ryE/2ddeMKbt8 X-Google-Smtp-Source: ABdhPJwPU88NKoAJPxNC6799XCujY5nY8nwlbcFm7Prf8dvrO8TN+3L13C+OzCKf+2Cp2s8DefPzeg== X-Received: by 2002:a17:90a:d495:: with SMTP id s21mr14233430pju.42.1606549139947; Fri, 27 Nov 2020 23:38:59 -0800 (PST) Received: from thinkpad ([2409:4072:15:c612:48ab:f1cc:6b16:2820]) by smtp.gmail.com with ESMTPSA id p15sm13569176pjg.21.2020.11.27.23.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 23:38:59 -0800 (PST) Date: Sat, 28 Nov 2020 13:08:51 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Subject: Re: [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support Message-ID: <20201128073851.GC3077@thinkpad> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_023905_006647_44025E3F X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 01:56:10AM +0200, Cristian Ciocaltea wrote: > Add uSD support for RoseapplePi SBC using a fixed regulator as a > temporary solution until PMIC support becomes available. > > Signed-off-by: Cristian Ciocaltea > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index 800edf5d2d12..fe9ae3619422 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -14,6 +14,7 @@ / { > model = "Roseapple Pi"; > > aliases { > + mmc0 = &mmc0; > serial2 = &uart2; > }; > > @@ -25,6 +26,55 @@ memory@0 { > device_type = "memory"; > reg = <0x0 0x80000000>; /* 2GB */ > }; > + > + /* Fixed regulator used in the absence of PMIC */ > + sd_vcc: sd-vcc { Is this the exact name in the schematics? Thanks, Mani > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.1V"; > + regulator-min-microvolt = <3100000>; > + regulator-max-microvolt = <3100000>; > + regulator-always-on; > + }; > +}; > + > +&pinctrl { > + mmc0_pins: mmc0-pins { > + pinmux { > + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", > + "sd0_cmd_mfp", "sd0_clk_mfp"; > + function = "sd0"; > + }; > + > + drv-pinconf { > + groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv"; > + drive-strength = <8>; > + }; > + > + bias0-pinconf { > + pins = "sd0_d0", "sd0_d1", "sd0_d2", > + "sd0_d3", "sd0_cmd"; > + bias-pull-up; > + }; > + > + bias1-pinconf { > + pins = "sd0_clk"; > + bias-pull-down; > + }; > + }; > +}; > + > +/* uSD */ > +&mmc0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + no-sdio; > + no-mmc; > + no-1-8-v; > + cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + vmmc-supply = <&sd_vcc>; > + vqmmc-supply = <&sd_vcc>; > }; > > &twd_timer { > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel