From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F00DC83021 for ; Sat, 28 Nov 2020 22:07:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28FDC20706 for ; Sat, 28 Nov 2020 22:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1jrPlXwe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729309AbgK1VuP (ORCPT ); Sat, 28 Nov 2020 16:50:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:47386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730247AbgK1Sih (ORCPT ); Sat, 28 Nov 2020 13:38:37 -0500 Received: from localhost (129.sub-72-107-112.myvzw.com [72.107.112.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F6C7246B3; Sat, 28 Nov 2020 18:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606588517; bh=krTdbHrGkcM5b4jd6jHl8Tj811g2BH+q5E0PPQ5iuP0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1jrPlXwe9ILXjItuxz9/t8GxK/MQWxNWJOUaEYGpQxD/dpPAvMyX7cm238YUlf00x fHRZCbCx0lc5oMXtSJwlHxgRyLQ/pw3uzuTM/N5JKgpY4OaW4UK2qgOYpegf41sOes cUU2tZ7iHNR/qc/5tVYNCHGtRQlEtP0Dti16ubIY= Date: Sat, 28 Nov 2020 12:35:16 -0600 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Bjorn Helgaas , Rob Herring , Jonathan Cameron , Jonathan Chocron , Shawn Lin , Heiko Stuebner , Zhou Wang , Lorenzo Pieralisi , Will Deacon , Robert Richter , Michal Simek , Toan Le , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Petazzoni , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Jonathan Derrick , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-rockchip@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: <20201128183516.GA897329@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201127104626.3979165-1-kw@linux.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Nov 27, 2020 at 10:46:26AM +0000, Krzysztof Wilczyński wrote: > Unify ECAM-related constants into a single set of standard constants > defining memory address shift values for the byte-level address that can > be used when accessing the PCI Express Configuration Space, and then > move native PCI Express controller drivers to use newly introduced > definitions retiring any driver-specific ones. > > The ECAM ("Enhanced Configuration Access Mechanism") is defined by the > PCI Express specification (see PCI Express Base Specification, Revision > 5.0, Version 1.0, Section 7.2.2, p. 676), thus most hardware should > implement it the same way. Most of the native PCI Express controller > drivers define their ECAM-related constants, many of these could be > shared, or use open-coded values when setting the .bus_shift field of > the struct pci_ecam_ops. > > All of the newly added constants should remove ambiguity and reduce the > number of open-coded values, and also correlate more strongly with the > descriptions in the aforementioned specification (see Table 7-1 > "Enhanced Configuration Address Mapping", p. 677). > > There is no change to functionality. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Krzysztof Wilczyński Beautiful. This should probably go via Lorenzo's tree, so he may have comments, too. Could apply this as-is; I had a few trivial notes below. It's ironic that we don't use PCIE_ECAM_OFFSET in drivers/pci/ecam.c. We could do something like this, which would also let us drop .bus_shift completely in all the conforming implementations. It also closes the hole that we didn't limit "where" to 4K for pci_ecam_map_bus() users. if (per_bus_mapping) { base = cfg->winp[busn]; busn = 0; } else { base = cfg->win; } if (cfg->ops->bus_shift) { u32 bus_offset = (busn & 0xff) << cfg->ops->bus_shift; u32 devfn_offset = (devfn & 0xff) << (cfg->ops->bus_shift - 8); where &= 0xfff; return base + (bus_offset | devfn_offset | where); } return base + PCIE_ECAM_OFFSET(busn, devfn, where); Reviewed-by: Bjorn Helgaas > static void __iomem *ppc4xx_pciex_get_config_base(struct ppc4xx_pciex_port *port, > struct pci_bus *bus, > - unsigned int devfn) > + unsigned int devfn, > + int offset) The interface change (to add "offset") could be a preparatory patch by itself. But I'm actually not sure it's worth even touching this file. This is the only place outside drivers/pci that includes linux/pci-ecam.h. I think I might rather put PCIE_ECAM_OFFSET() and related things in drivers/pci/pci.h and keep it all inside drivers/pci. > static const struct pci_ecam_ops pci_thunder_pem_ops = { > - .bus_shift = 24, > + .bus_shift = THUNDER_PCIE_ECAM_BUS_SHIFT, > .init = thunder_pem_platform_init, > .pci_ops = { > .map_bus = pci_ecam_map_bus, This could be split to its own patch, no big deal either way. > const struct pci_ecam_ops xgene_v2_pcie_ecam_ops = { > - .bus_shift = 16, > .init = xgene_v2_pcie_ecam_init, > .pci_ops = { > .map_bus = xgene_pcie_map_bus, Thanks for mentioning this change in the cover letter. It could also be split off to a preparatory patch, since it's not related to PCIE_ECAM_OFFSET(), which is the main point of this patch. > static void __iomem *iproc_pcie_map_ep_cfg_reg(struct iproc_pcie *pcie, > unsigned int busno, > - unsigned int slot, > - unsigned int fn, > + unsigned int devfn, This interface change *could* be a separate preparatory patch, too, but I'm starting to feel even more OCD than usual :) > @@ -94,7 +95,7 @@ struct vmd_dev { > struct pci_dev *dev; > > spinlock_t cfg_lock; > - char __iomem *cfgbar; > + void __iomem *cfgbar; This type change might be worth pushing to a separate patch since the casting issues are not completely trivial. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6EC9C64E7A for ; Sat, 28 Nov 2020 18:36:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 351D42245B for ; Sat, 28 Nov 2020 18:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1jrPlXwe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351D42245B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ck0Zw4TJ5zF0fL for ; Sun, 29 Nov 2020 05:36:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=1jrPlXwe; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ck0Y45c2gzF0X5 for ; Sun, 29 Nov 2020 05:35:20 +1100 (AEDT) Received: from localhost (129.sub-72-107-112.myvzw.com [72.107.112.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F6C7246B3; Sat, 28 Nov 2020 18:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606588517; bh=krTdbHrGkcM5b4jd6jHl8Tj811g2BH+q5E0PPQ5iuP0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1jrPlXwe9ILXjItuxz9/t8GxK/MQWxNWJOUaEYGpQxD/dpPAvMyX7cm238YUlf00x fHRZCbCx0lc5oMXtSJwlHxgRyLQ/pw3uzuTM/N5JKgpY4OaW4UK2qgOYpegf41sOes cUU2tZ7iHNR/qc/5tVYNCHGtRQlEtP0Dti16ubIY= Date: Sat, 28 Nov 2020 12:35:16 -0600 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: <20201128183516.GA897329@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201127104626.3979165-1-kw@linux.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , Jonathan Derrick , Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 27, 2020 at 10:46:26AM +0000, Krzysztof Wilczyński wrote: > Unify ECAM-related constants into a single set of standard constants > defining memory address shift values for the byte-level address that can > be used when accessing the PCI Express Configuration Space, and then > move native PCI Express controller drivers to use newly introduced > definitions retiring any driver-specific ones. > > The ECAM ("Enhanced Configuration Access Mechanism") is defined by the > PCI Express specification (see PCI Express Base Specification, Revision > 5.0, Version 1.0, Section 7.2.2, p. 676), thus most hardware should > implement it the same way. Most of the native PCI Express controller > drivers define their ECAM-related constants, many of these could be > shared, or use open-coded values when setting the .bus_shift field of > the struct pci_ecam_ops. > > All of the newly added constants should remove ambiguity and reduce the > number of open-coded values, and also correlate more strongly with the > descriptions in the aforementioned specification (see Table 7-1 > "Enhanced Configuration Address Mapping", p. 677). > > There is no change to functionality. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Krzysztof Wilczyński Beautiful. This should probably go via Lorenzo's tree, so he may have comments, too. Could apply this as-is; I had a few trivial notes below. It's ironic that we don't use PCIE_ECAM_OFFSET in drivers/pci/ecam.c. We could do something like this, which would also let us drop .bus_shift completely in all the conforming implementations. It also closes the hole that we didn't limit "where" to 4K for pci_ecam_map_bus() users. if (per_bus_mapping) { base = cfg->winp[busn]; busn = 0; } else { base = cfg->win; } if (cfg->ops->bus_shift) { u32 bus_offset = (busn & 0xff) << cfg->ops->bus_shift; u32 devfn_offset = (devfn & 0xff) << (cfg->ops->bus_shift - 8); where &= 0xfff; return base + (bus_offset | devfn_offset | where); } return base + PCIE_ECAM_OFFSET(busn, devfn, where); Reviewed-by: Bjorn Helgaas > static void __iomem *ppc4xx_pciex_get_config_base(struct ppc4xx_pciex_port *port, > struct pci_bus *bus, > - unsigned int devfn) > + unsigned int devfn, > + int offset) The interface change (to add "offset") could be a preparatory patch by itself. But I'm actually not sure it's worth even touching this file. This is the only place outside drivers/pci that includes linux/pci-ecam.h. I think I might rather put PCIE_ECAM_OFFSET() and related things in drivers/pci/pci.h and keep it all inside drivers/pci. > static const struct pci_ecam_ops pci_thunder_pem_ops = { > - .bus_shift = 24, > + .bus_shift = THUNDER_PCIE_ECAM_BUS_SHIFT, > .init = thunder_pem_platform_init, > .pci_ops = { > .map_bus = pci_ecam_map_bus, This could be split to its own patch, no big deal either way. > const struct pci_ecam_ops xgene_v2_pcie_ecam_ops = { > - .bus_shift = 16, > .init = xgene_v2_pcie_ecam_init, > .pci_ops = { > .map_bus = xgene_pcie_map_bus, Thanks for mentioning this change in the cover letter. It could also be split off to a preparatory patch, since it's not related to PCIE_ECAM_OFFSET(), which is the main point of this patch. > static void __iomem *iproc_pcie_map_ep_cfg_reg(struct iproc_pcie *pcie, > unsigned int busno, > - unsigned int slot, > - unsigned int fn, > + unsigned int devfn, This interface change *could* be a separate preparatory patch, too, but I'm starting to feel even more OCD than usual :) > @@ -94,7 +95,7 @@ struct vmd_dev { > struct pci_dev *dev; > > spinlock_t cfg_lock; > - char __iomem *cfgbar; > + void __iomem *cfgbar; This type change might be worth pushing to a separate patch since the casting issues are not completely trivial. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11DAC64E7A for ; Sat, 28 Nov 2020 18:35:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80CC9246F1 for ; Sat, 28 Nov 2020 18:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yNcVpTFy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1jrPlXwe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80CC9246F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=6zZDe0w09S5iVUJVoYRsOcIP1eTUFThEiltb6/h2poA=; b=yNcVpTFyeYD3RGF/5hbHPclaa AqOtf/3WZ1XSWV4W3HBuDLecJJjV6Kzh4zgenDI2T4W6unWAQArE2gHmhxA2WPwcFgEGqhTOUhYaO rQe33WAMf75WrJNeoRAsMAUgQM1oVXGum/q1Sxdk6A/bcfVoceWnDL/IwWH1eqV9zX5k/V9eSUhlk 3rmz3bKGSIhMlZ7ItcvJ072fzkICixsDqWt4cphot8a8GzZBoHcplqxhODGBSmfI/cOvPh9MIKD0d nbIRDxbEahyRigPDoHp9D+Ct/2AKTIU1djfXOTYdWF+2RU5hQLO5EKZkngfBTAVTcuC7tlLiUdz9I EczQVgbVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj549-0002sv-12; Sat, 28 Nov 2020 18:35:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj543-0002s1-OF; Sat, 28 Nov 2020 18:35:20 +0000 Received: from localhost (129.sub-72-107-112.myvzw.com [72.107.112.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F6C7246B3; Sat, 28 Nov 2020 18:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606588517; bh=krTdbHrGkcM5b4jd6jHl8Tj811g2BH+q5E0PPQ5iuP0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1jrPlXwe9ILXjItuxz9/t8GxK/MQWxNWJOUaEYGpQxD/dpPAvMyX7cm238YUlf00x fHRZCbCx0lc5oMXtSJwlHxgRyLQ/pw3uzuTM/N5JKgpY4OaW4UK2qgOYpegf41sOes cUU2tZ7iHNR/qc/5tVYNCHGtRQlEtP0Dti16ubIY= Date: Sat, 28 Nov 2020 12:35:16 -0600 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: <20201128183516.GA897329@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201127104626.3979165-1-kw@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_133519_995346_610AE7C8 X-CRM114-Status: GOOD ( 25.99 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , Jonathan Derrick , Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gRnJpLCBOb3YgMjcsIDIwMjAgYXQgMTA6NDY6MjZBTSArMDAwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgo+IFVuaWZ5IEVDQU0tcmVsYXRlZCBjb25zdGFudHMgaW50byBhIHNpbmds ZSBzZXQgb2Ygc3RhbmRhcmQgY29uc3RhbnRzCj4gZGVmaW5pbmcgbWVtb3J5IGFkZHJlc3Mgc2hp ZnQgdmFsdWVzIGZvciB0aGUgYnl0ZS1sZXZlbCBhZGRyZXNzIHRoYXQgY2FuCj4gYmUgdXNlZCB3 aGVuIGFjY2Vzc2luZyB0aGUgUENJIEV4cHJlc3MgQ29uZmlndXJhdGlvbiBTcGFjZSwgYW5kIHRo ZW4KPiBtb3ZlIG5hdGl2ZSBQQ0kgRXhwcmVzcyBjb250cm9sbGVyIGRyaXZlcnMgdG8gdXNlIG5l d2x5IGludHJvZHVjZWQKPiBkZWZpbml0aW9ucyByZXRpcmluZyBhbnkgZHJpdmVyLXNwZWNpZmlj IG9uZXMuCj4gCj4gVGhlIEVDQU0gKCJFbmhhbmNlZCBDb25maWd1cmF0aW9uIEFjY2VzcyBNZWNo YW5pc20iKSBpcyBkZWZpbmVkIGJ5IHRoZQo+IFBDSSBFeHByZXNzIHNwZWNpZmljYXRpb24gKHNl ZSBQQ0kgRXhwcmVzcyBCYXNlIFNwZWNpZmljYXRpb24sIFJldmlzaW9uCj4gNS4wLCBWZXJzaW9u IDEuMCwgU2VjdGlvbiA3LjIuMiwgcC4gNjc2KSwgdGh1cyBtb3N0IGhhcmR3YXJlIHNob3VsZAo+ IGltcGxlbWVudCBpdCB0aGUgc2FtZSB3YXkuICBNb3N0IG9mIHRoZSBuYXRpdmUgUENJIEV4cHJl c3MgY29udHJvbGxlcgo+IGRyaXZlcnMgZGVmaW5lIHRoZWlyIEVDQU0tcmVsYXRlZCBjb25zdGFu dHMsIG1hbnkgb2YgdGhlc2UgY291bGQgYmUKPiBzaGFyZWQsIG9yIHVzZSBvcGVuLWNvZGVkIHZh bHVlcyB3aGVuIHNldHRpbmcgdGhlIC5idXNfc2hpZnQgZmllbGQgb2YKPiB0aGUgc3RydWN0IHBj aV9lY2FtX29wcy4KPiAKPiBBbGwgb2YgdGhlIG5ld2x5IGFkZGVkIGNvbnN0YW50cyBzaG91bGQg cmVtb3ZlIGFtYmlndWl0eSBhbmQgcmVkdWNlIHRoZQo+IG51bWJlciBvZiBvcGVuLWNvZGVkIHZh bHVlcywgYW5kIGFsc28gY29ycmVsYXRlIG1vcmUgc3Ryb25nbHkgd2l0aCB0aGUKPiBkZXNjcmlw dGlvbnMgaW4gdGhlIGFmb3JlbWVudGlvbmVkIHNwZWNpZmljYXRpb24gKHNlZSBUYWJsZSA3LTEK PiAiRW5oYW5jZWQgQ29uZmlndXJhdGlvbiBBZGRyZXNzIE1hcHBpbmciLCBwLiA2NzcpLgo+IAo+ IFRoZXJlIGlzIG5vIGNoYW5nZSB0byBmdW5jdGlvbmFsaXR5Lgo+IAo+IFN1Z2dlc3RlZC1ieTog Qmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBLcnp5 c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KCkJlYXV0aWZ1bC4gIFRoaXMgc2hvdWxk IHByb2JhYmx5IGdvIHZpYSBMb3JlbnpvJ3MgdHJlZSwgc28gaGUgbWF5IGhhdmUKY29tbWVudHMs IHRvby4gIENvdWxkIGFwcGx5IHRoaXMgYXMtaXM7IEkgaGFkIGEgZmV3IHRyaXZpYWwgbm90ZXMK YmVsb3cuCgpJdCdzIGlyb25pYyB0aGF0IHdlIGRvbid0IHVzZSBQQ0lFX0VDQU1fT0ZGU0VUIGlu IGRyaXZlcnMvcGNpL2VjYW0uYy4KV2UgY291bGQgZG8gc29tZXRoaW5nIGxpa2UgdGhpcywgd2hp Y2ggd291bGQgYWxzbyBsZXQgdXMgZHJvcAouYnVzX3NoaWZ0IGNvbXBsZXRlbHkgaW4gYWxsIHRo ZSBjb25mb3JtaW5nIGltcGxlbWVudGF0aW9ucy4gIEl0IGFsc28KY2xvc2VzIHRoZSBob2xlIHRo YXQgd2UgZGlkbid0IGxpbWl0ICJ3aGVyZSIgdG8gNEsgZm9yCnBjaV9lY2FtX21hcF9idXMoKSB1 c2Vycy4KCiAgaWYgKHBlcl9idXNfbWFwcGluZykgewogICAgYmFzZSA9IGNmZy0+d2lucFtidXNu XTsKICAgIGJ1c24gPSAwOwogIH0gZWxzZSB7CiAgICBiYXNlID0gY2ZnLT53aW47CiAgfQoKICBp ZiAoY2ZnLT5vcHMtPmJ1c19zaGlmdCkgewogICAgdTMyIGJ1c19vZmZzZXQgPSAoYnVzbiAmIDB4 ZmYpIDw8IGNmZy0+b3BzLT5idXNfc2hpZnQ7CiAgICB1MzIgZGV2Zm5fb2Zmc2V0ID0gKGRldmZu ICYgMHhmZikgPDwgKGNmZy0+b3BzLT5idXNfc2hpZnQgLSA4KTsKCiAgICB3aGVyZSAmPSAweGZm ZjsKCiAgICByZXR1cm4gYmFzZSArIChidXNfb2Zmc2V0IHwgZGV2Zm5fb2Zmc2V0IHwgd2hlcmUp OwogIH0KCiAgcmV0dXJuIGJhc2UgKyBQQ0lFX0VDQU1fT0ZGU0VUKGJ1c24sIGRldmZuLCB3aGVy ZSk7CgpSZXZpZXdlZC1ieTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KCj4g IHN0YXRpYyB2b2lkIF9faW9tZW0gKnBwYzR4eF9wY2lleF9nZXRfY29uZmlnX2Jhc2Uoc3RydWN0 IHBwYzR4eF9wY2lleF9wb3J0ICpwb3J0LAo+ICAJCQkJCQkgIHN0cnVjdCBwY2lfYnVzICpidXMs Cj4gLQkJCQkJCSAgdW5zaWduZWQgaW50IGRldmZuKQo+ICsJCQkJCQkgIHVuc2lnbmVkIGludCBk ZXZmbiwKPiArCQkJCQkJICBpbnQgb2Zmc2V0KQoKVGhlIGludGVyZmFjZSBjaGFuZ2UgKHRvIGFk ZCAib2Zmc2V0IikgY291bGQgYmUgYSBwcmVwYXJhdG9yeSBwYXRjaCBieQppdHNlbGYuCgpCdXQg SSdtIGFjdHVhbGx5IG5vdCBzdXJlIGl0J3Mgd29ydGggZXZlbiB0b3VjaGluZyB0aGlzIGZpbGUu ICBUaGlzIGlzCnRoZSBvbmx5IHBsYWNlIG91dHNpZGUgZHJpdmVycy9wY2kgdGhhdCBpbmNsdWRl cyBsaW51eC9wY2ktZWNhbS5oLiAgSQp0aGluayBJIG1pZ2h0IHJhdGhlciBwdXQgUENJRV9FQ0FN X09GRlNFVCgpIGFuZCByZWxhdGVkIHRoaW5ncyBpbgpkcml2ZXJzL3BjaS9wY2kuaCBhbmQga2Vl cCBpdCBhbGwgaW5zaWRlIGRyaXZlcnMvcGNpLgoKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lf ZWNhbV9vcHMgcGNpX3RodW5kZXJfcGVtX29wcyA9IHsKPiAtCS5idXNfc2hpZnQJPSAyNCwKPiAr CS5idXNfc2hpZnQJPSBUSFVOREVSX1BDSUVfRUNBTV9CVVNfU0hJRlQsCj4gIAkuaW5pdAkJPSB0 aHVuZGVyX3BlbV9wbGF0Zm9ybV9pbml0LAo+ICAJLnBjaV9vcHMJPSB7Cj4gIAkJLm1hcF9idXMJ PSBwY2lfZWNhbV9tYXBfYnVzLAoKVGhpcyBjb3VsZCBiZSBzcGxpdCB0byBpdHMgb3duIHBhdGNo LCBubyBiaWcgZGVhbCBlaXRoZXIgd2F5LgoKPiAgY29uc3Qgc3RydWN0IHBjaV9lY2FtX29wcyB4 Z2VuZV92Ml9wY2llX2VjYW1fb3BzID0gewo+IC0JLmJ1c19zaGlmdAk9IDE2LAo+ICAJLmluaXQJ CT0geGdlbmVfdjJfcGNpZV9lY2FtX2luaXQsCj4gIAkucGNpX29wcwk9IHsKPiAgCQkubWFwX2J1 cwk9IHhnZW5lX3BjaWVfbWFwX2J1cywKClRoYW5rcyBmb3IgbWVudGlvbmluZyB0aGlzIGNoYW5n ZSBpbiB0aGUgY292ZXIgbGV0dGVyLiAgSXQgY291bGQgYWxzbwpiZSBzcGxpdCBvZmYgdG8gYSBw cmVwYXJhdG9yeSBwYXRjaCwgc2luY2UgaXQncyBub3QgcmVsYXRlZCB0bwpQQ0lFX0VDQU1fT0ZG U0VUKCksIHdoaWNoIGlzIHRoZSBtYWluIHBvaW50IG9mIHRoaXMgcGF0Y2guCgo+ICBzdGF0aWMg dm9pZCBfX2lvbWVtICppcHJvY19wY2llX21hcF9lcF9jZmdfcmVnKHN0cnVjdCBpcHJvY19wY2ll ICpwY2llLAo+ICAJCQkJCSAgICAgICB1bnNpZ25lZCBpbnQgYnVzbm8sCj4gLQkJCQkJICAgICAg IHVuc2lnbmVkIGludCBzbG90LAo+IC0JCQkJCSAgICAgICB1bnNpZ25lZCBpbnQgZm4sCj4gKwkJ CQkJICAgICAgIHVuc2lnbmVkIGludCBkZXZmbiwKClRoaXMgaW50ZXJmYWNlIGNoYW5nZSAqY291 bGQqIGJlIGEgc2VwYXJhdGUgcHJlcGFyYXRvcnkgcGF0Y2gsIHRvbywKYnV0IEknbSBzdGFydGlu ZyB0byBmZWVsIGV2ZW4gbW9yZSBPQ0QgdGhhbiB1c3VhbCA6KQoKPiBAQCAtOTQsNyArOTUsNyBA QCBzdHJ1Y3Qgdm1kX2RldiB7Cj4gIAlzdHJ1Y3QgcGNpX2RldgkJKmRldjsKPiAgCj4gIAlzcGlu bG9ja190CQljZmdfbG9jazsKPiAtCWNoYXIgX19pb21lbQkJKmNmZ2JhcjsKPiArCXZvaWQgX19p b21lbQkJKmNmZ2JhcjsKClRoaXMgdHlwZSBjaGFuZ2UgbWlnaHQgYmUgd29ydGggcHVzaGluZyB0 byBhIHNlcGFyYXRlIHBhdGNoIHNpbmNlIHRoZQpjYXN0aW5nIGlzc3VlcyBhcmUgbm90IGNvbXBs ZXRlbHkgdHJpdmlhbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53522C63777 for ; Sat, 28 Nov 2020 18:36:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C92862245B for ; Sat, 28 Nov 2020 18:36:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xgDeOhbU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1jrPlXwe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C92862245B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=ZhTAINdk05OnmSUfZwsbF6CtLuz6entIX41JlPLmarA=; b=xgDeOhbUrIPDOU1/fl83Hw0d0 PYAEsKOm/paOyBtLwry/JaQVqd9yanVTrWBdhPy9o593+i1eGID0+Aaa8RZFRLN3hSMwi37vE5FHM nNg+LzYRHAmKsKlIv9NIoVwWVsvokJoWazX/E5V/Q8b0vvMkqpMxcTUrjWv+4C0+9doLZLFvOzJG4 qMZpEPIYyN053mGtIVWkAzlVmgLBQDz+3992Flu9MCDpQMdvMEHXWN7lcgVP6Rh1RYIRsJe9D9lqn dpSpooen0jxWM52AxBbdNl3tBpY53e4R0xXAhBwMSWJ2nOAIO+vf76Bl3PzQt1mE2k07diGfdGi4M +9BzqiPTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj546-0002sb-Pp; Sat, 28 Nov 2020 18:35:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj543-0002s1-OF; Sat, 28 Nov 2020 18:35:20 +0000 Received: from localhost (129.sub-72-107-112.myvzw.com [72.107.112.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F6C7246B3; Sat, 28 Nov 2020 18:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606588517; bh=krTdbHrGkcM5b4jd6jHl8Tj811g2BH+q5E0PPQ5iuP0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1jrPlXwe9ILXjItuxz9/t8GxK/MQWxNWJOUaEYGpQxD/dpPAvMyX7cm238YUlf00x fHRZCbCx0lc5oMXtSJwlHxgRyLQ/pw3uzuTM/N5JKgpY4OaW4UK2qgOYpegf41sOes cUU2tZ7iHNR/qc/5tVYNCHGtRQlEtP0Dti16ubIY= Date: Sat, 28 Nov 2020 12:35:16 -0600 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: <20201128183516.GA897329@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201127104626.3979165-1-kw@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_133519_995346_610AE7C8 X-CRM114-Status: GOOD ( 25.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , Jonathan Derrick , Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBOb3YgMjcsIDIwMjAgYXQgMTA6NDY6MjZBTSArMDAwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgo+IFVuaWZ5IEVDQU0tcmVsYXRlZCBjb25zdGFudHMgaW50byBhIHNpbmds ZSBzZXQgb2Ygc3RhbmRhcmQgY29uc3RhbnRzCj4gZGVmaW5pbmcgbWVtb3J5IGFkZHJlc3Mgc2hp ZnQgdmFsdWVzIGZvciB0aGUgYnl0ZS1sZXZlbCBhZGRyZXNzIHRoYXQgY2FuCj4gYmUgdXNlZCB3 aGVuIGFjY2Vzc2luZyB0aGUgUENJIEV4cHJlc3MgQ29uZmlndXJhdGlvbiBTcGFjZSwgYW5kIHRo ZW4KPiBtb3ZlIG5hdGl2ZSBQQ0kgRXhwcmVzcyBjb250cm9sbGVyIGRyaXZlcnMgdG8gdXNlIG5l d2x5IGludHJvZHVjZWQKPiBkZWZpbml0aW9ucyByZXRpcmluZyBhbnkgZHJpdmVyLXNwZWNpZmlj IG9uZXMuCj4gCj4gVGhlIEVDQU0gKCJFbmhhbmNlZCBDb25maWd1cmF0aW9uIEFjY2VzcyBNZWNo YW5pc20iKSBpcyBkZWZpbmVkIGJ5IHRoZQo+IFBDSSBFeHByZXNzIHNwZWNpZmljYXRpb24gKHNl ZSBQQ0kgRXhwcmVzcyBCYXNlIFNwZWNpZmljYXRpb24sIFJldmlzaW9uCj4gNS4wLCBWZXJzaW9u IDEuMCwgU2VjdGlvbiA3LjIuMiwgcC4gNjc2KSwgdGh1cyBtb3N0IGhhcmR3YXJlIHNob3VsZAo+ IGltcGxlbWVudCBpdCB0aGUgc2FtZSB3YXkuICBNb3N0IG9mIHRoZSBuYXRpdmUgUENJIEV4cHJl c3MgY29udHJvbGxlcgo+IGRyaXZlcnMgZGVmaW5lIHRoZWlyIEVDQU0tcmVsYXRlZCBjb25zdGFu dHMsIG1hbnkgb2YgdGhlc2UgY291bGQgYmUKPiBzaGFyZWQsIG9yIHVzZSBvcGVuLWNvZGVkIHZh bHVlcyB3aGVuIHNldHRpbmcgdGhlIC5idXNfc2hpZnQgZmllbGQgb2YKPiB0aGUgc3RydWN0IHBj aV9lY2FtX29wcy4KPiAKPiBBbGwgb2YgdGhlIG5ld2x5IGFkZGVkIGNvbnN0YW50cyBzaG91bGQg cmVtb3ZlIGFtYmlndWl0eSBhbmQgcmVkdWNlIHRoZQo+IG51bWJlciBvZiBvcGVuLWNvZGVkIHZh bHVlcywgYW5kIGFsc28gY29ycmVsYXRlIG1vcmUgc3Ryb25nbHkgd2l0aCB0aGUKPiBkZXNjcmlw dGlvbnMgaW4gdGhlIGFmb3JlbWVudGlvbmVkIHNwZWNpZmljYXRpb24gKHNlZSBUYWJsZSA3LTEK PiAiRW5oYW5jZWQgQ29uZmlndXJhdGlvbiBBZGRyZXNzIE1hcHBpbmciLCBwLiA2NzcpLgo+IAo+ IFRoZXJlIGlzIG5vIGNoYW5nZSB0byBmdW5jdGlvbmFsaXR5Lgo+IAo+IFN1Z2dlc3RlZC1ieTog Qmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBLcnp5 c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KCkJlYXV0aWZ1bC4gIFRoaXMgc2hvdWxk IHByb2JhYmx5IGdvIHZpYSBMb3JlbnpvJ3MgdHJlZSwgc28gaGUgbWF5IGhhdmUKY29tbWVudHMs IHRvby4gIENvdWxkIGFwcGx5IHRoaXMgYXMtaXM7IEkgaGFkIGEgZmV3IHRyaXZpYWwgbm90ZXMK YmVsb3cuCgpJdCdzIGlyb25pYyB0aGF0IHdlIGRvbid0IHVzZSBQQ0lFX0VDQU1fT0ZGU0VUIGlu IGRyaXZlcnMvcGNpL2VjYW0uYy4KV2UgY291bGQgZG8gc29tZXRoaW5nIGxpa2UgdGhpcywgd2hp Y2ggd291bGQgYWxzbyBsZXQgdXMgZHJvcAouYnVzX3NoaWZ0IGNvbXBsZXRlbHkgaW4gYWxsIHRo ZSBjb25mb3JtaW5nIGltcGxlbWVudGF0aW9ucy4gIEl0IGFsc28KY2xvc2VzIHRoZSBob2xlIHRo YXQgd2UgZGlkbid0IGxpbWl0ICJ3aGVyZSIgdG8gNEsgZm9yCnBjaV9lY2FtX21hcF9idXMoKSB1 c2Vycy4KCiAgaWYgKHBlcl9idXNfbWFwcGluZykgewogICAgYmFzZSA9IGNmZy0+d2lucFtidXNu XTsKICAgIGJ1c24gPSAwOwogIH0gZWxzZSB7CiAgICBiYXNlID0gY2ZnLT53aW47CiAgfQoKICBp ZiAoY2ZnLT5vcHMtPmJ1c19zaGlmdCkgewogICAgdTMyIGJ1c19vZmZzZXQgPSAoYnVzbiAmIDB4 ZmYpIDw8IGNmZy0+b3BzLT5idXNfc2hpZnQ7CiAgICB1MzIgZGV2Zm5fb2Zmc2V0ID0gKGRldmZu ICYgMHhmZikgPDwgKGNmZy0+b3BzLT5idXNfc2hpZnQgLSA4KTsKCiAgICB3aGVyZSAmPSAweGZm ZjsKCiAgICByZXR1cm4gYmFzZSArIChidXNfb2Zmc2V0IHwgZGV2Zm5fb2Zmc2V0IHwgd2hlcmUp OwogIH0KCiAgcmV0dXJuIGJhc2UgKyBQQ0lFX0VDQU1fT0ZGU0VUKGJ1c24sIGRldmZuLCB3aGVy ZSk7CgpSZXZpZXdlZC1ieTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KCj4g IHN0YXRpYyB2b2lkIF9faW9tZW0gKnBwYzR4eF9wY2lleF9nZXRfY29uZmlnX2Jhc2Uoc3RydWN0 IHBwYzR4eF9wY2lleF9wb3J0ICpwb3J0LAo+ICAJCQkJCQkgIHN0cnVjdCBwY2lfYnVzICpidXMs Cj4gLQkJCQkJCSAgdW5zaWduZWQgaW50IGRldmZuKQo+ICsJCQkJCQkgIHVuc2lnbmVkIGludCBk ZXZmbiwKPiArCQkJCQkJICBpbnQgb2Zmc2V0KQoKVGhlIGludGVyZmFjZSBjaGFuZ2UgKHRvIGFk ZCAib2Zmc2V0IikgY291bGQgYmUgYSBwcmVwYXJhdG9yeSBwYXRjaCBieQppdHNlbGYuCgpCdXQg SSdtIGFjdHVhbGx5IG5vdCBzdXJlIGl0J3Mgd29ydGggZXZlbiB0b3VjaGluZyB0aGlzIGZpbGUu ICBUaGlzIGlzCnRoZSBvbmx5IHBsYWNlIG91dHNpZGUgZHJpdmVycy9wY2kgdGhhdCBpbmNsdWRl cyBsaW51eC9wY2ktZWNhbS5oLiAgSQp0aGluayBJIG1pZ2h0IHJhdGhlciBwdXQgUENJRV9FQ0FN X09GRlNFVCgpIGFuZCByZWxhdGVkIHRoaW5ncyBpbgpkcml2ZXJzL3BjaS9wY2kuaCBhbmQga2Vl cCBpdCBhbGwgaW5zaWRlIGRyaXZlcnMvcGNpLgoKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lf ZWNhbV9vcHMgcGNpX3RodW5kZXJfcGVtX29wcyA9IHsKPiAtCS5idXNfc2hpZnQJPSAyNCwKPiAr CS5idXNfc2hpZnQJPSBUSFVOREVSX1BDSUVfRUNBTV9CVVNfU0hJRlQsCj4gIAkuaW5pdAkJPSB0 aHVuZGVyX3BlbV9wbGF0Zm9ybV9pbml0LAo+ICAJLnBjaV9vcHMJPSB7Cj4gIAkJLm1hcF9idXMJ PSBwY2lfZWNhbV9tYXBfYnVzLAoKVGhpcyBjb3VsZCBiZSBzcGxpdCB0byBpdHMgb3duIHBhdGNo LCBubyBiaWcgZGVhbCBlaXRoZXIgd2F5LgoKPiAgY29uc3Qgc3RydWN0IHBjaV9lY2FtX29wcyB4 Z2VuZV92Ml9wY2llX2VjYW1fb3BzID0gewo+IC0JLmJ1c19zaGlmdAk9IDE2LAo+ICAJLmluaXQJ CT0geGdlbmVfdjJfcGNpZV9lY2FtX2luaXQsCj4gIAkucGNpX29wcwk9IHsKPiAgCQkubWFwX2J1 cwk9IHhnZW5lX3BjaWVfbWFwX2J1cywKClRoYW5rcyBmb3IgbWVudGlvbmluZyB0aGlzIGNoYW5n ZSBpbiB0aGUgY292ZXIgbGV0dGVyLiAgSXQgY291bGQgYWxzbwpiZSBzcGxpdCBvZmYgdG8gYSBw cmVwYXJhdG9yeSBwYXRjaCwgc2luY2UgaXQncyBub3QgcmVsYXRlZCB0bwpQQ0lFX0VDQU1fT0ZG U0VUKCksIHdoaWNoIGlzIHRoZSBtYWluIHBvaW50IG9mIHRoaXMgcGF0Y2guCgo+ICBzdGF0aWMg dm9pZCBfX2lvbWVtICppcHJvY19wY2llX21hcF9lcF9jZmdfcmVnKHN0cnVjdCBpcHJvY19wY2ll ICpwY2llLAo+ICAJCQkJCSAgICAgICB1bnNpZ25lZCBpbnQgYnVzbm8sCj4gLQkJCQkJICAgICAg IHVuc2lnbmVkIGludCBzbG90LAo+IC0JCQkJCSAgICAgICB1bnNpZ25lZCBpbnQgZm4sCj4gKwkJ CQkJICAgICAgIHVuc2lnbmVkIGludCBkZXZmbiwKClRoaXMgaW50ZXJmYWNlIGNoYW5nZSAqY291 bGQqIGJlIGEgc2VwYXJhdGUgcHJlcGFyYXRvcnkgcGF0Y2gsIHRvbywKYnV0IEknbSBzdGFydGlu ZyB0byBmZWVsIGV2ZW4gbW9yZSBPQ0QgdGhhbiB1c3VhbCA6KQoKPiBAQCAtOTQsNyArOTUsNyBA QCBzdHJ1Y3Qgdm1kX2RldiB7Cj4gIAlzdHJ1Y3QgcGNpX2RldgkJKmRldjsKPiAgCj4gIAlzcGlu bG9ja190CQljZmdfbG9jazsKPiAtCWNoYXIgX19pb21lbQkJKmNmZ2JhcjsKPiArCXZvaWQgX19p b21lbQkJKmNmZ2JhcjsKClRoaXMgdHlwZSBjaGFuZ2UgbWlnaHQgYmUgd29ydGggcHVzaGluZyB0 byBhIHNlcGFyYXRlIHBhdGNoIHNpbmNlIHRoZQpjYXN0aW5nIGlzc3VlcyBhcmUgbm90IGNvbXBs ZXRlbHkgdHJpdmlhbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK