All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/15] usb: misc: cypress_cy7c63: update to use usb_control_msg_recv()
Date: Sun, 29 Nov 2020 21:35:59 +0530	[thread overview]
Message-ID: <20201129160612.1908074-3-anant.thazhemadam@gmail.com> (raw)
In-Reply-To: <20201129160612.1908074-1-anant.thazhemadam@gmail.com>

The newer usb_control_msg_{send|recv}() API are an improvement on the
existing usb_control_msg() as it ensures that a short read/write is treated
as an error, data can be used off the stack, and raw usb pipes need not be
created in the calling functions.
For this reason, the instance of usb_control_msg() has been replaced with
usb_control_msg_recv().

Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
 drivers/usb/misc/cypress_cy7c63.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c
index 14faec51d7a5..fc09251fc87c 100644
--- a/drivers/usb/misc/cypress_cy7c63.c
+++ b/drivers/usb/misc/cypress_cy7c63.c
@@ -70,7 +70,6 @@ static int vendor_command(struct cypress *dev, unsigned char request,
 			  unsigned char address, unsigned char data)
 {
 	int retval = 0;
-	unsigned int pipe;
 	unsigned char *iobuf;
 
 	/* allocate some memory for the i/o buffer*/
@@ -83,11 +82,10 @@ static int vendor_command(struct cypress *dev, unsigned char request,
 	dev_dbg(&dev->udev->dev, "Sending usb_control_msg (data: %d)\n", data);
 
 	/* prepare usb control message and send it upstream */
-	pipe = usb_rcvctrlpipe(dev->udev, 0);
-	retval = usb_control_msg(dev->udev, pipe, request,
-				 USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER,
-				 address, data, iobuf, CYPRESS_MAX_REQSIZE,
-				 USB_CTRL_GET_TIMEOUT);
+	retval = usb_control_msg_recv(dev->udev, 0, request,
+				      USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER,
+				      address, data, iobuf, CYPRESS_MAX_REQSIZE,
+				      USB_CTRL_GET_TIMEOUT, GFP_KERNEL);
 
 	/* store returned data (more READs to be added) */
 	switch (request) {
-- 
2.25.1


  parent reply	other threads:[~2020-11-29 16:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 16:05 [PATCH 00/15] drivers: usb: misc: update to use usb_control_msg_{send|recv}() Anant Thazhemadam
2020-11-29 16:05 ` Anant Thazhemadam
2020-11-29 16:05 ` Anant Thazhemadam
2020-11-29 16:05 ` [PATCH 01/15] usb: misc: appledisplay: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2020-11-29 16:05 ` Anant Thazhemadam [this message]
2020-11-29 16:06 ` [PATCH 03/15] usb: misc: cytherm: update to use usb_control_msg_recv() Anant Thazhemadam
2020-11-29 16:16   ` Greg Kroah-Hartman
2020-11-29 16:38     ` Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 04/15] usb: misc: ehset: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2020-11-29 16:06   ` Anant Thazhemadam
2020-11-29 16:06   ` Anant Thazhemadam
2020-12-07  2:25   ` Peter Chen
2020-12-07  2:25     ` Peter Chen
2020-12-07  2:25     ` Peter Chen
2020-11-29 16:06 ` [PATCH 05/15] usb: misc: emi26: update to use usb_control_msg_send() Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 06/15] usb: misc: emi62: " Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 07/15] usb: misc: ezusb: " Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 08/15] usb: misc: idmouse: " Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 09/15] usb: misc: iowarrior: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 10/15] usb: misc: isight_firmware: update to use usb_control_msg_send() Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 11/15] usb: misc: ldusb: " Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 12/15] usb: misc: lvstest: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 13/15] usb: misc: trancevibrator: update to use usb_control_msg_send() Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 14/15] usb: misc: usbsevseg: " Anant Thazhemadam
2020-11-29 16:06 ` [PATCH 15/15] usb: misc: usbtest: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129160612.1908074-3-anant.thazhemadam@gmail.com \
    --to=anant.thazhemadam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.