From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Sun, 29 Nov 2020 18:53:27 +0100 Subject: [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints In-Reply-To: <20201129164618.5829-5-pali@kernel.org> References: <20201129164618.5829-1-pali@kernel.org> <20201129164618.5829-5-pali@kernel.org> Message-ID: <20201129175327.GF27274@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun 2020-11-29 17:46:09, Pali Roh?r wrote: > This patch fixes configuring FIFO for one-directional endpoints which have > either RX or TX queue and therefore only one FIFO. > > Without this patch if FIFO size was zero then idx was incorrectly > calculated (expr. ffs(0)-1 is not zero) and size overflowed in fifosz > register. This register uses has only 4 bits for FIFO size. > > This patch is fixing it by setting zero size and zero address when > particular endpoint does not use FIFO. > > This issue caused loose of packets on USB bus in both directions and > basically usbtty was unusable. > > Signed-off-by: Pali Roh?r Reviewed-by: Pavel Machek -- http://www.livejournal.com/~pavelmachek -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: