From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F62C3E8C5 for ; Sun, 29 Nov 2020 18:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3072320756 for ; Sun, 29 Nov 2020 18:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbgK2SeD (ORCPT ); Sun, 29 Nov 2020 13:34:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55640 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727894AbgK2SeC (ORCPT ); Sun, 29 Nov 2020 13:34:02 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kjRVV-009NlD-6i; Sun, 29 Nov 2020 19:33:09 +0100 Date: Sun, 29 Nov 2020 19:33:09 +0100 From: Andrew Lunn To: Lee Jones Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , "David S. Miller" , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: Re: [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Message-ID: <20201129183309.GH2234159@lunn.ch> References: <20201126133853.3213268-1-lee.jones@linaro.org> <20201126133853.3213268-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126133853.3213268-2-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 01:38:46PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio' > > Cc: Nicolas Pitre > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Erik Stahlman > Cc: Peter Cammaert > Cc: Daris A Nevil > Cc: Russell King > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/net/ethernet/smsc/smc91x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c > index 56c36798cb111..3b90dc065ff2d 100644 > --- a/drivers/net/ethernet/smsc/smc91x.c > +++ b/drivers/net/ethernet/smsc/smc91x.c > @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = { > MODULE_DEVICE_TABLE(of, smc91x_match); > > #if defined(CONFIG_GPIOLIB) > -/** > +/* > * of_try_set_control_gpio - configure a gpio if it exists > * @dev: net device > * @desc: where to store the GPIO descriptor, if it exists Hi Lee This is the wrong fix. The name of the function in the documentation should be corrected. The rest looks correct. Andrew