[net] tipc: fix incompatible mtu of transmission

* [net] tipc: fix incompatible mtu of transmission
@ 2020-11-30  2:55 Hoang Huu Le
  2020-12-01 23:28 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Hoang Huu Le @ 2020-11-30  2:55 UTC (permalink / raw)
  To: jmaloy, maloy, ying.xue, netdev; +Cc: Hoang Le

From: Hoang Le <hoang.h.le@dektech.com.au>

In commit 682cd3cf946b6
("tipc: confgiure and apply UDP bearer MTU on running links"), we
introduced a function to change UDP bearer MTU and applied this new value
across existing per-link. However, we did not apply this new MTU value at
node level. This lead to packet dropped at link level if its size is
greater than new MTU value.

To fix this issue, we also apply this new MTU value for node level.

Fixes: 682cd3cf946b6 ("tipc: confgiure and apply UDP bearer MTU on running links")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
---
 net/tipc/node.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index cd67b7d5169f..9f6975dd7873 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -2182,6 +2182,8 @@ void tipc_node_apply_property(struct net *net, struct tipc_bearer *b,
 			else if (prop == TIPC_NLA_PROP_MTU)
 				tipc_link_set_mtu(e->link, b->mtu);
 		}
+		/* Update MTU for node link entry */
+		e->mtu = tipc_link_mss(e->link);
 		tipc_node_write_unlock(n);
 		tipc_bearer_xmit(net, bearer_id, &xmitq, &e->maddr, NULL);
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread