From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B697C5519F for ; Mon, 30 Nov 2020 09:56:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98BF4206D5 for ; Mon, 30 Nov 2020 09:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nTc/MyMD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbgK3Jz7 (ORCPT ); Mon, 30 Nov 2020 04:55:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:59180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbgK3Jz7 (ORCPT ); Mon, 30 Nov 2020 04:55:59 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 073F7206D5; Mon, 30 Nov 2020 09:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606730118; bh=VJxe+aZIiySmBjnGlaSzQW1nZfVZVMjYsyKKXY2wN24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nTc/MyMDZGaQb1aWyIXJO7isKzXuHw9n3D796W6lqshME6XMC6XtpUiAnp9oTN8ip cH6isvEIFEg0WYo/rfqT9aJcJliG5TrjVweoLcpc6YnZ9bX+xzWRFovsqcybXekYST b1V+2pDOrKh4pwVV+MgOPI2lm1HSsKdhW9PYoz+E= Date: Mon, 30 Nov 2020 09:55:12 +0000 From: Will Deacon To: Suzuki K Poulose Cc: Wei Li , Catalin Marinas , Mark Rutland , Anshuman Khandual , Vincenzo Frascino , Marc Zyngier , Ionela Voinescu , Ard Biesheuvel , Amit Daniel Kachhap , Vladimir Murzin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com Subject: Re: [PATCH v3] drivers/perf: Add support for ARMv8.3-SPE Message-ID: <20201130095512.GA24098@willie-the-truck> References: <20201127060322.29025-1-liwei391@huawei.com> <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2020 at 12:03:35PM +0000, Suzuki K Poulose wrote: > On 11/27/20 6:03 AM, Wei Li wrote: > > Armv8.3 extends the SPE by adding: > > - Alignment field in the Events packet, and filtering on this event > > using PMSEVFR_EL1. > > - Support for the Scalable Vector Extension (SVE). > > > > The main additions for SVE are: > > - Recording the vector length for SVE operations in the Operation Type > > packet. It is not possible to filter on vector length. > > - Incomplete predicate and empty predicate fields in the Events packet, > > and filtering on these events using PMSEVFR_EL1. > > > > Update the check of pmsevfr for empty/partial predicated SVE and > > alignment event in SPE driver. For adaption by the version of SPE, > > expose 'pmsver' as cap attribute to userspace. > > > > Signed-off-by: Wei Li > > nit: Do we need to update the Kconfig help text too ? Right now that says : > > -- > > > tristate "Enable support for the ARMv8.2 Statistical Profiling Extension"" > .... > > help > Enable perf support for the ARMv8.2 Statistical Profiling > Extension, which provides periodic sampling of operations in I think it's ok as-is, to be honest. It identifies the version of the architecture when the feature was introduced, and I think it's only reasonable to assume that subsequent versions of the architecture might add extensions. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0B4C5519F for ; Mon, 30 Nov 2020 09:56:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7DF120643 for ; Mon, 30 Nov 2020 09:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RGFw0zCG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nTc/MyMD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7DF120643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OqhGkxzucOitSxCoWuQQxny6vb4Qo41XsDPeRiQBE4U=; b=RGFw0zCGtgx8kabwhUfXdZHCC skiqjv9KGxYb55x0Ugdv8PN6lup33UEjNdju4MaG7r0yHKJOLlBz30nxaRBX1hyYXIdUBZJFRHB8X 8AznN/qhLbP7NuaDtdPqW0hAWZDpJbns/JjGDt0W9eeIBq7J/0Xp1d8AZPtENudzvpkNcOjNgYu9u 20Zx/CicA5xZy3ZFQY452boHGzI95W5efdVVS9gbsKW0pgF0yPwl/f1P+Q1pTh11bAAQ7dPK6vHPz 0B3yxs2dtdMnzvROpViFL3qviq9zjP9VTh9+2iwO6A+mtHr4GMoEa9DTSRqSzIrjeCkqkFeNFOlsS 4pch1XUFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjftx-0004T0-Bj; Mon, 30 Nov 2020 09:55:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjftv-0004SU-92 for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 09:55:20 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 073F7206D5; Mon, 30 Nov 2020 09:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606730118; bh=VJxe+aZIiySmBjnGlaSzQW1nZfVZVMjYsyKKXY2wN24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nTc/MyMDZGaQb1aWyIXJO7isKzXuHw9n3D796W6lqshME6XMC6XtpUiAnp9oTN8ip cH6isvEIFEg0WYo/rfqT9aJcJliG5TrjVweoLcpc6YnZ9bX+xzWRFovsqcybXekYST b1V+2pDOrKh4pwVV+MgOPI2lm1HSsKdhW9PYoz+E= Date: Mon, 30 Nov 2020 09:55:12 +0000 From: Will Deacon To: Suzuki K Poulose Subject: Re: [PATCH v3] drivers/perf: Add support for ARMv8.3-SPE Message-ID: <20201130095512.GA24098@willie-the-truck> References: <20201127060322.29025-1-liwei391@huawei.com> <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_045519_406961_15A8D00E X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Vladimir Murzin , Ionela Voinescu , Anshuman Khandual , Catalin Marinas , guohanjun@huawei.com, linux-kernel@vger.kernel.org, Marc Zyngier , Amit Daniel Kachhap , Vincenzo Frascino , Wei Li , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 27, 2020 at 12:03:35PM +0000, Suzuki K Poulose wrote: > On 11/27/20 6:03 AM, Wei Li wrote: > > Armv8.3 extends the SPE by adding: > > - Alignment field in the Events packet, and filtering on this event > > using PMSEVFR_EL1. > > - Support for the Scalable Vector Extension (SVE). > > > > The main additions for SVE are: > > - Recording the vector length for SVE operations in the Operation Type > > packet. It is not possible to filter on vector length. > > - Incomplete predicate and empty predicate fields in the Events packet, > > and filtering on these events using PMSEVFR_EL1. > > > > Update the check of pmsevfr for empty/partial predicated SVE and > > alignment event in SPE driver. For adaption by the version of SPE, > > expose 'pmsver' as cap attribute to userspace. > > > > Signed-off-by: Wei Li > > nit: Do we need to update the Kconfig help text too ? Right now that says : > > -- > > > tristate "Enable support for the ARMv8.2 Statistical Profiling Extension"" > .... > > help > Enable perf support for the ARMv8.2 Statistical Profiling > Extension, which provides periodic sampling of operations in I think it's ok as-is, to be honest. It identifies the version of the architecture when the feature was introduced, and I think it's only reasonable to assume that subsequent versions of the architecture might add extensions. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel