From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06A2C64E90 for ; Mon, 30 Nov 2020 13:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73E5220855 for ; Mon, 30 Nov 2020 13:10:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="D75/is2V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbgK3NKn (ORCPT ); Mon, 30 Nov 2020 08:10:43 -0500 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:22454 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgK3NKm (ORCPT ); Mon, 30 Nov 2020 08:10:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1606741841; x=1638277841; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yU4RBZDIdf9/SfV6ulpzlpSrR2PxxdPt8Zp4NcqDETM=; b=D75/is2V0072hcD2QOL5WrJz9opZw3RXuvbK9VHAO+pUuixCs3/TdnrQ DG3c7tGT8+2GGxBFqsJRt/GqkS+32TKOC2sVWbGz4adxUSmqwcfgYtori PUJzt3flT07GtxkZB+bxyzkpYQNDctPwkF5eUrnjxR0MlAIauJyY8jTYr zaVmal2W0k9mueO9KGME7gWOOipCC2XuQOW8sIxKyKCKSjSy6Kklj6wyU JfDgEcKRE5dv1vndxGHNdYiiXbDTrnnTIYLpMD1a4EDZB4qHz0TK+X8Tq n2GgSTw/iFWWWP2MjS5NMH3ZQVi9nbkDKvD+6DFU9XRIWRUBMBk7Rkeld g==; IronPort-SDR: 42TuJ3Tf4hd0dymHoAyHq7FSgqRqW2hoHbfuWJbrPNxfmFF2j15hS2JjJDRQG1AEQyC8/1KV4d UQGdpKsk9G0lxAmFnDnUen+lR2mxttxPV4GNz8mQGJLMRGVXEOAUQcofxdDVLGXH3t/UOJT8aG ETmxD5nuWbaGIc3Jd3O6PrmtJHK8WTgoqBelH1kNYmFFR9iD7QPnKGGosii1DdQ3rxe0UQeu5b 0FKqRJm0NX08SUpKn0MvfOHfwcAcNsnkoGmkNu3ThfIHMkm5wu9o+ax9hwMSOEha4VGzhBgr9O GOQ= X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="100787599" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 Nov 2020 06:09:35 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 30 Nov 2020 06:09:35 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 30 Nov 2020 06:09:35 -0700 Date: Mon, 30 Nov 2020 14:09:34 +0100 From: Steen Hegelund To: Andrew Lunn CC: "David S. Miller" , Jakub Kicinski , Rob Herring , Lars Povlsen , Bjarni Jonasson , "Microchip Linux Driver Support" , Alexandre Belloni , Microsemi List , , , , Subject: Re: [RFC PATCH 1/3] dt-bindings: net: sparx5: Add sparx5-switch bindings Message-ID: <20201130130934.o47mdjiqidtznm2t@mchp-dev-shegelun> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-2-steen.hegelund@microchip.com> <20201127170052.GV2073444@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline In-Reply-To: <20201127170052.GV2073444@lunn.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.11.2020 18:00, Andrew Lunn wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> + reg-names: >> + minItems: 153 >> + items: >> + - const: dev2g5_0 >> + - const: dev5g_0 >> + - const: pcs5g_br_0 >> + - const: dev2g5_1 >> + - const: dev5g_1 >... >> + - const: ana_ac >> + - const: vop > >> + switch: switch@600000000 { >> + compatible = "microchip,sparx5-switch"; >> + reg = <0x10004000 0x4000>, /* dev2g5_0 */ >> + <0x10008000 0x4000>, /* dev5g_0 */ >> + <0x1000c000 0x4000>, /* pcs5g_br_0 */ >> + <0x10010000 0x4000>, /* dev2g5_1 */ >> + <0x10014000 0x4000>, /* dev5g_1 */ > >... > >> + <0x11800000 0x100000>, /* ana_l2 */ >> + <0x11900000 0x100000>, /* ana_ac */ >> + <0x11a00000 0x100000>; /* vop */ > >This is a pretty unusual binding. > >Why is it not > >reg = <0x10004000 0x1af8000> > >and the driver can then break up the memory into its sub ranges? > > Andrew Hi Andrew, Since the targets used by the driver is not always in the natural address order (e.g. the dev2g5_x targets), I thought it best to let the DT take care of this since this cannot be probed. I am aware that this causes extra mappings compared to the one-range strategy, but this layout seems more transparent to me, also when mapped over PCIe. BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41221C64E7B for ; Mon, 30 Nov 2020 13:10:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC80920825 for ; Mon, 30 Nov 2020 13:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="haoLnT1z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="tEQCckzo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC80920825 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LgngOHzkrwlEim8C5h/chuPTP1FbXCVusupDQ2eG0MI=; b=haoLnT1zsq2Y4S1CJvwTop/UM 2RX5vAHEeon5InL8380vSRk5bClLz4rbroU4WWHIQseG9G9xi4Zmu443fQuM7N+5/qw9S5zqZImCu LmnUbwHhJ7tcjp3Z79IVgF43iEe6I3jWIT6cyIcz/Z0FHsNAWuxcb6gRUZwNJLJGE5I9sKeboDTvZ psHC8Pxfck4t7N9AFK8D8mGkJgeXeoJoRHC/hG/HPBslfvEQYo8YGIkI2uEPXsBnbhuxfmetfQVaD Qek21Zve1KMHiu30ivH0H+gvoyM/NGzHj0Y8ihm2qlCSYJ9+mzZ4M5FslLC75Tf3fMC1Iv+jV+Zx4 Yx6tENv+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjiw2-0004rx-QB; Mon, 30 Nov 2020 13:09:42 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjivz-0004qv-G3 for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 13:09:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1606741779; x=1638277779; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yU4RBZDIdf9/SfV6ulpzlpSrR2PxxdPt8Zp4NcqDETM=; b=tEQCckzoFgeEAO6+xR6mK4jrhGmCdu14Q2/rfVZElZYHG+GmzPhzNxKc oiWgYqoISP8MqoObiyt42GDlniyZInWH+idQelw7uPv0NUdwp3cz3Zcjj hjAFbZ/S9qWifG1NhOCjFQ9wMKZ2czefEX8uFQ06N3MvxIDVI4VEULE5d MxBGsnowcyvWNvcsZRGJH6tMt/zFf6J3Xs4C2AcfUsvKh3k236BlpB2lU DoBEVg59nMevhB8454hPzYrD1Fcmu2NmN1N2+qv2riMNuReKLkQsDDsfb +wdkc5cuAfYLNe0Zr6SrskA///modYSB3ogVwhYOtFiI1uSymruLMAnaR g==; IronPort-SDR: 42TuJ3Tf4hd0dymHoAyHq7FSgqRqW2hoHbfuWJbrPNxfmFF2j15hS2JjJDRQG1AEQyC8/1KV4d UQGdpKsk9G0lxAmFnDnUen+lR2mxttxPV4GNz8mQGJLMRGVXEOAUQcofxdDVLGXH3t/UOJT8aG ETmxD5nuWbaGIc3Jd3O6PrmtJHK8WTgoqBelH1kNYmFFR9iD7QPnKGGosii1DdQ3rxe0UQeu5b 0FKqRJm0NX08SUpKn0MvfOHfwcAcNsnkoGmkNu3ThfIHMkm5wu9o+ax9hwMSOEha4VGzhBgr9O GOQ= X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="100787599" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 Nov 2020 06:09:35 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 30 Nov 2020 06:09:35 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 30 Nov 2020 06:09:35 -0700 Date: Mon, 30 Nov 2020 14:09:34 +0100 From: Steen Hegelund To: Andrew Lunn Subject: Re: [RFC PATCH 1/3] dt-bindings: net: sparx5: Add sparx5-switch bindings Message-ID: <20201130130934.o47mdjiqidtznm2t@mchp-dev-shegelun> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-2-steen.hegelund@microchip.com> <20201127170052.GV2073444@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201127170052.GV2073444@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_080939_760301_10E48EB1 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjarni Jonasson , Alexandre Belloni , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Rob Herring , Microsemi List , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , "David S. Miller" , Lars Povlsen Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27.11.2020 18:00, Andrew Lunn wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> + reg-names: >> + minItems: 153 >> + items: >> + - const: dev2g5_0 >> + - const: dev5g_0 >> + - const: pcs5g_br_0 >> + - const: dev2g5_1 >> + - const: dev5g_1 >... >> + - const: ana_ac >> + - const: vop > >> + switch: switch@600000000 { >> + compatible = "microchip,sparx5-switch"; >> + reg = <0x10004000 0x4000>, /* dev2g5_0 */ >> + <0x10008000 0x4000>, /* dev5g_0 */ >> + <0x1000c000 0x4000>, /* pcs5g_br_0 */ >> + <0x10010000 0x4000>, /* dev2g5_1 */ >> + <0x10014000 0x4000>, /* dev5g_1 */ > >... > >> + <0x11800000 0x100000>, /* ana_l2 */ >> + <0x11900000 0x100000>, /* ana_ac */ >> + <0x11a00000 0x100000>; /* vop */ > >This is a pretty unusual binding. > >Why is it not > >reg = <0x10004000 0x1af8000> > >and the driver can then break up the memory into its sub ranges? > > Andrew Hi Andrew, Since the targets used by the driver is not always in the natural address order (e.g. the dev2g5_x targets), I thought it best to let the DT take care of this since this cannot be probed. I am aware that this causes extra mappings compared to the one-range strategy, but this layout seems more transparent to me, also when mapped over PCIe. BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel