Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

From: Steen Hegelund <steen.hegelund@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Bjarni Jonasson <bjarni.jonasson@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Microsemi List <microsemi@lists.bootlin.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver
Date: Mon, 30 Nov 2020 14:31:14 +0100	[thread overview]
Message-ID: <20201130133114.ifjtn366yanj2z3c@mchp-dev-shegelun> (raw)
In-Reply-To: <20201129172607.GE2234159@lunn.ch>

On 29.11.2020 18:26, Andrew Lunn wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +static void sparx5_hw_lock(struct sparx5 *sparx5)
>> +{
>> +     mutex_lock(&sparx5->lock);
>> +}
>> +
>> +static void sparx5_hw_unlock(struct sparx5 *sparx5)
>> +{
>> +     mutex_unlock(&sparx5->lock);
>> +}
>
>Why is this mutex special and gets a wrapper where as the other two
>don't? If there is no reason for the wrapper, please remove it.
>
>       Andrew

Hi Andrew,

There is no need for any special treatment, so I will remove the
wrapper.

BR
Steen

---------------------------------------
Steen Hegelund
steen.hegelund@microchip.com