Reviewed-by: Rodrigo Siqueira On 11/30, Wayne Lin wrote: > Fixes below compiler warnings: > > All warnings (new ones prefixed by >>): > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5: > warning: no previous prototype for function > 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes] > int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, > ^ > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1: > note: declare 'static' if the function is not intended to be used > outside of this translation unit > int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, > ^ > static > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5: > warning: no previous prototype for function > 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes] > int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, > ^ > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1: > note: declare 'static' if the function is not intended to be used > outside of this translation unit > int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, > ^ > static > 2 warnings generated. > > Reported-by: kernel test robot > Signed-off-by: Wayne Lin > --- > amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/amdgpu_dm/amdgpu_dm.c b/amdgpu_dm/amdgpu_dm.c > index 1818d9392..f42046d04 100644 > --- a/amdgpu_dm/amdgpu_dm.c > +++ b/amdgpu_dm/amdgpu_dm.c > @@ -4975,7 +4975,7 @@ dm_crtc_duplicate_state(struct drm_crtc *crtc) > } > > #ifdef CONFIG_DEBUG_FS > -int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, > +static int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, > struct drm_crtc_state *crtc_state, > struct drm_property *property, > uint64_t val) > @@ -4999,7 +4999,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, > return 0; > } > > -int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, > +static int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, > const struct drm_crtc_state *state, > struct drm_property *property, > uint64_t *val) > -- > 2.17.1 > -- Rodrigo Siqueira https://siqueira.tech