From: "Uwe Kleine-König" <firstname.lastname@example.org> To: Michael Walle <email@example.com>, Thierry Reding <firstname.lastname@example.org>, Lee Jones <email@example.com> Cc: firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] pwm: sl28cpld: fix getting driver data in pwm callbacks Date: Mon, 30 Nov 2020 15:58:05 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> [-- Attachment #1: Type: text/plain, Size: 1699 bytes --] Hello Michael, On Mon, Nov 30, 2020 at 09:17:52AM +0100, Michael Walle wrote: > Am 2020-11-24 22:24, schrieb Uwe Kleine-König: > > Currently .get_state() and .apply() use dev_get_drvdata() on the struct > > device related to the pwm chip. This only works after .probe() called > > platform_set_drvdata() which in this driver happens only after > > pwmchip_add() and so comes possibly too late. > > > > Instead of setting the driver data earlier use the traditional > > container_of approach as this way the driver data is conceptually and > > computational nearer. > > > > Fixes: 9db33d221efc ("pwm: Add support for sl28cpld PWM controller") > > Signed-off-by: Uwe Kleine-König <firstname.lastname@example.org> > > --- > > Hello, > > > > in v4 of the driver Michael still used container_of and then changed to > > use dev_get_drvdata() as Lee suggested. I didn't notice this suggestion, > > otherwise I would have expressed my variance about this already earlier. > > > > I noticed this problem because Michael contacted me via irc and showed > > me the resulting oops, so I think applying this before 5.10 would be > > good. It's not entirely clear to me why .get_state() is called that > > early in his case, but the theory is clear: The callbacks can be called > > as soon as pwmchip_add() is called. > > > > Best regards > > Uwe > > Ping. Would be nice if this makes it into v5.10. Yes, fully agreed. @Thierry: Do you care to send it to Linus? Or are you ok if I do that? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-30 14:59 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-24 21:24 Uwe Kleine-König 2020-11-24 22:22 ` Michael Walle 2020-11-25 6:48 ` Uwe Kleine-König 2020-11-30 8:17 ` Michael Walle 2020-11-30 14:58 ` Uwe Kleine-König [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] pwm: sl28cpld: fix getting driver data in pwm callbacks' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.