From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CCDC63777 for ; Mon, 30 Nov 2020 17:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 908A22073C for ; Mon, 30 Nov 2020 17:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387612AbgK3RdA (ORCPT ); Mon, 30 Nov 2020 12:33:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:58096 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387404AbgK3RdA (ORCPT ); Mon, 30 Nov 2020 12:33:00 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E450AC90; Mon, 30 Nov 2020 17:32:19 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id B1249DA6E1; Mon, 30 Nov 2020 18:30:47 +0100 (CET) Date: Mon, 30 Nov 2020 18:30:47 +0100 From: David Sterba To: fdmanana@kernel.org Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 0/6] btrfs: some performance improvements for dbench alike workloads Message-ID: <20201130173047.GH6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, fdmanana@kernel.org, linux-btrfs@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Nov 25, 2020 at 12:19:22PM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana > > This patchset mostly fixes some races that result in an fsync falling back > to a transaction commit unncessarily or logging more metadata than it needs > to. It also addresses link and rename operations logging inodes that were > fsynced in the previous transaction but they don't need to be logged in > the current transaction. All these cases can be triggered often by dbench. > > Finally it avoids blocking an fsync for a significant time window when the > previous transaction is still committing. All these together resulted in > about +12% throughput with dbench and -8% maximum latency, as mentioned in > the changelog of the last patch. > > There will be more changes to improve performance with dbench or similar > workloads, but these have been cooking and testing for about one week and > are independent from what's coming next. Looking forward to more perf improvements, much appreciated. > Filipe Manana (6): > btrfs: fix race causing unnecessary inode logging during link and rename > btrfs: fix race that results in logging old extents during a fast fsync > btrfs: fix race that causes unnecessary logging of ancestor inodes > btrfs: fix race that makes inode logging fallback to transaction commit > btrfs: fix race leading to unnecessary transaction commit when logging inode > btrfs: do not block inode logging for so long during transaction commit Added to misc-next, thanks.