From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD74C64E8A for ; Mon, 30 Nov 2020 17:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF6B420870 for ; Mon, 30 Nov 2020 17:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387661AbgK3RyF (ORCPT ); Mon, 30 Nov 2020 12:54:05 -0500 Received: from mga14.intel.com ([192.55.52.115]:28816 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387401AbgK3RyF (ORCPT ); Mon, 30 Nov 2020 12:54:05 -0500 IronPort-SDR: CLW0M/cQsoOkaGVfL/iHTHLW0mbHEPLMJJtzkbMUME0o1VXxLhPVoLRRI4hp7jd08EfhBj+hci XZkb3QaVXpMg== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="171894430" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="171894430" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:52:24 -0800 IronPort-SDR: V0bNb5yO6AkYF+Cez/uXxoQER/JpakSYM0Ftqb1TH/QIgvau+UHpDGd79ZqrP3kCTOkR7evfJe 1/rfTSeuhHCQ== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="315352526" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:52:18 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kjnMV-00B6Dj-7j; Mon, 30 Nov 2020 19:53:19 +0200 Date: Mon, 30 Nov 2020 19:53:19 +0200 From: Andy Shevchenko To: Laurent Pinchart Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 02/18] property: Add support for calling fwnode_graph_get_endpoint_by_id() for fwnode->secondary Message-ID: <20201130175319.GS4077@smile.fi.intel.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-3-djrscally@gmail.com> <20201130172900.GM4077@smile.fi.intel.com> <20201130172857.GS14465@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130172857.GS14465@pendragon.ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Nov 30, 2020 at 07:28:57PM +0200, Laurent Pinchart wrote: > On Mon, Nov 30, 2020 at 07:29:00PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 30, 2020 at 01:31:13PM +0000, Daniel Scally wrote: ... > > > + if (!best_ep && fwnode && !IS_ERR_OR_NULL(fwnode->secondary)) > > > + return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port, > > > + endpoint, flags); > > > > > return best_ep; > > > > Can we, please, do > > > > if (best_ep) > > return best_ep; > > > > if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary)) > > return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port, > > endpoint, flags); > > > > return NULL; > > > > ? > > > > This 'if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary))' becomes kinda > > idiomatic to the cases when we need to proceed primary followed by the > > secondary in cases where it's not already done. > > We could also move the !fwnode check to the beginning of the function. It's already there (1). What did I miss? 1) via fwnode_graph_get_next_endpoint() -> fwnode_call_ptr_op() -- With Best Regards, Andy Shevchenko