From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D70C63777 for ; Mon, 30 Nov 2020 19:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64AAC20674 for ; Mon, 30 Nov 2020 19:56:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kngn4LeL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388220AbgK3T4v (ORCPT ); Mon, 30 Nov 2020 14:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726769AbgK3T4v (ORCPT ); Mon, 30 Nov 2020 14:56:51 -0500 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2838DC0613CF for ; Mon, 30 Nov 2020 11:56:05 -0800 (PST) Received: by mail-pj1-x1049.google.com with SMTP id p20so272911pjz.0 for ; Mon, 30 Nov 2020 11:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=DLtArDV8cKP0BeVklsVGWZ4r7522fWxRlpZkbLI2DME=; b=Kngn4LeLTwq4qYdSAXMCdhjRvG2+hfAwezvYYxclNLH4UYmaXcHHHm/oDA7haEQqo5 cDgZ9CTL0bEBGcADB4JOqwDiXbdJifF4LwJgDbjttt2y9O+5miEIVUz2RYOGgeK4NbXj AZHT/WuYNGIuZ+g8cSddgDUX/X/wdLKAeH5yE1Nh6rDk+ejhrEqeGQWhdv05kN+gQ9Uh oOmj6zDFqIWJQpVkAoxeNann4anzRJS+12uX8GB2/354ozUtuLyoprqIvdEFHrYVQBXR J0hiCEXvI45QzTD2c934ITS2t0agvN8pr8586/Tl43yb3ixwscsBmaJeFId+9Gzx78bV bteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=DLtArDV8cKP0BeVklsVGWZ4r7522fWxRlpZkbLI2DME=; b=IomCQaLZwvD+1SQVJxhBxsSJrV6QGONnHD13p0MEU2jklyfjVhFH+zNcTolEfrmqI/ q7jOx/C3UgjmC5Sf94L30tTfA9Ld1ZVfN3YK/C2ewiS7lVNtg/wj+StCP+BSPt9tEgTO gxCz2JAuWx3/EmtG0mAa2GWFWQJE3ZNRoq6RzhmuU0bXbkiRrzgy+qLzCM0eczJ7MtsT mrIHKk4TWzfh13w/GWgkWjoAw7KSTNupARY/O2Dy40x8AGkai9l7EIfElOK1T//laPgm 0foQQs+GU9B0sH3H5evavrDegrK/mv0r1nLhFzzoPy8+LISCf0Z8ZcEf7GABh5lwGmGk g4mQ== X-Gm-Message-State: AOAM531MCbdQytAeowUc4twJmyRsPtK+I0g/ZMRZn2tBfhQ5wAZiqSwp MrK8QTitMfT7KlQ2C+TK/0sLvqD/x2MT0ZzZfkA= X-Google-Smtp-Source: ABdhPJzB688RhMdWZtegBv6aVz52FbjVdJ0Q+QuBT876w4Q6KmkjclwwABgZ0Hd+nwZUsJGEaNoSrmQC9+tOAwhsDUU= Sender: "ndesaulniers via sendgmr" X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a17:90a:f28f:: with SMTP id fs15mr495886pjb.121.1606766164462; Mon, 30 Nov 2020 11:56:04 -0800 (PST) Date: Mon, 30 Nov 2020 11:56:02 -0800 In-Reply-To: <20201110162211.9207-6-yu-cheng.yu@intel.com> Message-Id: <20201130195602.331842-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <20201110162211.9207-6-yu-cheng.yu@intel.com> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: Re: [PATCH v15 05/26] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack From: Nick Desaulniers To: yu-cheng.yu@intel.com Cc: Dave.Martin@arm.com, arnd@arndb.de, bp@alien8.de, bsingharora@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com, esyr@redhat.com, fweimer@redhat.com, gorcunov@gmail.com, hjl.tools@gmail.com, hpa@zytor.com, jannh@google.com, keescook@chromium.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mike.kravetz@oracle.com, mingo@redhat.com, nadav.amit@gmail.com, oleg@redhat.com, pavel@ucw.cz, pengfei.xu@intel.com, peterz@infradead.org, ravi.v.shankar@intel.com, rdunlap@infradead.org, tglx@linutronix.de, vedvyas.shanbhogue@intel.com, weijiang.yang@intel.com, x86@kernel.org, Sami Tolvanen , Will Deacon , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In response to https://lore.kernel.org/lkml/20201110162211.9207-6-yu-cheng.yu@intel.com/. Hi Yu-cheng, This feature reminds me very much of ARCH_SUPPORTS_SHADOW_CALL_STACK/CC_HAVE_SHADOW_CALL_STACK implemented in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5287569a790d2546a06db07e391bf84b8bd6cf51. Do you think it would be worthwhile to share the same config name between x86 and aarch64? (Though, it seems on x86 there will be a distinction between kernel mode and user mode configs, if I understand correctly?) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D53CC63777 for ; Mon, 30 Nov 2020 19:56:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4FF62063A for ; Mon, 30 Nov 2020 19:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Kngn4LeL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4FF62063A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22A756B0036; Mon, 30 Nov 2020 14:56:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B3C78D0002; Mon, 30 Nov 2020 14:56:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07BE48D0001; Mon, 30 Nov 2020 14:56:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id E01996B0036 for ; Mon, 30 Nov 2020 14:56:06 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9E644181AC9BF for ; Mon, 30 Nov 2020 19:56:06 +0000 (UTC) X-FDA: 77542140732.28.bat22_2f00cc0273a4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 7D3A86D65 for ; Mon, 30 Nov 2020 19:56:06 +0000 (UTC) X-HE-Tag: bat22_2f00cc0273a4 X-Filterd-Recvd-Size: 4147 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Nov 2020 19:56:05 +0000 (UTC) Received: by mail-pj1-f74.google.com with SMTP id b4so242465pjh.8 for ; Mon, 30 Nov 2020 11:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=DLtArDV8cKP0BeVklsVGWZ4r7522fWxRlpZkbLI2DME=; b=Kngn4LeLTwq4qYdSAXMCdhjRvG2+hfAwezvYYxclNLH4UYmaXcHHHm/oDA7haEQqo5 cDgZ9CTL0bEBGcADB4JOqwDiXbdJifF4LwJgDbjttt2y9O+5miEIVUz2RYOGgeK4NbXj AZHT/WuYNGIuZ+g8cSddgDUX/X/wdLKAeH5yE1Nh6rDk+ejhrEqeGQWhdv05kN+gQ9Uh oOmj6zDFqIWJQpVkAoxeNann4anzRJS+12uX8GB2/354ozUtuLyoprqIvdEFHrYVQBXR J0hiCEXvI45QzTD2c934ITS2t0agvN8pr8586/Tl43yb3ixwscsBmaJeFId+9Gzx78bV bteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=DLtArDV8cKP0BeVklsVGWZ4r7522fWxRlpZkbLI2DME=; b=BchDQ47X0kVibIY7tIXx4GyCuP56uIe8h8QZaA0XWtJGZ0hCFe4eZyBzMnG1a8N0Ru tKCWnzOzvgHtArYyaL7nKAOrl4damBdOlrTiTFyULcJazYDU3KCQhDQ5Bdv2881I9ug9 DcQW3++2X7BCZvOW7l9rctvho4YeaynU62M9RSKpWKTfMPdP/BuyL0sfDL9YY39Jsg5F ao7v+N3NJjSENPzbiG/kob0dc1iVHBf5eo4fjapP+p44os+dUo1Vlwf0L6L39eF1JkS4 2SLBdH2NH3IRxj29TtzpQlGBkTBVmjLMNsm5kgdJSKx1XnEG5B6Lq7L6+gjmW8gjVH7L CckQ== X-Gm-Message-State: AOAM532bn+lEOUuwYO5f0w4fNX5jGxzvO3MgjBNz0S8+09dCi1/yVhlP 0wClLWn/CXWoRdDWU30x3EUQUBxH6QSyK6NiQ1k= X-Google-Smtp-Source: ABdhPJzB688RhMdWZtegBv6aVz52FbjVdJ0Q+QuBT876w4Q6KmkjclwwABgZ0Hd+nwZUsJGEaNoSrmQC9+tOAwhsDUU= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a17:90a:f28f:: with SMTP id fs15mr495886pjb.121.1606766164462; Mon, 30 Nov 2020 11:56:04 -0800 (PST) Date: Mon, 30 Nov 2020 11:56:02 -0800 In-Reply-To: <20201110162211.9207-6-yu-cheng.yu@intel.com> Message-Id: <20201130195602.331842-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <20201110162211.9207-6-yu-cheng.yu@intel.com> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: Re: [PATCH v15 05/26] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack From: Nick Desaulniers To: yu-cheng.yu@intel.com Cc: Dave.Martin@arm.com, arnd@arndb.de, bp@alien8.de, bsingharora@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com, esyr@redhat.com, fweimer@redhat.com, gorcunov@gmail.com, hjl.tools@gmail.com, hpa@zytor.com, jannh@google.com, keescook@chromium.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mike.kravetz@oracle.com, mingo@redhat.com, nadav.amit@gmail.com, oleg@redhat.com, pavel@ucw.cz, pengfei.xu@intel.com, peterz@infradead.org, ravi.v.shankar@intel.com, rdunlap@infradead.org, tglx@linutronix.de, vedvyas.shanbhogue@intel.com, weijiang.yang@intel.com, x86@kernel.org, Sami Tolvanen , Will Deacon , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In response to https://lore.kernel.org/lkml/20201110162211.9207-6-yu-cheng.yu@intel.com/. Hi Yu-cheng, This feature reminds me very much of ARCH_SUPPORTS_SHADOW_CALL_STACK/CC_HAVE_SHADOW_CALL_STACK implemented in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5287569a790d2546a06db07e391bf84b8bd6cf51. Do you think it would be worthwhile to share the same config name between x86 and aarch64? (Though, it seems on x86 there will be a distinction between kernel mode and user mode configs, if I understand correctly?)