From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FA8C71156 for ; Mon, 30 Nov 2020 23:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29B5C20C56 for ; Mon, 30 Nov 2020 23:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729610AbgK3Xnn (ORCPT ); Mon, 30 Nov 2020 18:43:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58712 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729078AbgK3Xnn (ORCPT ); Mon, 30 Nov 2020 18:43:43 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kjsD9-009b1o-Vw; Tue, 01 Dec 2020 00:03:59 +0100 Date: Tue, 1 Dec 2020 00:03:59 +0100 From: Andrew Lunn To: Aryan Srivastava Cc: robh+dt@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chris.packham@alliedtelesis.co.nz Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Message-ID: <20201130230359.GH2073444@lunn.ch> References: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: > Add device tree file for x530 board. This has an Armada 385 SoC. Has > NAND-flash for user storage and SPI for booting. Covers majority of x530 > and GS980MX variants. Hi Aryan What exactly does that mean, it covers most variants? I'm just wondering if this should be a .dtsi file, and then each variant has a .dts file specific to it? Or is the hardware itself the same, and only the software varies between the variants? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D15C64E90 for ; Mon, 30 Nov 2020 23:07:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC6242076C for ; Mon, 30 Nov 2020 23:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o7VSOoo9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NhfPNOtA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC6242076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hxAiXJtCwSSO2wcS2jPLqnkeqKmdWtV036ItRWIHJNg=; b=o7VSOoo9uoZMtJjamFbIpl8ya Fpltzbph+AghupkGexMp7mdUWDq/ECWcT4greIua5Lr9K8vfApECGUQOAyv8F4HgK6pziw2PPUaJy vmcEcC+SAMjVNxaYnju+VMdwnGJc6FZbCceRCuuyl/p+nybgdomj6e9kFv9Obri+XKR8aMY1L6BJh wx56SYXj6v9/w6efwVRbHx0VWq8n/UtwUTUwrRMU+QsPPSfXgjwEeVd6nwxOBSNYs6L6ZPBdjEvp2 FJrD9jourIq/pj9WKTs+ChvLadKUwI5HRCwc5BZAt8esbXg1hYakcxTvqlTo3WJxLK/rlFyXVllN9 M3urbLpwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjsDz-0007uE-3Y; Mon, 30 Nov 2020 23:04:51 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjsDw-0007u7-TE for linux-arm-kernel@merlin.infradead.org; Mon, 30 Nov 2020 23:04:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JGvE1dbOKda2/WHrIP/Ro/kGamBbUtD5RKgL7QaldPU=; b=NhfPNOtARZOPnjVga+1fWQTJ5W vXy90w3yp4zCwAbL7yJf6YF8cwqWDxBa1YC1HXMVjaBCu1qdPAFu1CzO/7y/LfH5cTYVQHm89XJs5 DGRQpW/DQOD6DUE9u1YuzVlgHPvWci7VPhcGgBd9AcXmfK0Y+gGgh10i4YrLduxMcsHyL3z6TiUMA IMCRzAkANJ1x753WY2TxAX1e4y1emmBcGmLlOqwO5dcsV+S//RU6xm9tpDdhfu1hicuk8HQa1LQbH 5dm5EGt3PMsYuvnLd5bXci9Xacyn4t7SEswPyL2G8etB7uAkyNRhwlRv9ku+kuZSibwP6uXSn0kKG iuefb+xw==; Received: from vps0.lunn.ch ([185.16.172.187]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjsDq-0000Gs-N8 for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 23:04:47 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kjsD9-009b1o-Vw; Tue, 01 Dec 2020 00:03:59 +0100 Date: Tue, 1 Dec 2020 00:03:59 +0100 From: Andrew Lunn To: Aryan Srivastava Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Message-ID: <20201130230359.GH2073444@lunn.ch> References: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_230444_179242_4AB1D53A X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, chris.packham@alliedtelesis.co.nz, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: > Add device tree file for x530 board. This has an Armada 385 SoC. Has > NAND-flash for user storage and SPI for booting. Covers majority of x530 > and GS980MX variants. Hi Aryan What exactly does that mean, it covers most variants? I'm just wondering if this should be a .dtsi file, and then each variant has a .dts file specific to it? Or is the hardware itself the same, and only the software varies between the variants? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel