All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Network Development <netdev@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: warnings from MTU setting on switch ports
Date: Tue, 1 Dec 2020 00:11:14 +0100	[thread overview]
Message-ID: <20201130231114.GI2073444@lunn.ch> (raw)
In-Reply-To: <20201130223507.rav22imba73dtfxb@skbuf>

> > A thought: Shouldn't the initialization of slave_dev->max_mtu in
> > dsa_slave_create() be capped by master->max_mtu minus tag overhead?
> 
> Talk to Andrew:
> https://www.spinics.net/lists/netdev/msg645810.html

Yes, this is historic. DSA started life with Marvell switches
connected to Marvell MACs. And Marvell MACs always allowed frames
bigger than the MTU to be sent/received. A few more MACs were paired
with Marvell switches, and they also happened to allow bigger frames
than the MTU to be used. So it all worked fine until a MAC/Switch pair
came along where the MAC did not pass frames bigger than the MTU. We
could not break backwards compatibility, so decided to ask the MAC to
up its MTU, but not error out if it failed. It was like that for a
long time, until Vladimir added jumbo support. Then you do need to
know if the MAC supports bigger MTU, so you can disallow jumbo. So
this warning got added.

     Andrew

  parent reply	other threads:[~2020-11-30 23:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 14:30 warnings from MTU setting on switch ports Rasmus Villemoes
2020-11-30 16:04 ` Vladimir Oltean
2020-11-30 22:13   ` Rasmus Villemoes
2020-11-30 22:35     ` Vladimir Oltean
2020-11-30 22:50       ` Rasmus Villemoes
2020-11-30 23:11       ` Andrew Lunn [this message]
2020-12-05 14:49     ` vlan_filtering=1 breaks all traffic (was: Re: warnings from MTU setting on switch ports) Rasmus Villemoes
2020-12-05 15:45       ` Russell King - ARM Linux admin
2020-12-05 16:02         ` vlan_filtering=1 breaks all traffic Rasmus Villemoes
2020-12-05 19:03       ` vlan_filtering=1 breaks all traffic (was: Re: warnings from MTU setting on switch ports) Vladimir Oltean
2020-12-05 20:13         ` vlan_filtering=1 breaks all traffic Rasmus Villemoes
2020-12-06 19:45           ` Vladimir Oltean
2020-12-07 19:43             ` Rasmus Villemoes
2020-12-07 20:15               ` Vladimir Oltean
2020-12-08  2:22                 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130231114.GI2073444@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.