From: Oscar Salvador <firstname.lastname@example.org> To: Vlastimil Babka <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Naoya Horiguchi <firstname.lastname@example.org> Subject: Re: [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Date: Tue, 1 Dec 2020 12:35:16 +0100 [thread overview] Message-ID: <20201201113511.GA22242@linux> (raw) In-Reply-To: <email@example.com> On Wed, Nov 25, 2020 at 07:20:33PM +0100, Vlastimil Babka wrote: > On 11/19/20 11:57 AM, Oscar Salvador wrote: > > From: Naoya Horiguchi <firstname.lastname@example.org> > > > > The call to get_user_pages_fast is only to get the pointer to a struct > > page of a given address, pinning it is memory-poisoning handler's job, > > so drop the refcount grabbed by get_user_pages_fast(). > > > > Note that the target page is still pinned after this put_page() because > > the current process should have refcount from mapping. > > Well, but can't it go away due to reclaim, migration or whatever? Yes, it can. > > @@ -900,20 +900,23 @@ static int madvise_inject_error(int behavior, > > */ > > size = page_size(compound_head(page)); > > + /* > > + * The get_user_pages_fast() is just to get the pfn of the > > + * given address, and the refcount has nothing to do with > > + * what we try to test, so it should be released immediately. > > + * This is racy but it's intended because the real hardware > > + * errors could happen at any moment and memory error handlers > > + * must properly handle the race. > > Sure they have to. We might just be unexpectedly messing with other process' > memory. Or does anything else prevent that? No, nothing does, and I have to confess that I managed to confuse myself here. If we release such page and that page ends up in buddy, nothing prevents someone else to get that page, and then we would be messing with other process memory. I guess the right thing to do is just to make sure we got that page and that that page remains pinned as long as the memory failure handling goes. I will remove those patches from the patchset and re-submit with only the refactoring and pcp-disabling. Thanks Vlastimil -- Oscar Salvador SUSE L3
next prev parent reply other threads:[~2020-12-01 11:36 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 10:57 [PATCH 0/7] HWPoison: Refactor get page interface Oscar Salvador 2020-11-19 10:57 ` [PATCH 1/7] mm,hwpoison: Refactor get_any_page Oscar Salvador 2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也) 2020-11-25 16:54 ` Vlastimil Babka 2020-11-19 10:57 ` [PATCH 2/7] mm,hwpoison: Drop pfn parameter Oscar Salvador 2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也) 2020-11-25 16:55 ` Vlastimil Babka 2020-11-19 10:57 ` [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Oscar Salvador 2020-11-25 18:20 ` Vlastimil Babka 2020-12-01 11:35 ` Oscar Salvador [this message] 2020-12-04 17:25 ` Vlastimil Babka 2020-12-05 15:34 ` Oscar Salvador 2020-12-07 2:34 ` HORIGUCHI NAOYA(堀口 直也) 2020-12-07 7:24 ` Oscar Salvador 2020-11-19 10:57 ` [PATCH 4/7] mm,hwpoison: remove MF_COUNT_INCREASED Oscar Salvador 2020-11-19 10:57 ` [PATCH 5/7] mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador 2020-11-19 10:57 ` [PATCH 6/7] mm,hwpoison: Disable pcplists before grabbing a refcount Oscar Salvador 2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也) 2020-11-26 13:45 ` Vlastimil Babka 2020-11-28 0:51 ` Andrew Morton 2020-11-19 10:57 ` [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page Oscar Salvador 2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也) 2020-11-26 13:52 ` Vlastimil Babka 2020-11-27 7:20 ` Oscar Salvador 2020-12-02 13:34 ` [PATCH 0/7] HWPoison: Refactor get page interface Qian Cai 2020-12-02 13:41 ` Oscar Salvador
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201201113511.GA22242@linux \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.