From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F317C83013 for ; Tue, 1 Dec 2020 18:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 336F0208C3 for ; Tue, 1 Dec 2020 18:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731093AbgLASc3 (ORCPT ); Tue, 1 Dec 2020 13:32:29 -0500 Received: from mga03.intel.com ([134.134.136.65]:57354 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729907AbgLASc2 (ORCPT ); Tue, 1 Dec 2020 13:32:28 -0500 IronPort-SDR: v1rLwKhuY+QuZYK91E/wSW7W8DPVJ7w2GRL4OagZqBfot0pRCA8th3tr8hXSIKzTatMBAxHw1J hl9GTQOf0eBw== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="172979594" X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="172979594" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 10:30:46 -0800 IronPort-SDR: w94DK1WYz2kVijJmCAm7U5E8Ycz+LLKPkSJ0tTZhaiEulD6TyTP3p2QW9AWgyJkMhmzjXf5sDx du8GyQZRfBgA== X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="481208366" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 10:30:39 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kkAR9-00BKxI-LB; Tue, 01 Dec 2020 20:31:39 +0200 Date: Tue, 1 Dec 2020 20:31:39 +0200 From: Andy Shevchenko To: Dan Scally Cc: Jean-Michel Hautbois , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com, Laurent Pinchart Subject: Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device Message-ID: <20201201183139.GH4077@smile.fi.intel.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-19-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Nov 30, 2020 at 11:20:55PM +0000, Dan Scally wrote: > On 30/11/2020 16:17, Jean-Michel Hautbois wrote: ... > but the ACPI table doesn't define an I2CSerialBusV2 for it. Instead it's > rolled under the sensor's entry, there's a second entry in _CRS for the > sensor that matches the address of the new device: > > > Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings > { > Name (SBUF, ResourceTemplate () > { > I2cSerialBusV2 (0x0036, ControllerInitiated, 0x00061A80, > AddressingMode7Bit, "\\_SB.PCI0.I2C2", > 0x00, ResourceConsumer, , Exclusive, > ) > I2cSerialBusV2 (0x000C, ControllerInitiated, 0x00061A80, > AddressingMode7Bit, "\\_SB.PCI0.I2C2", > 0x00, ResourceConsumer, , Exclusive, > ) > }) > Return (SBUF) /* \_SB_.PCI0.CAM0._CRS.SBUF */ > } > > So that's another thing we need to work on. At the moment it doesn't > exist as far as the kernel is concerned. Maybe something along i2c-multi-instantiate can help here (maybe not). P.S. Dan, can you drop unrelated text when replying? -- With Best Regards, Andy Shevchenko