From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A100BC64E7A for ; Tue, 1 Dec 2020 22:19:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E7D52086A for ; Tue, 1 Dec 2020 22:19:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7D52086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 59F8A6E932; Tue, 1 Dec 2020 22:19:06 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD4016E930 for ; Tue, 1 Dec 2020 22:19:04 +0000 (UTC) IronPort-SDR: KzU1Xx5J3CmrVFhWQ7FDZ9lWM9oqAkDwHg60Po3q9zWFe1657MOMCLIrXw+Ap/X4SAMSYsvAj8 B4VOyPXFmPvQ== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="191124119" X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="191124119" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 14:19:00 -0800 IronPort-SDR: DuRpbHrASH369t18143sslWR9gykatmNBEOre0vWxO+sDLZVRSfa6a0r1TItGyuZ/Z1NoePjte kvndkawcj8ww== X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="549761384" Received: from labuser-z97x-ud5h.jf.intel.com (HELO labuser-Z97X-UD5H) ([10.165.21.211]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 14:19:00 -0800 Date: Tue, 1 Dec 2020 14:21:56 -0800 From: "Navare, Manasi" To: Jani Nikula Message-ID: <20201201222148.GA21862@labuser-Z97X-UD5H> References: <20201022222709.29386-1-manasi.d.navare@intel.com> <20201022222709.29386-3-manasi.d.navare@intel.com> <87wnytsdgz.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wnytsdgz.fsf@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH 02/11] drm/i915/display/vrr: Create VRR file and add VRR capability check X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 10, 2020 at 12:39:08PM +0200, Jani Nikula wrote: > On Thu, 22 Oct 2020, Manasi Navare wrote: > > We create a new file for all VRR related helpers. > > Also add a function to check vrr capability based on > > platform support, DPCD bits and EDID monitor range. > > > > Cc: Ville Syrj=E4l=E4 > > Signed-off-by: Manasi Navare > > --- > > drivers/gpu/drm/i915/Makefile | 1 + > > drivers/gpu/drm/i915/display/intel_vrr.c | 28 ++++++++++++++++++++++++ > > drivers/gpu/drm/i915/display/intel_vrr.h | 19 ++++++++++++++++ > > 3 files changed, 48 insertions(+) > > create mode 100644 drivers/gpu/drm/i915/display/intel_vrr.c > > create mode 100644 drivers/gpu/drm/i915/display/intel_vrr.h > > > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makef= ile > > index e5574e506a5c..3beeaf517191 100644 > > --- a/drivers/gpu/drm/i915/Makefile > > +++ b/drivers/gpu/drm/i915/Makefile > > @@ -249,6 +249,7 @@ i915-y +=3D \ > > display/intel_sdvo.o \ > > display/intel_tv.o \ > > display/intel_vdsc.o \ > > + display/intel_vrr.o \ > > display/vlv_dsi.o \ > > display/vlv_dsi_pll.o > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm= /i915/display/intel_vrr.c > > new file mode 100644 > > index 000000000000..0c8a91fabb64 > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/display/intel_vrr.c > > @@ -0,0 +1,28 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright =A9 2020 Intel Corporation > > + * > > + * Author: Manasi Navare > = > I have increasingly mixed feelings about adding author lines in files in > big collaborative projects. They tend to go out of date fairly quickly, > and will cease to represent the contributions fairly. And git already > gives us this information. Thanks Jani, yes will remove the author name then. > = > > + */ > > + > > +#include "i915_drv.h" > > +#include "intel_display_types.h" > > +#include "intel_vrr.h" > > + > > +bool intel_is_vrr_capable(struct drm_connector *connector) > = > Please prefix with intel_vrr_ consistently. Will do, and change this to intel_vrr_is_capable() > = > > +{ > > + struct intel_dp *intel_dp =3D intel_attached_dp(to_intel_connector(co= nnector)); > = > I kind of feel like either the function should a) ensure it's okay to do > intel_attached_dp() and return false if not, or b) just use struct > intel_dp as the parameter. > = > As it is, passing a non-dp connector to this function will fail either > subtly or spectacularly, but not graciously. Yes I agree here. I think passing intel_dp is a good idea as anyway this fu= nction is currently only called from intel_dp specific functions and after brainst= orming a bit on how this will look for the VRR on native HDMI, it will likely require it= s own helpers. So infact I was thinking of even renaming this as intel_vrr_is_capable_dp()= and send intel_dp to it and then intel_vrr_is_capable_hdmi() can be added later. What do you think? > = > > + const struct drm_display_info *info =3D &connector->display_info; > > + struct drm_i915_private *dev_priv =3D to_i915(connector->dev); > = > Please use i915 over dev_priv in all new code. Okay > = > > + > > + /* > > + * DP Sink is capable of Variable refresh video timings if > > + * Ignore MSA bit is set in DPCD. > > + * EDID monitor range also should be atleast 10 for reasonable > > + * Adaptive sync/ VRR end user experience. > > + */ > = > Please fix typos etc. Did I miss some typos, I dont see any in the above comment? > = > > + return INTEL_GEN(dev_priv) >=3D 12 && > > + drm_dp_sink_can_do_video_without_timing_msa(intel_dp->dpcd) && > > + info->monitor_range.max_vfreq - info->monitor_range.min_vfreq > 10; > > +} > > + > > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h b/drivers/gpu/drm= /i915/display/intel_vrr.h > > new file mode 100644 > > index 000000000000..755746c7525c > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/display/intel_vrr.h > > @@ -0,0 +1,19 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright =A9 2019 Intel Corporation > > +*/ > > + > > +#ifndef __INTEL_VRR_H__ > > +#define __INTEL_VRR_H__ > > + > > +#include > > + > > +struct drm_connector; > = > All of the below declarations are unnecessary at this commit. Yes will add them in the next commits as I add the next functions, got it. Regards Manasi > = > BR, > Jani. > = > > +struct drm_i915_private; > > +struct intel_crtc_state; > > +struct intel_encoder; > > +struct intel_dp; > > + > > +bool intel_is_vrr_capable(struct drm_connector *connector); > > + > > +#endif /* __INTEL_VRR_H__ */ > = > -- = > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx