From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD3AC83018 for ; Wed, 2 Dec 2020 13:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFBC72222C for ; Wed, 2 Dec 2020 13:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730077AbgLBNG0 (ORCPT ); Wed, 2 Dec 2020 08:06:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26158 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727004AbgLBNGZ (ORCPT ); Wed, 2 Dec 2020 08:06:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606914297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/dqkxRSa79jAVAJX2UPt/jHcqXUQ6QQqBuabxeR0KE=; b=d8H1eQroMskyo7RYAP0JSnlwB8yrYM0Hf/mbPEWkp79SJGZJqrIL2xhnh2K5Dtq0FpyD9Y NSLsTWkW+Wennyvzcrf7MUWbQcYC2wo26G8ERaDB/VMVGqMSwh1BWcCa+QdU7Xa4rrDISg xxCfed+fSEgIxKJKBxbCG3/YoOGHzLU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-E3PM6A9tOT2TPsBaFkhI6g-1; Wed, 02 Dec 2020 08:04:55 -0500 X-MC-Unique: E3PM6A9tOT2TPsBaFkhI6g-1 Received: by mail-wr1-f70.google.com with SMTP id u8so3978237wrq.6 for ; Wed, 02 Dec 2020 05:04:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=j/dqkxRSa79jAVAJX2UPt/jHcqXUQ6QQqBuabxeR0KE=; b=Jy/mL8dtGFT4p30Vb36qy76xBEgCokK0aYOL8NG+q2u/UCYucHoa683ijQzcDoD+0l D+1n6uAnPz/IdCtAxsiU9zNgySGchklPGOyua0MQjpvyKskkFqIoCnW+nBcTfHK1VHFW rrCigP3dAnimDaujDQ1nYFNWhA36f8gR/VUILK8V5BrtldZUxZwsvBubnI748t5lLSW1 n5PYQI3U3xhKuANy3Tt6t2nxEt0HEzuUk3zKykCSIFRpJgZls2P48/WnpiY/cEZCXc6y LSlrLgF1RQAaXvXU6aiLPGrdnOFUQDGJ8MEyFrIeAtrt7e6j1fGfLkR7QPj9bmdfD4e2 x15Q== X-Gm-Message-State: AOAM531c0pQ4/EhjBVQgtu4YR55r+ATDd0cTNacbGHeuQKKfotm0qq5Y P+BhSAAd/5JGakm773hT/9QCQyCO7e4URRXG2CZsQuV7doZG3MvGXKEKpqk5Gx1GD3r2g1/ScOd l+AgQq7DT+ZyBWmITFiQRIouw X-Received: by 2002:a05:6000:104b:: with SMTP id c11mr3270799wrx.329.1606914293666; Wed, 02 Dec 2020 05:04:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiucRsoomtT2Xlw4bTZSX13X0KlLj0I1QKFjxuhkTaSEsZJ5a4A8KBg/Erj19FfU1sxC3Hhg== X-Received: by 2002:a05:6000:104b:: with SMTP id c11mr3270767wrx.329.1606914293304; Wed, 02 Dec 2020 05:04:53 -0800 (PST) Received: from redhat.com (bzq-79-176-44-197.red.bezeqint.net. [79.176.44.197]) by smtp.gmail.com with ESMTPSA id n14sm2002096wrx.79.2020.12.02.05.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 05:04:51 -0800 (PST) Date: Wed, 2 Dec 2020 08:04:48 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Cindy Lu , Eli Cohen , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance Message-ID: <20201202080149-mutt-send-email-mst@kernel.org> References: <20201130062746.GA99449@mtl-vdi-166.wap.labs.mlnx> <20201130035147-mutt-send-email-mst@kernel.org> <20201130092759.GB99449@mtl-vdi-166.wap.labs.mlnx> <20201130043050-mutt-send-email-mst@kernel.org> <20201130103142-mutt-send-email-mst@kernel.org> <20201202042328-mutt-send-email-mst@kernel.org> <128487fe-8736-6d9e-3d07-b55dcb92c9b0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <128487fe-8736-6d9e-3d07-b55dcb92c9b0@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2020 at 08:56:37PM +0800, Jason Wang wrote: > > On 2020/12/2 下午5:30, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote: > > > On 2020/12/1 下午5:23, Cindy Lu wrote: > > > > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: > > > > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > > > > > > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin wrote: > > > > > > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > > > > > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > > > > > > > > On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote: > > > > > > > > > > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote: > > > > > > > > > > > On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote: > > > > > > > > > > > > We should not try to use the VF MAC address as that is used by the > > > > > > > > > > > > regular (e.g. mlx5_core) NIC implementation. Instead, use a random > > > > > > > > > > > > generated MAC address. > > > > > > > > > > > > > > > > > > > > > > > > Suggested by: Cindy Lu > > > > > > > > > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > > > > > > > > > > > > Signed-off-by: Eli Cohen > > > > > > > > > > > I didn't realise it's possible to use VF in two ways > > > > > > > > > > > with and without vdpa. > > > > > > > > > > Using a VF you can create quite a few resources, e.g. send queues > > > > > > > > > > recieve queues, virtio_net queues etc. So you can possibly create > > > > > > > > > > several instances of vdpa net devices and nic net devices. > > > > > > > > > > > > > > > > > > > > > Could you include a bit more description on the failure > > > > > > > > > > > mode? > > > > > > > > > > Well, using the MAC address of the nic vport is wrong since that is the > > > > > > > > > > MAC of the regular NIC implementation of mlx5_core. > > > > > > > > > Right but ATM it doesn't coexist with vdpa so what's the problem? > > > > > > > > > > > > > > > > > This call is wrong: mlx5_query_nic_vport_mac_address() > > > > > > > > > > > > > > > > > > > Is switching to a random mac for such an unusual > > > > > > > > > > > configuration really justified? > > > > > > > > > > Since I can't use the NIC's MAC address, I have two options: > > > > > > > > > > 1. To get the MAC address as was chosen by the user administering the > > > > > > > > > > NIC. This should invoke the set_config callback. Unfortunately this > > > > > > > > > > is not implemented yet. > > > > > > > > > > > > > > > > > > > > 2. Use a random MAC address. This is OK since if (1) is implemented it > > > > > > > > > > can always override this random configuration. > > > > > > > > > > > > > > > > > > > > > It looks like changing a MAC could break some guests, > > > > > > > > > > > can it not? > > > > > > > > > > > > > > > > > > > > > No, it will not. The current version of mlx5 VDPA does not allow regular > > > > > > > > > > NIC driver and VDPA to co-exist. I have patches ready that enable that > > > > > > > > > > from steering point of view. I will post them here once other patches on > > > > > > > > > > which they depend will be merged. > > > > > > > > > > > > > > > > > > > > https://patchwork.ozlabs.org/project/netdev/patch/20201120230339.651609-12-saeedm@nvidia.com/ > > > > > > > > > Could you be more explicit on the following points: > > > > > > > > > - which configuration is broken ATM (as in, two device have identical > > > > > > > > > macs? any other issues)? > > > > > > > > The only wrong thing is the call to mlx5_query_nic_vport_mac_address(). > > > > > > > > It's not breaking anything yet is wrong. The random MAC address setting > > > > > > > > is required for the steering patches. > > > > > > > Okay so I'm not sure the Fixes tag at least is appropriate if it's a > > > > > > > dependency of a new feature. > > > > > > > > > > > > > > > > - why won't device MAC change from guest point of view? > > > > > > > > > > > > > > > > > It's lack of implementation in qemu as far as I know. > > > > > > > Sorry not sure I understand. What's not implemented in QEMU? > > > > > > > > > > > > > HI Michael, there are some bug in qemu to set_config, this will fix in future, > > > > > > But this patch is still needed, because without this patch the mlx > > > > > > driver will give an 0 mac address to qemu > > > > > > and qemu will overwrite the default mac address. This will cause traffic down. > > > > > Hmm the patch description says VF mac address, not 0 address. Confused. > > > > > If there's no mac we can clear VIRTIO_NET_F_MAC and have guest > > > > > use a random value ... > > > > > > I'm not sure this can work for all types of vDPA (e.g it could not be a > > > learning bridge in the swtich). > > > > > > > > > > hi Michael， > > > > I have tried as your suggestion, seems even remove the > > > > VIRTIO_NET_F_MAC the qemu will still call get_cinfig and overwrite the > > > > default address in VM, > > > > > > This looks a bug in qemu, in guest driver we had: > > > > > >     /* Configuration may specify what MAC to use.  Otherwise random. */ > > >     if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > > >         virtio_cread_bytes(vdev, > > >                    offsetof(struct virtio_net_config, mac), > > >                    dev->dev_addr, dev->addr_len); > > >     else > > >         eth_hw_addr_random(dev); > > > > > > > > > > this process is like > > > > vdpa _init -->qemu call get_config ->mlx driver will give an mac > > > > address with all 0--> > > > > qemu will not check this mac address and use it --> overwrite the mac > > > > address in qemu > > > > > > > > So for my understanding there are several method to fix this problem > > > > > > > > 1, qemu check the mac address, if the mac address is all 0, qemu will > > > > ignore it and set the random mac address to mlx driver. > > > > > > So my understanding is that, if mac address is all 0, vDPA parent should not > > > advertise VIRTIO_NET_F_MAC. And qemu should emulate this feature as you did: > > > > > > 1) get a random mac > > To me this looks like a spec violation. > > > > If the driver negotiates the VIRTIO_NET_F_MAC feature, the driver MUST set > > the physical address of the NIC to \field{mac}. Otherwise, it SHOULD > > use a locally-administered MAC address (see \hyperref[intro:IEEE 802]{IEEE 802}, > > ``9.2 48-bit universal LAN MAC addresses''). > > > One question here, what did "set" mean here consider the mac is given by the > device itself? > That is my understanding, and this seems to be what linux guests do. > > > > While not said explicitly, the assumption I think is that the local > > MAC is not a local one. > > > > > > > 2) advertise VIRTIO_NET_F_MAC > > > 3) set the random mac to vDPA through set_config > > that part looks wrong to me. Setting mac through set_config was > > a pre-virtio-1.0 way to send mac to device. In 1.0 we have > > VIRTIO_NET_CTRL_MAC_ADDR_SET for that: > > > > > > When using the legacy interface, \field{mac} is driver-writable > > which provided a way for drivers to update the MAC without > > negotiating VIRTIO_NET_F_CTRL_MAC_ADDR. > > > Looks like it doesn't prevent us from doing so. >From writing into mac? Yes it does: Device configuration fields are listed below, they are read-only for a driver. The \field{mac} address field always exists (though is only valid if VIRTIO_NET_F_MAC is set), and \field{status} only exists if VIRTIO_NET_F_STATUS is set. > Otherwise this brings an > implicit dependency for control virtqueue if we want to support 1.0? > > Thanks With 1.0 you either need VIRTIO_NET_F_CTRL_MAC_ADDR or VIRTIO_NET_F_MAC. > > > > > > > > > > 4) advertise the random mac to emulated config to guest > > > > > > > > > > 2. mlx driver checks the mac address and if this mac is 0, return fail > > > > to qemu, but this need to change the UAPI. > > > > > > uAPI is probably fine since ioctl can fail.  We can change the to allow the > > > set_config to fail but virito spec doesn't have a way to advertise the error > > > in this case. Anyway, the driver only risk itself for setting a wrong value, > > > so we're probably fine. > > > > > > Thanks > > > > > > > > > > 3. mlx driver it shelf should get an correct mac address while it init. > > > > 4. add check in qemu get_config function , if there is not F_MAC Then > > > > ignore the mac address from mlx driver > > > > > > > > not sure which method is more suitable ? > > > > > > > > Thanks > > > > Cindy > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 5 +---- > > > > > > > > > > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > > > > > > index 1fa6fcac8299..80d06d958b8b 100644 > > > > > > > > > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > > > > > > @@ -1955,10 +1955,7 @@ void *mlx5_vdpa_add_dev(struct mlx5_core_dev *mdev) > > > > > > > > > > > > if (err) > > > > > > > > > > > > goto err_mtu; > > > > > > > > > > > > > > > > > > > > > > > > - err = mlx5_query_nic_vport_mac_address(mdev, 0, 0, config->mac); > > > > > > > > > > > > - if (err) > > > > > > > > > > > > - goto err_mtu; > > > > > > > > > > > > - > > > > > > > > > > > > + eth_random_addr(config->mac); > > > > > > > > > > > > mvdev->vdev.dma_dev = mdev->device; > > > > > > > > > > > > err = mlx5_vdpa_alloc_resources(&ndev->mvdev); > > > > > > > > > > > > if (err) > > > > > > > > > > > > -- > > > > > > > > > > > > 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24959C64E7C for ; Wed, 2 Dec 2020 13:05:05 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 839412222C for ; Wed, 2 Dec 2020 13:05:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 839412222C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id AA8C08789F; Wed, 2 Dec 2020 13:05:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IpSdEjKaMtan; Wed, 2 Dec 2020 13:05:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id E909F87886; Wed, 2 Dec 2020 13:05:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C643AC0859; Wed, 2 Dec 2020 13:05:01 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0DB8DC0052 for ; Wed, 2 Dec 2020 13:05:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E6D9D87886 for ; Wed, 2 Dec 2020 13:04:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gi8OS+fcJ1LB for ; Wed, 2 Dec 2020 13:04:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by whitealder.osuosl.org (Postfix) with ESMTPS id C07C88787F for ; Wed, 2 Dec 2020 13:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606914297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/dqkxRSa79jAVAJX2UPt/jHcqXUQ6QQqBuabxeR0KE=; b=d8H1eQroMskyo7RYAP0JSnlwB8yrYM0Hf/mbPEWkp79SJGZJqrIL2xhnh2K5Dtq0FpyD9Y NSLsTWkW+Wennyvzcrf7MUWbQcYC2wo26G8ERaDB/VMVGqMSwh1BWcCa+QdU7Xa4rrDISg xxCfed+fSEgIxKJKBxbCG3/YoOGHzLU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-qfSnQcDoNc6XprOEU7mRbg-1; Wed, 02 Dec 2020 08:04:55 -0500 X-MC-Unique: qfSnQcDoNc6XprOEU7mRbg-1 Received: by mail-wr1-f72.google.com with SMTP id z6so3748088wrl.7 for ; Wed, 02 Dec 2020 05:04:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=j/dqkxRSa79jAVAJX2UPt/jHcqXUQ6QQqBuabxeR0KE=; b=J6r3+VFLNS8OtV640KsH8O2vsnZeCx4JRFLAU7Lxb7vSYIqgRw98WL3GO6FlAZVxj/ F32XRKl4x2m43n22XTiVX9K1dawWZX9f08Dh+f/gI+CES0cGOsPa5ZqnwLvbfpOzEz07 w5rGhvBBBXG9MoSH+/9Y2BfrCsyquJNElc113TteXnDoK22gqtPfAN23vMvkPkF0Stqa 3hiAd8BACMqNfIVWoM/sxfIo+QfCCAQDgY/HFKhZtW/I+GaO7stpcZjZ1V73g7fvRaxy KAJq2oxOqCCgmPgNFwJBsCfQ+7uABxyzE9+w7ejNohmLvK/A/Ax3RaHUu8racNPLVKjy 97fw== X-Gm-Message-State: AOAM533zUxULOuPN3XLJ3TRbV3j8PCwC0gyK9QmPJmcwgR6iFf0hvox4 cvSw5WvFOnPsUKB8bJaDqdl0CwpphYc4we6JmFVv0R6R4hlHOjRFt+cMk6nhL2/7rdWnKdEy1j3 TrfvzAgkL7hQJgmm+X9MiVNujboWwDGL68pEcpAv8RQ== X-Received: by 2002:a05:6000:104b:: with SMTP id c11mr3270797wrx.329.1606914293666; Wed, 02 Dec 2020 05:04:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiucRsoomtT2Xlw4bTZSX13X0KlLj0I1QKFjxuhkTaSEsZJ5a4A8KBg/Erj19FfU1sxC3Hhg== X-Received: by 2002:a05:6000:104b:: with SMTP id c11mr3270767wrx.329.1606914293304; Wed, 02 Dec 2020 05:04:53 -0800 (PST) Received: from redhat.com (bzq-79-176-44-197.red.bezeqint.net. [79.176.44.197]) by smtp.gmail.com with ESMTPSA id n14sm2002096wrx.79.2020.12.02.05.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 05:04:51 -0800 (PST) Date: Wed, 2 Dec 2020 08:04:48 -0500 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance Message-ID: <20201202080149-mutt-send-email-mst@kernel.org> References: <20201130062746.GA99449@mtl-vdi-166.wap.labs.mlnx> <20201130035147-mutt-send-email-mst@kernel.org> <20201130092759.GB99449@mtl-vdi-166.wap.labs.mlnx> <20201130043050-mutt-send-email-mst@kernel.org> <20201130103142-mutt-send-email-mst@kernel.org> <20201202042328-mutt-send-email-mst@kernel.org> <128487fe-8736-6d9e-3d07-b55dcb92c9b0@redhat.com> MIME-Version: 1.0 In-Reply-To: <128487fe-8736-6d9e-3d07-b55dcb92c9b0@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Eli Cohen , linux-kernel@vger.kernel.org, Cindy Lu , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBEZWMgMDIsIDIwMjAgYXQgMDg6NTY6MzdQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDIwLzEyLzIg5LiL5Y2INTozMCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gV2VkLCBEZWMgMDIsIDIwMjAgYXQgMTI6MTg6MzZQTSArMDgwMCwgSmFzb24gV2Fu ZyB3cm90ZToKPiA+ID4gT24gMjAyMC8xMi8xIOS4i+WNiDU6MjMsIENpbmR5IEx1IHdyb3RlOgo+ ID4gPiA+IE9uIE1vbiwgTm92IDMwLCAyMDIwIGF0IDExOjMzIFBNIE1pY2hhZWwgUy4gVHNpcmtp biA8bXN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gT24gTW9uLCBOb3YgMzAsIDIwMjAg YXQgMDY6NDE6NDVQTSArMDgwMCwgQ2luZHkgTHUgd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIE1vbiwg Tm92IDMwLCAyMDIwIGF0IDU6MzMgUE0gTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNv bT4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gT24gTW9uLCBOb3YgMzAsIDIwMjAgYXQgMTE6Mjc6NTlB TSArMDIwMCwgRWxpIENvaGVuIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gT24gTW9uLCBOb3YgMzAs IDIwMjAgYXQgMDQ6MDA6NTFBTSAtMDUwMCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ID4g PiA+ID4gPiA+ID4gPiBPbiBNb24sIE5vdiAzMCwgMjAyMCBhdCAwODoyNzo0NkFNICswMjAwLCBF bGkgQ29oZW4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiA+ID4gT24gU3VuLCBOb3YgMjksIDIwMjAg YXQgMDM6MDg6MjJQTSAtMDUwMCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gT24gU3VuLCBOb3YgMjksIDIwMjAgYXQgMDg6NDM6NTFBTSArMDIwMCwgRWxp IENvaGVuIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBXZSBzaG91bGQgbm90IHRyeSB0 byB1c2UgdGhlIFZGIE1BQyBhZGRyZXNzIGFzIHRoYXQgaXMgdXNlZCBieSB0aGUKPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gcmVndWxhciAoZS5nLiBtbHg1X2NvcmUpIE5JQyBpbXBsZW1lbnRhdGlv bi4gSW5zdGVhZCwgdXNlIGEgcmFuZG9tCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGdlbmVyYXRl ZCBNQUMgYWRkcmVzcy4KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IFN1Z2dlc3RlZCBieTogQ2luZHkgTHUgPGx1bHVAcmVkaGF0LmNvbT4KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gRml4ZXM6IDFhODZiMzc3YWEyMSAoInZkcGEvbWx4NTogQWRkIFZEUEEg ZHJpdmVyIGZvciBzdXBwb3J0ZWQgbWx4NSBkZXZpY2VzIikKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gU2lnbmVkLW9mZi1ieTogRWxpIENvaGVuIDxlbGljQG52aWRpYS5jb20+Cj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBJIGRpZG4ndCByZWFsaXNlIGl0J3MgcG9zc2libGUgdG8gdXNlIFZGIGluIHR3 byB3YXlzCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3aXRoIGFuZCB3aXRob3V0IHZkcGEuCj4gPiA+ ID4gPiA+ID4gPiA+ID4gVXNpbmcgYSBWRiB5b3UgY2FuIGNyZWF0ZSBxdWl0ZSBhIGZldyByZXNv dXJjZXMsIGUuZy4gc2VuZCBxdWV1ZXMKPiA+ID4gPiA+ID4gPiA+ID4gPiByZWNpZXZlIHF1ZXVl cywgdmlydGlvX25ldCBxdWV1ZXMgZXRjLiBTbyB5b3UgY2FuIHBvc3NpYmx5IGNyZWF0ZQo+ID4g PiA+ID4gPiA+ID4gPiA+IHNldmVyYWwgaW5zdGFuY2VzIG9mIHZkcGEgbmV0IGRldmljZXMgYW5k IG5pYyBuZXQgZGV2aWNlcy4KPiA+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4g PiA+IENvdWxkIHlvdSBpbmNsdWRlIGEgYml0IG1vcmUgZGVzY3JpcHRpb24gb24gdGhlIGZhaWx1 cmUKPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG1vZGU/Cj4gPiA+ID4gPiA+ID4gPiA+ID4gV2VsbCwg dXNpbmcgdGhlIE1BQyBhZGRyZXNzIG9mIHRoZSBuaWMgdnBvcnQgaXMgd3Jvbmcgc2luY2UgdGhh dCBpcyB0aGUKPiA+ID4gPiA+ID4gPiA+ID4gPiBNQUMgb2YgdGhlIHJlZ3VsYXIgTklDIGltcGxl bWVudGF0aW9uIG9mIG1seDVfY29yZS4KPiA+ID4gPiA+ID4gPiA+ID4gUmlnaHQgYnV0IEFUTSBp dCBkb2Vzbid0IGNvZXhpc3Qgd2l0aCB2ZHBhIHNvIHdoYXQncyB0aGUgcHJvYmxlbT8KPiA+ID4g PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBUaGlzIGNhbGwgaXMgd3Jvbmc6ICBtbHg1X3F1 ZXJ5X25pY192cG9ydF9tYWNfYWRkcmVzcygpCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g PiA+ID4gPiA+IElzIHN3aXRjaGluZyB0byBhIHJhbmRvbSBtYWMgZm9yIHN1Y2ggYW4gdW51c3Vh bAo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY29uZmlndXJhdGlvbiByZWFsbHkganVzdGlmaWVkPwo+ ID4gPiA+ID4gPiA+ID4gPiA+IFNpbmNlIEkgY2FuJ3QgdXNlIHRoZSBOSUMncyBNQUMgYWRkcmVz cywgSSBoYXZlIHR3byBvcHRpb25zOgo+ID4gPiA+ID4gPiA+ID4gPiA+IDEuIFRvIGdldCB0aGUg TUFDIGFkZHJlc3MgYXMgd2FzIGNob3NlbiBieSB0aGUgdXNlciBhZG1pbmlzdGVyaW5nIHRoZQo+ ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgTklDLiBUaGlzIHNob3VsZCBpbnZva2UgdGhlIHNldF9j b25maWcgY2FsbGJhY2suIFVuZm9ydHVuYXRlbHkgdGhpcwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAg ICAgaXMgbm90IGltcGxlbWVudGVkIHlldC4KPiA+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gPiA+ID4gPiAyLiBVc2UgYSByYW5kb20gTUFDIGFkZHJlc3MuIFRoaXMgaXMgT0sgc2luY2Ug aWYgKDEpIGlzIGltcGxlbWVudGVkIGl0Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICBjYW4gYWx3 YXlzIG92ZXJyaWRlIHRoaXMgcmFuZG9tIGNvbmZpZ3VyYXRpb24uCj4gPiA+ID4gPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJdCBsb29rcyBsaWtlIGNoYW5naW5nIGEgTUFDIGNv dWxkIGJyZWFrIHNvbWUgZ3Vlc3RzLAo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY2FuIGl0IG5vdD8K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gPiA+IE5vLCBpdCB3aWxsIG5v dC4gVGhlIGN1cnJlbnQgdmVyc2lvbiBvZiBtbHg1IFZEUEEgZG9lcyBub3QgYWxsb3cgcmVndWxh cgo+ID4gPiA+ID4gPiA+ID4gPiA+IE5JQyBkcml2ZXIgYW5kIFZEUEEgdG8gY28tZXhpc3QuIEkg aGF2ZSBwYXRjaGVzIHJlYWR5IHRoYXQgZW5hYmxlIHRoYXQKPiA+ID4gPiA+ID4gPiA+ID4gPiBm cm9tIHN0ZWVyaW5nIHBvaW50IG9mIHZpZXcuIEkgd2lsbCBwb3N0IHRoZW0gaGVyZSBvbmNlIG90 aGVyIHBhdGNoZXMgb24KPiA+ID4gPiA+ID4gPiA+ID4gPiB3aGljaCB0aGV5IGRlcGVuZCB3aWxs IGJlIG1lcmdlZC4KPiA+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRw czovL3BhdGNod29yay5vemxhYnMub3JnL3Byb2plY3QvbmV0ZGV2L3BhdGNoLzIwMjAxMTIwMjMw MzM5LjY1MTYwOS0xMi1zYWVlZG1AbnZpZGlhLmNvbS8KPiA+ID4gPiA+ID4gPiA+ID4gQ291bGQg eW91IGJlIG1vcmUgZXhwbGljaXQgb24gdGhlIGZvbGxvd2luZyBwb2ludHM6Cj4gPiA+ID4gPiA+ ID4gPiA+IC0gd2hpY2ggY29uZmlndXJhdGlvbiBpcyBicm9rZW4gQVRNIChhcyBpbiwgdHdvIGRl dmljZSBoYXZlIGlkZW50aWNhbAo+ID4gPiA+ID4gPiA+ID4gPiAgICAgbWFjcz8gYW55IG90aGVy IGlzc3Vlcyk/Cj4gPiA+ID4gPiA+ID4gPiBUaGUgb25seSB3cm9uZyB0aGluZyBpcyB0aGUgY2Fs bCB0byAgbWx4NV9xdWVyeV9uaWNfdnBvcnRfbWFjX2FkZHJlc3MoKS4KPiA+ID4gPiA+ID4gPiA+ IEl0J3Mgbm90IGJyZWFraW5nIGFueXRoaW5nIHlldCBpcyB3cm9uZy4gVGhlIHJhbmRvbSBNQUMg YWRkcmVzcyBzZXR0aW5nCj4gPiA+ID4gPiA+ID4gPiBpcyByZXF1aXJlZCBmb3IgdGhlIHN0ZWVy aW5nIHBhdGNoZXMuCj4gPiA+ID4gPiA+ID4gT2theSBzbyBJJ20gbm90IHN1cmUgdGhlIEZpeGVz IHRhZyBhdCBsZWFzdCBpcyBhcHByb3ByaWF0ZSBpZiBpdCdzIGEKPiA+ID4gPiA+ID4gPiBkZXBl bmRlbmN5IG9mIGEgbmV3IGZlYXR1cmUuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+ IC0gd2h5IHdvbid0IGRldmljZSBNQUMgY2hhbmdlIGZyb20gZ3Vlc3QgcG9pbnQgb2Ygdmlldz8K PiA+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBJdCdzIGxhY2sgb2YgaW1wbGVtZW50 YXRpb24gaW4gcWVtdSBhcyBmYXIgYXMgSSBrbm93Lgo+ID4gPiA+ID4gPiA+IFNvcnJ5IG5vdCBz dXJlIEkgdW5kZXJzdGFuZC4gV2hhdCdzIG5vdCBpbXBsZW1lbnRlZCBpbiBRRU1VPwo+ID4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiBISSBNaWNoYWVsLCB0aGVyZSBhcmUgc29tZSBidWcgaW4gcWVt dSB0byBzZXRfY29uZmlnLCB0aGlzIHdpbGwgZml4IGluIGZ1dHVyZSwKPiA+ID4gPiA+ID4gQnV0 IHRoaXMgcGF0Y2ggaXMgc3RpbGwgbmVlZGVkLCBiZWNhdXNlIHdpdGhvdXQgdGhpcyBwYXRjaCB0 aGUgbWx4Cj4gPiA+ID4gPiA+IGRyaXZlciB3aWxsIGdpdmUgYW4gMCBtYWMgYWRkcmVzcyB0byBx ZW11Cj4gPiA+ID4gPiA+IGFuZCBxZW11IHdpbGwgb3ZlcndyaXRlIHRoZSBkZWZhdWx0IG1hYyBh ZGRyZXNzLiAgVGhpcyB3aWxsIGNhdXNlIHRyYWZmaWMgZG93bi4KPiA+ID4gPiA+IEhtbSB0aGUg cGF0Y2ggZGVzY3JpcHRpb24gc2F5cyBWRiBtYWMgYWRkcmVzcywgbm90IDAgYWRkcmVzcy4gQ29u ZnVzZWQuCj4gPiA+ID4gPiBJZiB0aGVyZSdzIG5vIG1hYyB3ZSBjYW4gY2xlYXIgVklSVElPX05F VF9GX01BQyBhbmQgaGF2ZSBndWVzdAo+ID4gPiA+ID4gdXNlIGEgcmFuZG9tIHZhbHVlIC4uLgo+ ID4gPiAKPiA+ID4gSSdtIG5vdCBzdXJlIHRoaXMgY2FuIHdvcmsgZm9yIGFsbCB0eXBlcyBvZiB2 RFBBIChlLmcgaXQgY291bGQgbm90IGJlIGEKPiA+ID4gbGVhcm5pbmcgYnJpZGdlIGluIHRoZSBz d3RpY2gpLgo+ID4gPiAKPiA+ID4gCj4gPiA+ID4gaGkgTWljaGFlbO+8jAo+ID4gPiA+IEkgaGF2 ZSB0cmllZCBhcyB5b3VyIHN1Z2dlc3Rpb24sIHNlZW1zIGV2ZW4gcmVtb3ZlIHRoZQo+ID4gPiA+ IFZJUlRJT19ORVRfRl9NQUMgdGhlIHFlbXUgd2lsbCBzdGlsbCBjYWxsIGdldF9jaW5maWcgYW5k IG92ZXJ3cml0ZSB0aGUKPiA+ID4gPiBkZWZhdWx0IGFkZHJlc3MgaW4gIFZNLAo+ID4gPiAKPiA+ ID4gVGhpcyBsb29rcyBhIGJ1ZyBpbiBxZW11LCBpbiBndWVzdCBkcml2ZXIgd2UgaGFkOgo+ID4g PiAKPiA+ID4gIMKgwqDCoCAvKiBDb25maWd1cmF0aW9uIG1heSBzcGVjaWZ5IHdoYXQgTUFDIHRv IHVzZS7CoCBPdGhlcndpc2UgcmFuZG9tLiAqLwo+ID4gPiAgwqDCoMKgIGlmICh2aXJ0aW9faGFz X2ZlYXR1cmUodmRldiwgVklSVElPX05FVF9GX01BQykpCj4gPiA+ICDCoMKgwqAgwqDCoMKgIHZp cnRpb19jcmVhZF9ieXRlcyh2ZGV2LAo+ID4gPiAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqDCoMKg IMKgwqAgb2Zmc2V0b2Yoc3RydWN0IHZpcnRpb19uZXRfY29uZmlnLCBtYWMpLAo+ID4gPiAgwqDC oMKgIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgwqAgZGV2LT5kZXZfYWRkciwgZGV2LT5hZGRyX2xl bik7Cj4gPiA+ICDCoMKgwqAgZWxzZQo+ID4gPiAgwqDCoMKgIMKgwqDCoCBldGhfaHdfYWRkcl9y YW5kb20oZGV2KTsKPiA+ID4gCj4gPiA+IAo+ID4gPiA+IHRoaXMgcHJvY2VzcyBpcyBsaWtlCj4g PiA+ID4gdmRwYSBfaW5pdCAtLT5xZW11IGNhbGwgZ2V0X2NvbmZpZyAtPm1seCBkcml2ZXIgd2ls bCBnaXZlICBhbiBtYWMKPiA+ID4gPiBhZGRyZXNzIHdpdGggYWxsIDAtLT4KPiA+ID4gPiBxZW11 IHdpbGwgbm90IGNoZWNrIHRoaXMgbWFjIGFkZHJlc3MgYW5kIHVzZSBpdCAtLT4gb3ZlcndyaXRl IHRoZSBtYWMKPiA+ID4gPiBhZGRyZXNzIGluIHFlbXUKPiA+ID4gPiAKPiA+ID4gPiBTbyBmb3Ig bXkgdW5kZXJzdGFuZGluZyB0aGVyZSBhcmUgc2V2ZXJhbCBtZXRob2QgdG8gZml4IHRoaXMgcHJv YmxlbQo+ID4gPiA+IAo+ID4gPiA+IDEsIHFlbXUgY2hlY2sgdGhlIG1hYyBhZGRyZXNzLCBpZiB0 aGUgbWFjIGFkZHJlc3MgaXMgYWxsIDAsIHFlbXUgd2lsbAo+ID4gPiA+IGlnbm9yZSBpdCBhbmQg c2V0IHRoZSByYW5kb20gbWFjIGFkZHJlc3MgdG8gbWx4IGRyaXZlci4KPiA+ID4gCj4gPiA+IFNv IG15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCwgaWYgbWFjIGFkZHJlc3MgaXMgYWxsIDAsIHZEUEEg cGFyZW50IHNob3VsZCBub3QKPiA+ID4gYWR2ZXJ0aXNlIFZJUlRJT19ORVRfRl9NQUMuIEFuZCBx ZW11IHNob3VsZCBlbXVsYXRlIHRoaXMgZmVhdHVyZSBhcyB5b3UgZGlkOgo+ID4gPiAKPiA+ID4g MSkgZ2V0IGEgcmFuZG9tIG1hYwo+ID4gVG8gbWUgdGhpcyBsb29rcyBsaWtlIGEgc3BlYyB2aW9s YXRpb24uCj4gPiAKPiA+IElmIHRoZSBkcml2ZXIgbmVnb3RpYXRlcyB0aGUgVklSVElPX05FVF9G X01BQyBmZWF0dXJlLCB0aGUgZHJpdmVyIE1VU1Qgc2V0Cj4gPiB0aGUgcGh5c2ljYWwgYWRkcmVz cyBvZiB0aGUgTklDIHRvIFxmaWVsZHttYWN9LiAgT3RoZXJ3aXNlLCBpdCBTSE9VTEQKPiA+IHVz ZSBhIGxvY2FsbHktYWRtaW5pc3RlcmVkIE1BQyBhZGRyZXNzIChzZWUgXGh5cGVycmVmW2ludHJv OklFRUUgODAyXXtJRUVFIDgwMn0sCj4gPiBgYDkuMiA0OC1iaXQgdW5pdmVyc2FsIExBTiBNQUMg YWRkcmVzc2VzJycpLgo+IAo+IAo+IE9uZSBxdWVzdGlvbiBoZXJlLCB3aGF0IGRpZCAic2V0IiBt ZWFuIGhlcmUgY29uc2lkZXIgdGhlIG1hYyBpcyBnaXZlbiBieSB0aGUKPiBkZXZpY2UgaXRzZWxm Pwo+IAoKClRoYXQgaXMgbXkgdW5kZXJzdGFuZGluZywgYW5kIHRoaXMgc2VlbXMgdG8gYmUgd2hh dCBsaW51eCBndWVzdHMgZG8uCgo+ID4gCj4gPiBXaGlsZSBub3Qgc2FpZCBleHBsaWNpdGx5LCB0 aGUgYXNzdW1wdGlvbiBJIHRoaW5rIGlzIHRoYXQgdGhlIGxvY2FsCj4gPiBNQUMgaXMgbm90IGEg bG9jYWwgb25lLgo+ID4gCj4gPiAKPiA+ID4gMikgYWR2ZXJ0aXNlIFZJUlRJT19ORVRfRl9NQUMK PiA+ID4gMykgc2V0IHRoZSByYW5kb20gbWFjIHRvIHZEUEEgdGhyb3VnaCBzZXRfY29uZmlnCj4g PiB0aGF0IHBhcnQgbG9va3Mgd3JvbmcgdG8gbWUuIFNldHRpbmcgbWFjIHRocm91Z2ggc2V0X2Nv bmZpZyB3YXMKPiA+IGEgcHJlLXZpcnRpby0xLjAgd2F5IHRvIHNlbmQgbWFjIHRvIGRldmljZS4g SW4gMS4wIHdlIGhhdmUKPiA+IFZJUlRJT19ORVRfQ1RSTF9NQUNfQUREUl9TRVQgZm9yIHRoYXQ6 Cj4gPiAKPiA+IAo+ID4gCVdoZW4gdXNpbmcgdGhlIGxlZ2FjeSBpbnRlcmZhY2UsIFxmaWVsZHtt YWN9IGlzIGRyaXZlci13cml0YWJsZQo+ID4gCXdoaWNoIHByb3ZpZGVkIGEgd2F5IGZvciBkcml2 ZXJzIHRvIHVwZGF0ZSB0aGUgTUFDIHdpdGhvdXQKPiA+IAluZWdvdGlhdGluZyBWSVJUSU9fTkVU X0ZfQ1RSTF9NQUNfQUREUi4KPiAKPiAKPiBMb29rcyBsaWtlIGl0IGRvZXNuJ3QgcHJldmVudCB1 cyBmcm9tIGRvaW5nIHNvLgoKRnJvbSB3cml0aW5nIGludG8gbWFjPwpZZXMgaXQgZG9lczoKCURl dmljZSBjb25maWd1cmF0aW9uIGZpZWxkcyBhcmUgbGlzdGVkIGJlbG93LCB0aGV5IGFyZSByZWFk LW9ubHkgZm9yIGEgZHJpdmVyLiBUaGUgXGZpZWxke21hY30gYWRkcmVzcyBmaWVsZAoJYWx3YXlz IGV4aXN0cyAodGhvdWdoIGlzIG9ubHkgdmFsaWQgaWYgVklSVElPX05FVF9GX01BQyBpcyBzZXQp LCBhbmQKCVxmaWVsZHtzdGF0dXN9IG9ubHkgZXhpc3RzIGlmIFZJUlRJT19ORVRfRl9TVEFUVVMg aXMgc2V0LgoKCj4gT3RoZXJ3aXNlIHRoaXMgYnJpbmdzIGFuCj4gaW1wbGljaXQgZGVwZW5kZW5j eSBmb3IgY29udHJvbCB2aXJ0cXVldWUgaWYgd2Ugd2FudCB0byBzdXBwb3J0IDEuMD8KPiAKPiBU aGFua3MKCldpdGggMS4wIHlvdSBlaXRoZXIgbmVlZCBWSVJUSU9fTkVUX0ZfQ1RSTF9NQUNfQURE UiBvciBWSVJUSU9fTkVUX0ZfTUFDLgoKCj4gCj4gPiAKPiA+IAo+ID4gCj4gPiA+IDQpIGFkdmVy dGlzZSB0aGUgcmFuZG9tIG1hYyB0byBlbXVsYXRlZCBjb25maWcgdG8gZ3Vlc3QKPiA+ID4gCj4g PiA+IAo+ID4gPiA+IDIuIG1seCBkcml2ZXIgY2hlY2tzIHRoZSBtYWMgYWRkcmVzcyBhbmQgaWYg dGhpcyBtYWMgaXMgMCwgcmV0dXJuIGZhaWwKPiA+ID4gPiB0byBxZW11LCBidXQgdGhpcyBuZWVk IHRvIGNoYW5nZSB0aGUgVUFQSS4KPiA+ID4gCj4gPiA+IHVBUEkgaXMgcHJvYmFibHkgZmluZSBz aW5jZSBpb2N0bCBjYW4gZmFpbC7CoCBXZSBjYW4gY2hhbmdlIHRoZSB0byBhbGxvdyB0aGUKPiA+ ID4gc2V0X2NvbmZpZyB0byBmYWlsIGJ1dCB2aXJpdG8gc3BlYyBkb2Vzbid0IGhhdmUgYSB3YXkg dG8gYWR2ZXJ0aXNlIHRoZSBlcnJvcgo+ID4gPiBpbiB0aGlzIGNhc2UuIEFueXdheSwgdGhlIGRy aXZlciBvbmx5IHJpc2sgaXRzZWxmIGZvciBzZXR0aW5nIGEgd3JvbmcgdmFsdWUsCj4gPiA+IHNv IHdlJ3JlIHByb2JhYmx5IGZpbmUuCj4gPiA+IAo+ID4gPiBUaGFua3MKPiA+ID4gCj4gPiA+IAo+ ID4gPiA+IDMuIG1seCBkcml2ZXIgaXQgc2hlbGYgc2hvdWxkIGdldCBhbiBjb3JyZWN0IG1hYyBh ZGRyZXNzIHdoaWxlIGl0IGluaXQuCj4gPiA+ID4gNC4gYWRkIGNoZWNrIGluIHFlbXUgZ2V0X2Nv bmZpZyBmdW5jdGlvbiAgLCBpZiB0aGVyZSBpcyBub3QgRl9NQUMgVGhlbgo+ID4gPiA+IGlnbm9y ZSB0aGUgbWFjIGFkZHJlc3MgZnJvbSBtbHggZHJpdmVyCj4gPiA+ID4gCj4gPiA+ID4gbm90IHN1 cmUgd2hpY2ggbWV0aG9kIGlzIG1vcmUgc3VpdGFibGUgPwo+ID4gPiA+IAo+ID4gPiA+IFRoYW5r cwo+ID4gPiA+IENpbmR5Cj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICBkcml2ZXJzL3ZkcGEvbWx4 NS9uZXQvbWx4NV92bmV0LmMgfCA1ICstLS0tCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNCBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3ZkcGEvbWx4NS9uZXQvbWx4NV92bmV0LmMgYi9kcml2ZXJzL3ZkcGEvbWx4NS9uZXQvbWx4NV92 bmV0LmMKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW5kZXggMWZhNmZjYWM4Mjk5Li44MGQwNmQ5 NThiOGIgMTAwNjQ0Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmRwYS9t bHg1L25ldC9tbHg1X3ZuZXQuYwo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJz L3ZkcGEvbWx4NS9uZXQvbWx4NV92bmV0LmMKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTE5 NTUsMTAgKzE5NTUsNyBAQCB2b2lkICptbHg1X3ZkcGFfYWRkX2RldihzdHJ1Y3QgbWx4NV9jb3Jl X2RldiAqbWRldikKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBpZiAoZXJyKQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgZ290byBlcnJfbXR1Owo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gLSAgICAgZXJyID0gbWx4 NV9xdWVyeV9uaWNfdnBvcnRfbWFjX2FkZHJlc3MobWRldiwgMCwgMCwgY29uZmlnLT5tYWMpOwo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAtICAgICBpZiAoZXJyKQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiAtICAgICAgICAgICAgIGdvdG8gZXJyX210dTsKPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g LQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICBldGhfcmFuZG9tX2FkZHIoY29uZmlnLT5t YWMpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIG12ZGV2LT52ZGV2LmRtYV9kZXYg PSBtZGV2LT5kZXZpY2U7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgZXJyID0gbWx4 NV92ZHBhX2FsbG9jX3Jlc291cmNlcygmbmRldi0+bXZkZXYpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiAgICAgICAgIGlmIChlcnIpCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IC0tCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IDIuMjYuMgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9u QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9u Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u