All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: devicetree@vger.kernel.org, michal.simek@xilinx.com
Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	kernel@pengutronix.de, Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
Date: Wed,  2 Dec 2020 10:05:22 +0100	[thread overview]
Message-ID: <20201202090522.251607-1-m.tretter@pengutronix.de> (raw)

When running make dt_binding_check, the xlnx,vcu-settings binding
triggers the following two warnings:

	'additionalProperties' is a required property

	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long

Fix the binding and make the checker happy.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---

Hi,

The xlnx,vcu-settings binding was reviewed [0] before the bot started to
run automated tests on the device tree bindings, but now produces some
warnings. The original patch that introduces the binding is still in
Michal's tree and I am not entirely sure how to handle it, but here is a
patch.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
---
 .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
index 378d0ced43c8..cb245f400287 100644
--- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
+++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
@@ -26,9 +26,18 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
-    xlnx_vcu: vcu@a0041000 {
-          compatible = "xlnx,vcu-settings", "syscon";
-          reg = <0x0 0xa0041000 0x0 0x1000>;
+    fpga {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        xlnx_vcu: vcu@a0041000 {
+            compatible = "xlnx,vcu-settings", "syscon";
+            reg = <0x0 0xa0041000 0x0 0x1000>;
+        };
     };
+
+...
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tretter <m.tretter@pengutronix.de>
To: devicetree@vger.kernel.org, michal.simek@xilinx.com
Cc: robh+dt@kernel.org, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings
Date: Wed,  2 Dec 2020 10:05:22 +0100	[thread overview]
Message-ID: <20201202090522.251607-1-m.tretter@pengutronix.de> (raw)

When running make dt_binding_check, the xlnx,vcu-settings binding
triggers the following two warnings:

	'additionalProperties' is a required property

	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long

Fix the binding and make the checker happy.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---

Hi,

The xlnx,vcu-settings binding was reviewed [0] before the bot started to
run automated tests on the device tree bindings, but now produces some
warnings. The original patch that introduces the binding is still in
Michal's tree and I am not entirely sure how to handle it, but here is a
patch.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
---
 .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
index 378d0ced43c8..cb245f400287 100644
--- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
+++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
@@ -26,9 +26,18 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
-    xlnx_vcu: vcu@a0041000 {
-          compatible = "xlnx,vcu-settings", "syscon";
-          reg = <0x0 0xa0041000 0x0 0x1000>;
+    fpga {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        xlnx_vcu: vcu@a0041000 {
+            compatible = "xlnx,vcu-settings", "syscon";
+            reg = <0x0 0xa0041000 0x0 0x1000>;
+        };
     };
+
+...
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-12-02  9:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  9:05 Michael Tretter [this message]
2020-12-02  9:05 ` [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings Michael Tretter
2020-12-03  7:49 ` [PATCH] dt-bindings: xlnx,vcu-settings: " Michal Simek
2020-12-03  7:49   ` Michal Simek
2020-12-03  8:48   ` Michael Tretter
2020-12-03  8:48     ` Michael Tretter
2020-12-09 18:34     ` Rob Herring
2020-12-09 18:34       ` Rob Herring
2020-12-09 18:58       ` Michal Simek
2020-12-09 18:58         ` Michal Simek
2020-12-18 18:35         ` Rob Herring
2020-12-18 18:35           ` [PATCH] dt-bindings: xlnx, vcu-settings: " Rob Herring
2020-12-18 21:17 ` Rob Herring
2020-12-18 21:17   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202090522.251607-1-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.