All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
@ 2020-12-02  9:05 ` Michael Tretter
  0 siblings, 0 replies; 14+ messages in thread
From: Michael Tretter @ 2020-12-02  9:05 UTC (permalink / raw)
  To: devicetree, michal.simek
  Cc: robh+dt, linux-arm-kernel, kernel, Michael Tretter

When running make dt_binding_check, the xlnx,vcu-settings binding
triggers the following two warnings:

	'additionalProperties' is a required property

	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long

Fix the binding and make the checker happy.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---

Hi,

The xlnx,vcu-settings binding was reviewed [0] before the bot started to
run automated tests on the device tree bindings, but now produces some
warnings. The original patch that introduces the binding is still in
Michal's tree and I am not entirely sure how to handle it, but here is a
patch.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
---
 .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
index 378d0ced43c8..cb245f400287 100644
--- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
+++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
@@ -26,9 +26,18 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
-    xlnx_vcu: vcu@a0041000 {
-          compatible = "xlnx,vcu-settings", "syscon";
-          reg = <0x0 0xa0041000 0x0 0x1000>;
+    fpga {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        xlnx_vcu: vcu@a0041000 {
+            compatible = "xlnx,vcu-settings", "syscon";
+            reg = <0x0 0xa0041000 0x0 0x1000>;
+        };
     };
+
+...
-- 
2.20.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings
@ 2020-12-02  9:05 ` Michael Tretter
  0 siblings, 0 replies; 14+ messages in thread
From: Michael Tretter @ 2020-12-02  9:05 UTC (permalink / raw)
  To: devicetree, michal.simek
  Cc: robh+dt, kernel, linux-arm-kernel, Michael Tretter

When running make dt_binding_check, the xlnx,vcu-settings binding
triggers the following two warnings:

	'additionalProperties' is a required property

	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long

Fix the binding and make the checker happy.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---

Hi,

The xlnx,vcu-settings binding was reviewed [0] before the bot started to
run automated tests on the device tree bindings, but now produces some
warnings. The original patch that introduces the binding is still in
Michal's tree and I am not entirely sure how to handle it, but here is a
patch.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
---
 .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
index 378d0ced43c8..cb245f400287 100644
--- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
+++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
@@ -26,9 +26,18 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
-    xlnx_vcu: vcu@a0041000 {
-          compatible = "xlnx,vcu-settings", "syscon";
-          reg = <0x0 0xa0041000 0x0 0x1000>;
+    fpga {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        xlnx_vcu: vcu@a0041000 {
+            compatible = "xlnx,vcu-settings", "syscon";
+            reg = <0x0 0xa0041000 0x0 0x1000>;
+        };
     };
+
+...
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
  2020-12-02  9:05 ` [PATCH] dt-bindings: xlnx, vcu-settings: " Michael Tretter
@ 2020-12-03  7:49   ` Michal Simek
  -1 siblings, 0 replies; 14+ messages in thread
From: Michal Simek @ 2020-12-03  7:49 UTC (permalink / raw)
  To: Michael Tretter, devicetree, michal.simek
  Cc: robh+dt, linux-arm-kernel, kernel



On 02. 12. 20 10:05, Michael Tretter wrote:
> When running make dt_binding_check, the xlnx,vcu-settings binding
> triggers the following two warnings:
> 
> 	'additionalProperties' is a required property
> 
> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> 
> Fix the binding and make the checker happy.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> 
> Hi,
> 
> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> run automated tests on the device tree bindings, but now produces some
> warnings. The original patch that introduces the binding is still in
> Michal's tree and I am not entirely sure how to handle it, but here is a
> patch.
> 
> Michael
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> ---
>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> index 378d0ced43c8..cb245f400287 100644
> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> @@ -26,9 +26,18 @@ required:
>    - compatible
>    - reg
>  
> +additionalProperties: false
> +
>  examples:
>    - |
> -    xlnx_vcu: vcu@a0041000 {
> -          compatible = "xlnx,vcu-settings", "syscon";
> -          reg = <0x0 0xa0041000 0x0 0x1000>;
> +    fpga {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        xlnx_vcu: vcu@a0041000 {
> +            compatible = "xlnx,vcu-settings", "syscon";
> +            reg = <0x0 0xa0041000 0x0 0x1000>;
> +        };

IIRC we had been discussing this recently and Rob wanted to have just
1/1 mapping here.

Take a look at 0db958b689ca9.

Thanks,
Michal


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
@ 2020-12-03  7:49   ` Michal Simek
  0 siblings, 0 replies; 14+ messages in thread
From: Michal Simek @ 2020-12-03  7:49 UTC (permalink / raw)
  To: Michael Tretter, devicetree, michal.simek
  Cc: robh+dt, kernel, linux-arm-kernel



On 02. 12. 20 10:05, Michael Tretter wrote:
> When running make dt_binding_check, the xlnx,vcu-settings binding
> triggers the following two warnings:
> 
> 	'additionalProperties' is a required property
> 
> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> 
> Fix the binding and make the checker happy.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> 
> Hi,
> 
> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> run automated tests on the device tree bindings, but now produces some
> warnings. The original patch that introduces the binding is still in
> Michal's tree and I am not entirely sure how to handle it, but here is a
> patch.
> 
> Michael
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> ---
>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> index 378d0ced43c8..cb245f400287 100644
> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> @@ -26,9 +26,18 @@ required:
>    - compatible
>    - reg
>  
> +additionalProperties: false
> +
>  examples:
>    - |
> -    xlnx_vcu: vcu@a0041000 {
> -          compatible = "xlnx,vcu-settings", "syscon";
> -          reg = <0x0 0xa0041000 0x0 0x1000>;
> +    fpga {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        xlnx_vcu: vcu@a0041000 {
> +            compatible = "xlnx,vcu-settings", "syscon";
> +            reg = <0x0 0xa0041000 0x0 0x1000>;
> +        };

IIRC we had been discussing this recently and Rob wanted to have just
1/1 mapping here.

Take a look at 0db958b689ca9.

Thanks,
Michal


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
  2020-12-03  7:49   ` Michal Simek
@ 2020-12-03  8:48     ` Michael Tretter
  -1 siblings, 0 replies; 14+ messages in thread
From: Michael Tretter @ 2020-12-03  8:48 UTC (permalink / raw)
  To: Michal Simek, robh+dt; +Cc: devicetree, linux-arm-kernel, kernel

On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> On 02. 12. 20 10:05, Michael Tretter wrote:
> > When running make dt_binding_check, the xlnx,vcu-settings binding
> > triggers the following two warnings:
> > 
> > 	'additionalProperties' is a required property
> > 
> > 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> > 
> > Fix the binding and make the checker happy.
> > 
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > 
> > Hi,
> > 
> > The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> > run automated tests on the device tree bindings, but now produces some
> > warnings. The original patch that introduces the binding is still in
> > Michal's tree and I am not entirely sure how to handle it, but here is a
> > patch.
> > 
> > Michael
> > 
> > [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> > ---
> >  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> >  1 file changed, 12 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > index 378d0ced43c8..cb245f400287 100644
> > --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > @@ -26,9 +26,18 @@ required:
> >    - compatible
> >    - reg
> >  
> > +additionalProperties: false
> > +
> >  examples:
> >    - |
> > -    xlnx_vcu: vcu@a0041000 {
> > -          compatible = "xlnx,vcu-settings", "syscon";
> > -          reg = <0x0 0xa0041000 0x0 0x1000>;
> > +    fpga {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        xlnx_vcu: vcu@a0041000 {
> > +            compatible = "xlnx,vcu-settings", "syscon";
> > +            reg = <0x0 0xa0041000 0x0 0x1000>;
> > +        };
> 
> IIRC we had been discussing this recently and Rob wanted to have just
> 1/1 mapping here.
> 
> Take a look at 0db958b689ca9.

Thanks for the pointer.

Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
bus with more cells? I still see several examples that add a bus with 2 cells.
I assume that they more or less legacy, but I didn't find any discussion going
beyond the commit description of 0db958b689ca9, which "just" fixes the
warnings.

I will send a v2, but I'd like to understand the rationale for having the 1/1
mapping first.

Michael

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
@ 2020-12-03  8:48     ` Michael Tretter
  0 siblings, 0 replies; 14+ messages in thread
From: Michael Tretter @ 2020-12-03  8:48 UTC (permalink / raw)
  To: Michal Simek, robh+dt; +Cc: devicetree, kernel, linux-arm-kernel

On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> On 02. 12. 20 10:05, Michael Tretter wrote:
> > When running make dt_binding_check, the xlnx,vcu-settings binding
> > triggers the following two warnings:
> > 
> > 	'additionalProperties' is a required property
> > 
> > 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> > 
> > Fix the binding and make the checker happy.
> > 
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > 
> > Hi,
> > 
> > The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> > run automated tests on the device tree bindings, but now produces some
> > warnings. The original patch that introduces the binding is still in
> > Michal's tree and I am not entirely sure how to handle it, but here is a
> > patch.
> > 
> > Michael
> > 
> > [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> > ---
> >  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> >  1 file changed, 12 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > index 378d0ced43c8..cb245f400287 100644
> > --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > @@ -26,9 +26,18 @@ required:
> >    - compatible
> >    - reg
> >  
> > +additionalProperties: false
> > +
> >  examples:
> >    - |
> > -    xlnx_vcu: vcu@a0041000 {
> > -          compatible = "xlnx,vcu-settings", "syscon";
> > -          reg = <0x0 0xa0041000 0x0 0x1000>;
> > +    fpga {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        xlnx_vcu: vcu@a0041000 {
> > +            compatible = "xlnx,vcu-settings", "syscon";
> > +            reg = <0x0 0xa0041000 0x0 0x1000>;
> > +        };
> 
> IIRC we had been discussing this recently and Rob wanted to have just
> 1/1 mapping here.
> 
> Take a look at 0db958b689ca9.

Thanks for the pointer.

Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
bus with more cells? I still see several examples that add a bus with 2 cells.
I assume that they more or less legacy, but I didn't find any discussion going
beyond the commit description of 0db958b689ca9, which "just" fixes the
warnings.

I will send a v2, but I'd like to understand the rationale for having the 1/1
mapping first.

Michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
  2020-12-03  8:48     ` Michael Tretter
@ 2020-12-09 18:34       ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-09 18:34 UTC (permalink / raw)
  To: Michael Tretter; +Cc: Michal Simek, devicetree, linux-arm-kernel, kernel

On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> > On 02. 12. 20 10:05, Michael Tretter wrote:
> > > When running make dt_binding_check, the xlnx,vcu-settings binding
> > > triggers the following two warnings:
> > > 
> > > 	'additionalProperties' is a required property
> > > 
> > > 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> > > 
> > > Fix the binding and make the checker happy.
> > > 
> > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > > ---
> > > 
> > > Hi,
> > > 
> > > The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> > > run automated tests on the device tree bindings, but now produces some
> > > warnings. The original patch that introduces the binding is still in
> > > Michal's tree and I am not entirely sure how to handle it, but here is a
> > > patch.
> > > 
> > > Michael
> > > 
> > > [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> > > ---
> > >  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> > >  1 file changed, 12 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > index 378d0ced43c8..cb245f400287 100644
> > > --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > @@ -26,9 +26,18 @@ required:
> > >    - compatible
> > >    - reg
> > >  
> > > +additionalProperties: false
> > > +
> > >  examples:
> > >    - |
> > > -    xlnx_vcu: vcu@a0041000 {
> > > -          compatible = "xlnx,vcu-settings", "syscon";
> > > -          reg = <0x0 0xa0041000 0x0 0x1000>;
> > > +    fpga {
> > > +        #address-cells = <2>;
> > > +        #size-cells = <2>;
> > > +
> > > +        xlnx_vcu: vcu@a0041000 {
> > > +            compatible = "xlnx,vcu-settings", "syscon";
> > > +            reg = <0x0 0xa0041000 0x0 0x1000>;
> > > +        };
> > 
> > IIRC we had been discussing this recently and Rob wanted to have just
> > 1/1 mapping here.
> > 
> > Take a look at 0db958b689ca9.
> 
> Thanks for the pointer.
> 
> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
> bus with more cells? I still see several examples that add a bus with 2 cells.
> I assume that they more or less legacy, but I didn't find any discussion going
> beyond the commit description of 0db958b689ca9, which "just" fixes the
> warnings.
> 
> I will send a v2, but I'd like to understand the rationale for having the 1/1
> mapping first.

Simplifies the example is all.

This one is fine as-is.

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
@ 2020-12-09 18:34       ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-09 18:34 UTC (permalink / raw)
  To: Michael Tretter; +Cc: kernel, devicetree, Michal Simek, linux-arm-kernel

On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> > On 02. 12. 20 10:05, Michael Tretter wrote:
> > > When running make dt_binding_check, the xlnx,vcu-settings binding
> > > triggers the following two warnings:
> > > 
> > > 	'additionalProperties' is a required property
> > > 
> > > 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> > > 
> > > Fix the binding and make the checker happy.
> > > 
> > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > > ---
> > > 
> > > Hi,
> > > 
> > > The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> > > run automated tests on the device tree bindings, but now produces some
> > > warnings. The original patch that introduces the binding is still in
> > > Michal's tree and I am not entirely sure how to handle it, but here is a
> > > patch.
> > > 
> > > Michael
> > > 
> > > [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> > > ---
> > >  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> > >  1 file changed, 12 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > index 378d0ced43c8..cb245f400287 100644
> > > --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> > > @@ -26,9 +26,18 @@ required:
> > >    - compatible
> > >    - reg
> > >  
> > > +additionalProperties: false
> > > +
> > >  examples:
> > >    - |
> > > -    xlnx_vcu: vcu@a0041000 {
> > > -          compatible = "xlnx,vcu-settings", "syscon";
> > > -          reg = <0x0 0xa0041000 0x0 0x1000>;
> > > +    fpga {
> > > +        #address-cells = <2>;
> > > +        #size-cells = <2>;
> > > +
> > > +        xlnx_vcu: vcu@a0041000 {
> > > +            compatible = "xlnx,vcu-settings", "syscon";
> > > +            reg = <0x0 0xa0041000 0x0 0x1000>;
> > > +        };
> > 
> > IIRC we had been discussing this recently and Rob wanted to have just
> > 1/1 mapping here.
> > 
> > Take a look at 0db958b689ca9.
> 
> Thanks for the pointer.
> 
> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
> bus with more cells? I still see several examples that add a bus with 2 cells.
> I assume that they more or less legacy, but I didn't find any discussion going
> beyond the commit description of 0db958b689ca9, which "just" fixes the
> warnings.
> 
> I will send a v2, but I'd like to understand the rationale for having the 1/1
> mapping first.

Simplifies the example is all.

This one is fine as-is.

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
  2020-12-09 18:34       ` Rob Herring
@ 2020-12-09 18:58         ` Michal Simek
  -1 siblings, 0 replies; 14+ messages in thread
From: Michal Simek @ 2020-12-09 18:58 UTC (permalink / raw)
  To: Rob Herring, Michael Tretter
  Cc: Michal Simek, devicetree, linux-arm-kernel, kernel

Hi Rob,

On 09. 12. 20 19:34, Rob Herring wrote:
> On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
>> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
>>> On 02. 12. 20 10:05, Michael Tretter wrote:
>>>> When running make dt_binding_check, the xlnx,vcu-settings binding
>>>> triggers the following two warnings:
>>>>
>>>> 	'additionalProperties' is a required property
>>>>
>>>> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
>>>>
>>>> Fix the binding and make the checker happy.
>>>>
>>>> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
>>>> ---
>>>>
>>>> Hi,
>>>>
>>>> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
>>>> run automated tests on the device tree bindings, but now produces some
>>>> warnings. The original patch that introduces the binding is still in
>>>> Michal's tree and I am not entirely sure how to handle it, but here is a
>>>> patch.
>>>>
>>>> Michael
>>>>
>>>> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
>>>> ---
>>>>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>>>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> index 378d0ced43c8..cb245f400287 100644
>>>> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> @@ -26,9 +26,18 @@ required:
>>>>    - compatible
>>>>    - reg
>>>>  
>>>> +additionalProperties: false
>>>> +
>>>>  examples:
>>>>    - |
>>>> -    xlnx_vcu: vcu@a0041000 {
>>>> -          compatible = "xlnx,vcu-settings", "syscon";
>>>> -          reg = <0x0 0xa0041000 0x0 0x1000>;
>>>> +    fpga {
>>>> +        #address-cells = <2>;
>>>> +        #size-cells = <2>;
>>>> +
>>>> +        xlnx_vcu: vcu@a0041000 {
>>>> +            compatible = "xlnx,vcu-settings", "syscon";
>>>> +            reg = <0x0 0xa0041000 0x0 0x1000>;
>>>> +        };
>>>
>>> IIRC we had been discussing this recently and Rob wanted to have just
>>> 1/1 mapping here.
>>>
>>> Take a look at 0db958b689ca9.
>>
>> Thanks for the pointer.
>>
>> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
>> bus with more cells? I still see several examples that add a bus with 2 cells.
>> I assume that they more or less legacy, but I didn't find any discussion going
>> beyond the commit description of 0db958b689ca9, which "just" fixes the
>> warnings.
>>
>> I will send a v2, but I'd like to understand the rationale for having the 1/1
>> mapping first.
> 
> Simplifies the example is all.
> 
> This one is fine as-is.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

I remember that we have been fixing that 2:2 mapping to 1:1 in past.

And simplification in this case would be
- reg = <0x0 0xa0041000 0x0 0x1000>;
+ reg = <0xa0041000 0x1000>;

That's why I would like to know what we should be asking people to do.
Or is it fine because it is the part of fpga node?

Thanks,
Michal




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
@ 2020-12-09 18:58         ` Michal Simek
  0 siblings, 0 replies; 14+ messages in thread
From: Michal Simek @ 2020-12-09 18:58 UTC (permalink / raw)
  To: Rob Herring, Michael Tretter
  Cc: kernel, devicetree, Michal Simek, linux-arm-kernel

Hi Rob,

On 09. 12. 20 19:34, Rob Herring wrote:
> On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
>> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
>>> On 02. 12. 20 10:05, Michael Tretter wrote:
>>>> When running make dt_binding_check, the xlnx,vcu-settings binding
>>>> triggers the following two warnings:
>>>>
>>>> 	'additionalProperties' is a required property
>>>>
>>>> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
>>>>
>>>> Fix the binding and make the checker happy.
>>>>
>>>> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
>>>> ---
>>>>
>>>> Hi,
>>>>
>>>> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
>>>> run automated tests on the device tree bindings, but now produces some
>>>> warnings. The original patch that introduces the binding is still in
>>>> Michal's tree and I am not entirely sure how to handle it, but here is a
>>>> patch.
>>>>
>>>> Michael
>>>>
>>>> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
>>>> ---
>>>>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>>>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> index 378d0ced43c8..cb245f400287 100644
>>>> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>>>> @@ -26,9 +26,18 @@ required:
>>>>    - compatible
>>>>    - reg
>>>>  
>>>> +additionalProperties: false
>>>> +
>>>>  examples:
>>>>    - |
>>>> -    xlnx_vcu: vcu@a0041000 {
>>>> -          compatible = "xlnx,vcu-settings", "syscon";
>>>> -          reg = <0x0 0xa0041000 0x0 0x1000>;
>>>> +    fpga {
>>>> +        #address-cells = <2>;
>>>> +        #size-cells = <2>;
>>>> +
>>>> +        xlnx_vcu: vcu@a0041000 {
>>>> +            compatible = "xlnx,vcu-settings", "syscon";
>>>> +            reg = <0x0 0xa0041000 0x0 0x1000>;
>>>> +        };
>>>
>>> IIRC we had been discussing this recently and Rob wanted to have just
>>> 1/1 mapping here.
>>>
>>> Take a look at 0db958b689ca9.
>>
>> Thanks for the pointer.
>>
>> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
>> bus with more cells? I still see several examples that add a bus with 2 cells.
>> I assume that they more or less legacy, but I didn't find any discussion going
>> beyond the commit description of 0db958b689ca9, which "just" fixes the
>> warnings.
>>
>> I will send a v2, but I'd like to understand the rationale for having the 1/1
>> mapping first.
> 
> Simplifies the example is all.
> 
> This one is fine as-is.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

I remember that we have been fixing that 2:2 mapping to 1:1 in past.

And simplification in this case would be
- reg = <0x0 0xa0041000 0x0 0x1000>;
+ reg = <0xa0041000 0x1000>;

That's why I would like to know what we should be asking people to do.
Or is it fine because it is the part of fpga node?

Thanks,
Michal




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings
  2020-12-09 18:58         ` Michal Simek
@ 2020-12-18 18:35           ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-18 18:35 UTC (permalink / raw)
  To: Michal Simek; +Cc: Michael Tretter, devicetree, linux-arm-kernel, Sascha Hauer

On Wed, Dec 9, 2020 at 12:59 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Hi Rob,
>
> On 09. 12. 20 19:34, Rob Herring wrote:
> > On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
> >> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> >>> On 02. 12. 20 10:05, Michael Tretter wrote:
> >>>> When running make dt_binding_check, the xlnx,vcu-settings binding
> >>>> triggers the following two warnings:
> >>>>
> >>>>    'additionalProperties' is a required property
> >>>>
> >>>>    example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> >>>>
> >>>> Fix the binding and make the checker happy.
> >>>>
> >>>> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> >>>> ---
> >>>>
> >>>> Hi,
> >>>>
> >>>> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> >>>> run automated tests on the device tree bindings, but now produces some
> >>>> warnings. The original patch that introduces the binding is still in
> >>>> Michal's tree and I am not entirely sure how to handle it, but here is a
> >>>> patch.
> >>>>
> >>>> Michael
> >>>>
> >>>> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> >>>> ---
> >>>>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> >>>>  1 file changed, 12 insertions(+), 3 deletions(-)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> index 378d0ced43c8..cb245f400287 100644
> >>>> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> @@ -26,9 +26,18 @@ required:
> >>>>    - compatible
> >>>>    - reg
> >>>>
> >>>> +additionalProperties: false
> >>>> +
> >>>>  examples:
> >>>>    - |
> >>>> -    xlnx_vcu: vcu@a0041000 {
> >>>> -          compatible = "xlnx,vcu-settings", "syscon";
> >>>> -          reg = <0x0 0xa0041000 0x0 0x1000>;
> >>>> +    fpga {
> >>>> +        #address-cells = <2>;
> >>>> +        #size-cells = <2>;
> >>>> +
> >>>> +        xlnx_vcu: vcu@a0041000 {
> >>>> +            compatible = "xlnx,vcu-settings", "syscon";
> >>>> +            reg = <0x0 0xa0041000 0x0 0x1000>;
> >>>> +        };
> >>>
> >>> IIRC we had been discussing this recently and Rob wanted to have just
> >>> 1/1 mapping here.
> >>>
> >>> Take a look at 0db958b689ca9.
> >>
> >> Thanks for the pointer.
> >>
> >> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
> >> bus with more cells? I still see several examples that add a bus with 2 cells.
> >> I assume that they more or less legacy, but I didn't find any discussion going
> >> beyond the commit description of 0db958b689ca9, which "just" fixes the
> >> warnings.
> >>
> >> I will send a v2, but I'd like to understand the rationale for having the 1/1
> >> mapping first.
> >
> > Simplifies the example is all.
> >
> > This one is fine as-is.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> I remember that we have been fixing that 2:2 mapping to 1:1 in past.
>
> And simplification in this case would be
> - reg = <0x0 0xa0041000 0x0 0x1000>;
> + reg = <0xa0041000 0x1000>;
>
> That's why I would like to know what we should be asking people to do.
> Or is it fine because it is the part of fpga node?

1:1 is my preference, but I'm not going to enforce either way.

Rob

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings
@ 2020-12-18 18:35           ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-18 18:35 UTC (permalink / raw)
  To: Michal Simek; +Cc: Sascha Hauer, devicetree, Michael Tretter, linux-arm-kernel

On Wed, Dec 9, 2020 at 12:59 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Hi Rob,
>
> On 09. 12. 20 19:34, Rob Herring wrote:
> > On Thu, Dec 03, 2020 at 09:48:04AM +0100, Michael Tretter wrote:
> >> On Thu, 03 Dec 2020 08:49:01 +0100, Michal Simek wrote:
> >>> On 02. 12. 20 10:05, Michael Tretter wrote:
> >>>> When running make dt_binding_check, the xlnx,vcu-settings binding
> >>>> triggers the following two warnings:
> >>>>
> >>>>    'additionalProperties' is a required property
> >>>>
> >>>>    example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> >>>>
> >>>> Fix the binding and make the checker happy.
> >>>>
> >>>> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> >>>> ---
> >>>>
> >>>> Hi,
> >>>>
> >>>> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> >>>> run automated tests on the device tree bindings, but now produces some
> >>>> warnings. The original patch that introduces the binding is still in
> >>>> Michal's tree and I am not entirely sure how to handle it, but here is a
> >>>> patch.
> >>>>
> >>>> Michael
> >>>>
> >>>> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> >>>> ---
> >>>>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
> >>>>  1 file changed, 12 insertions(+), 3 deletions(-)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> index 378d0ced43c8..cb245f400287 100644
> >>>> --- a/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >>>> @@ -26,9 +26,18 @@ required:
> >>>>    - compatible
> >>>>    - reg
> >>>>
> >>>> +additionalProperties: false
> >>>> +
> >>>>  examples:
> >>>>    - |
> >>>> -    xlnx_vcu: vcu@a0041000 {
> >>>> -          compatible = "xlnx,vcu-settings", "syscon";
> >>>> -          reg = <0x0 0xa0041000 0x0 0x1000>;
> >>>> +    fpga {
> >>>> +        #address-cells = <2>;
> >>>> +        #size-cells = <2>;
> >>>> +
> >>>> +        xlnx_vcu: vcu@a0041000 {
> >>>> +            compatible = "xlnx,vcu-settings", "syscon";
> >>>> +            reg = <0x0 0xa0041000 0x0 0x1000>;
> >>>> +        };
> >>>
> >>> IIRC we had been discussing this recently and Rob wanted to have just
> >>> 1/1 mapping here.
> >>>
> >>> Take a look at 0db958b689ca9.
> >>
> >> Thanks for the pointer.
> >>
> >> Rob: Is there some kind of rule, when to use a 1/1 mapping and when to add a
> >> bus with more cells? I still see several examples that add a bus with 2 cells.
> >> I assume that they more or less legacy, but I didn't find any discussion going
> >> beyond the commit description of 0db958b689ca9, which "just" fixes the
> >> warnings.
> >>
> >> I will send a v2, but I'd like to understand the rationale for having the 1/1
> >> mapping first.
> >
> > Simplifies the example is all.
> >
> > This one is fine as-is.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> I remember that we have been fixing that 2:2 mapping to 1:1 in past.
>
> And simplification in this case would be
> - reg = <0x0 0xa0041000 0x0 0x1000>;
> + reg = <0xa0041000 0x1000>;
>
> That's why I would like to know what we should be asking people to do.
> Or is it fine because it is the part of fpga node?

1:1 is my preference, but I'm not going to enforce either way.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings
  2020-12-02  9:05 ` [PATCH] dt-bindings: xlnx, vcu-settings: " Michael Tretter
@ 2020-12-18 21:17   ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-18 21:17 UTC (permalink / raw)
  To: Michael Tretter
  Cc: kernel, linux-arm-kernel, devicetree, michal.simek, robh+dt

On Wed, 02 Dec 2020 10:05:22 +0100, Michael Tretter wrote:
> When running make dt_binding_check, the xlnx,vcu-settings binding
> triggers the following two warnings:
> 
> 	'additionalProperties' is a required property
> 
> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> 
> Fix the binding and make the checker happy.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> 
> Hi,
> 
> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> run automated tests on the device tree bindings, but now produces some
> warnings. The original patch that introduces the binding is still in
> Michal's tree and I am not entirely sure how to handle it, but here is a
> patch.
> 
> Michael
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> ---
>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dt-bindings: xlnx, vcu-settings: fix dt_binding_check warnings
@ 2020-12-18 21:17   ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-12-18 21:17 UTC (permalink / raw)
  To: Michael Tretter
  Cc: devicetree, robh+dt, linux-arm-kernel, kernel, michal.simek

On Wed, 02 Dec 2020 10:05:22 +0100, Michael Tretter wrote:
> When running make dt_binding_check, the xlnx,vcu-settings binding
> triggers the following two warnings:
> 
> 	'additionalProperties' is a required property
> 
> 	example-0: vcu@a0041000:reg:0: [0, 2684620800, 0, 4096] is too long
> 
> Fix the binding and make the checker happy.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> 
> Hi,
> 
> The xlnx,vcu-settings binding was reviewed [0] before the bot started to
> run automated tests on the device tree bindings, but now produces some
> warnings. The original patch that introduces the binding is still in
> Michal's tree and I am not entirely sure how to handle it, but here is a
> patch.
> 
> Michael
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20200429213659.GA9051@bogus/
> ---
>  .../bindings/soc/xilinx/xlnx,vcu-settings.yaml    | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-12-18 21:18 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02  9:05 [PATCH] dt-bindings: xlnx,vcu-settings: fix dt_binding_check warnings Michael Tretter
2020-12-02  9:05 ` [PATCH] dt-bindings: xlnx, vcu-settings: " Michael Tretter
2020-12-03  7:49 ` [PATCH] dt-bindings: xlnx,vcu-settings: " Michal Simek
2020-12-03  7:49   ` Michal Simek
2020-12-03  8:48   ` Michael Tretter
2020-12-03  8:48     ` Michael Tretter
2020-12-09 18:34     ` Rob Herring
2020-12-09 18:34       ` Rob Herring
2020-12-09 18:58       ` Michal Simek
2020-12-09 18:58         ` Michal Simek
2020-12-18 18:35         ` Rob Herring
2020-12-18 18:35           ` [PATCH] dt-bindings: xlnx, vcu-settings: " Rob Herring
2020-12-18 21:17 ` Rob Herring
2020-12-18 21:17   ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.