From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA63C64E90 for ; Wed, 2 Dec 2020 11:50:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB86522203 for ; Wed, 2 Dec 2020 11:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729833AbgLBLt5 (ORCPT ); Wed, 2 Dec 2020 06:49:57 -0500 Received: from foss.arm.com ([217.140.110.172]:37166 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgLBLt5 (ORCPT ); Wed, 2 Dec 2020 06:49:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C3C03101E; Wed, 2 Dec 2020 03:49:11 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64CC13F718; Wed, 2 Dec 2020 03:49:11 -0800 (PST) Date: Wed, 2 Dec 2020 11:49:10 +0000 From: Ionela Voinescu To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, orjan.eide@arm.com, robh@kernel.org, alyssa.rosenzweig@collabora.com, steven.price@arm.com, airlied@linux.ie, daniel@ffwll.ch Subject: Re: [PATCH v2 3/5] thermal: devfreq_cooling: add new registration functions with Energy Model Message-ID: <20201202114909.GA1198@arm.com> References: <20201118120358.17150-1-lukasz.luba@arm.com> <20201118120358.17150-4-lukasz.luba@arm.com> <20201202102439.GA1639@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 Dec 2020 at 11:14:02 (+0000), Lukasz Luba wrote: > Hi Ionela, > > On 12/2/20 10:24 AM, Ionela Voinescu wrote: > > Hi Lukasz, > > > > On Wednesday 18 Nov 2020 at 12:03:56 (+0000), Lukasz Luba wrote: > > [snip] > > > > + struct device_node *np = NULL; > > [snip] > > > > + > > > + if (dev->of_node) > > > + np = of_node_get(dev->of_node); > > > + > > > > Should np be checked before use? I'm not sure if it's better to do the > > assign first and then the check on np before use. It depends on the > > consequences of passing a NULL node pointer later on. > > The np is actually dev->of_node (or left NULL, as set at the begging). > The only meaning of the line above is to increment the counter and then > decrement if CONFIG_OF_DYNAMIC was used. > The devfreq_cooling_register() has np = NULL and the registration can > handle it, so we should be OK here as well. > Yes, I just wanted to make sure later registration can handle np = NULL, or whether we need to bail out. In this case, you can drop both ifs - for (dev->of_node) before get and for np before put below, as of_node_get/of_node_put can handle NULL pointers themselves. Thanks, Ionela. > > > > > + cdev = of_devfreq_cooling_register_power(np, df, dfc_power); > > > + > > > + if (np) > > > + of_node_put(np); > > > + > > [snip] > > > > > > > > Otherwise it looks good to me: > > > > Reviewed-by: Ionela Voinescu > > Thank you for the review. > > Regards, > Lukasz > > > > > Ionela. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8041CC64E7B for ; Thu, 3 Dec 2020 08:15:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2391E21D1A for ; Thu, 3 Dec 2020 08:15:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2391E21D1A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3383A6E0C1; Thu, 3 Dec 2020 08:14:47 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D2CC6EA18 for ; Wed, 2 Dec 2020 11:49:12 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C3C03101E; Wed, 2 Dec 2020 03:49:11 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64CC13F718; Wed, 2 Dec 2020 03:49:11 -0800 (PST) Date: Wed, 2 Dec 2020 11:49:10 +0000 From: Ionela Voinescu To: Lukasz Luba Subject: Re: [PATCH v2 3/5] thermal: devfreq_cooling: add new registration functions with Energy Model Message-ID: <20201202114909.GA1198@arm.com> References: <20201118120358.17150-1-lukasz.luba@arm.com> <20201118120358.17150-4-lukasz.luba@arm.com> <20201202102439.GA1639@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Thu, 03 Dec 2020 08:14:41 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kucheria@verdurent.com, linux-pm@vger.kernel.org, airlied@linux.ie, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, rui.zhang@intel.com, orjan.eide@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wednesday 02 Dec 2020 at 11:14:02 (+0000), Lukasz Luba wrote: > Hi Ionela, > > On 12/2/20 10:24 AM, Ionela Voinescu wrote: > > Hi Lukasz, > > > > On Wednesday 18 Nov 2020 at 12:03:56 (+0000), Lukasz Luba wrote: > > [snip] > > > > + struct device_node *np = NULL; > > [snip] > > > > + > > > + if (dev->of_node) > > > + np = of_node_get(dev->of_node); > > > + > > > > Should np be checked before use? I'm not sure if it's better to do the > > assign first and then the check on np before use. It depends on the > > consequences of passing a NULL node pointer later on. > > The np is actually dev->of_node (or left NULL, as set at the begging). > The only meaning of the line above is to increment the counter and then > decrement if CONFIG_OF_DYNAMIC was used. > The devfreq_cooling_register() has np = NULL and the registration can > handle it, so we should be OK here as well. > Yes, I just wanted to make sure later registration can handle np = NULL, or whether we need to bail out. In this case, you can drop both ifs - for (dev->of_node) before get and for np before put below, as of_node_get/of_node_put can handle NULL pointers themselves. Thanks, Ionela. > > > > > + cdev = of_devfreq_cooling_register_power(np, df, dfc_power); > > > + > > > + if (np) > > > + of_node_put(np); > > > + > > [snip] > > > > > > > > Otherwise it looks good to me: > > > > Reviewed-by: Ionela Voinescu > > Thank you for the review. > > Regards, > Lukasz > > > > > Ionela. > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel