From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E2EAC64E8A for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3144122203 for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729996AbgLBMZF (ORCPT ); Wed, 2 Dec 2020 07:25:05 -0500 Received: from mga02.intel.com ([134.134.136.20]:59805 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727452AbgLBMZE (ORCPT ); Wed, 2 Dec 2020 07:25:04 -0500 IronPort-SDR: 5kc3DcyaKwtX/x/SD0SkSYCIkKL4k3L0EXQ816eiOJdoZnd5zTaiWTMdtkHYyaZndnrbo5rvNM PeHqkbEHm1Qw== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="160062383" X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="160062383" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 04:24:22 -0800 IronPort-SDR: xh8lr/WE+6xYxAZ+YfiDaAil3wTohc+XaXKLK0gKVo4tfM0Rryv3JUlq+Jb9iBKdRuwmNgz1Ug sWkFZLWjih4w== X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="373159679" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 04:24:18 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kkRCC-00BVMG-A5; Wed, 02 Dec 2020 14:25:20 +0200 Date: Wed, 2 Dec 2020 14:25:20 +0200 From: "Shevchenko, Andriy" To: Ulf Hansson Cc: "Zulkifli, Muhammad Husaini" , Adrian Hunter , Michal Simek , "linux-mmc@vger.kernel.org" , Linux ARM , Linux Kernel Mailing List , "Raja Subramanian, Lakshmi Bai" , Wan Ahmad Zainie , mgross@linux.intel.com, linus.walleij@linaro.org Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC Message-ID: <20201202122520.GD4077@smile.fi.intel.com> References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > On Wed, 2 Dec 2020 at 08:02, wrote: ... > > Kindly help to review this patch set. > > This version looks a lot better to me, but I am still requesting you > to model the pinctrl correctly. I don't see a reason not to, but I may > have overlooked some things. I'm wondering why we need to mock up a pin control from something which has no pin control interface. It's rather communication with firmware that does pin control under the hood, but it also may be different hardware in the other / future generations. Would you accept mocking up the same calls over the kernel as pin control, as something else? > Would you mind to re-submit to include the gpio/pinctlr list and the > maintainers, to get their opinion. And I will send immediately the same comment which I believe Linus W. supports. But who knows... Cc'ed to Linus as I mentioned him. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462C7C64E7C for ; Wed, 2 Dec 2020 12:25:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3C53221FE for ; Wed, 2 Dec 2020 12:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3C53221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MDh5/j2HtUWS72Zx/DDodpA0W3YCgaUe5F10yJXSThw=; b=SzvD22k2LLnDm0BHyqFjTC0G7 Q6Z1ukQ5Nc1alQPJGAuZviqFlMqMsH+wzSdS1ldGvcarXnddd3jRvnR/Xq3roVqu6XVSPbO0qFMJi VCOEa4G7nsz1AZUS4wK7VwgdeVk5CbO6XVyCYxE9hvYZuJ+3LfIYrjcFXfIPBtMILk5FXeZI4aoHm IxAeQ1DN0g78zM0EX/Pmv8VOgJELAP5z0AcV1MbMM8pQv+3BbPqmi2xaQyRgG73E2XxECztrYUeXU uatxyum6mgJOi6wxAHGOJ+xNAI0njK+y7dJ5eTMMtQDWtnodlzfUFr88ceDufCD7m6ydXxc3Q0e6R N2G960sSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRBQ-0006Ew-GI; Wed, 02 Dec 2020 12:24:32 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRBN-0006Ce-FJ for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:24:30 +0000 IronPort-SDR: P23pWHmQ1S/sjPgnumum5SuZyU54F3IZNAhwlF3RhUVLk7YxeYFdEjfKlYzdaHmXudA52hB273 EltHa7ykt8Aw== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="160062384" X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="160062384" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 04:24:22 -0800 IronPort-SDR: xh8lr/WE+6xYxAZ+YfiDaAil3wTohc+XaXKLK0gKVo4tfM0Rryv3JUlq+Jb9iBKdRuwmNgz1Ug sWkFZLWjih4w== X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="373159679" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 04:24:18 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kkRCC-00BVMG-A5; Wed, 02 Dec 2020 14:25:20 +0200 Date: Wed, 2 Dec 2020 14:25:20 +0200 From: "Shevchenko, Andriy" To: Ulf Hansson Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC Message-ID: <20201202122520.GD4077@smile.fi.intel.com> References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_072429_661589_046F1407 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mgross@linux.intel.com, "Raja Subramanian, Lakshmi Bai" , linus.walleij@linaro.org, "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Adrian Hunter , Wan Ahmad Zainie , "Zulkifli, Muhammad Husaini" , Michal Simek , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > On Wed, 2 Dec 2020 at 08:02, wrote: ... > > Kindly help to review this patch set. > > This version looks a lot better to me, but I am still requesting you > to model the pinctrl correctly. I don't see a reason not to, but I may > have overlooked some things. I'm wondering why we need to mock up a pin control from something which has no pin control interface. It's rather communication with firmware that does pin control under the hood, but it also may be different hardware in the other / future generations. Would you accept mocking up the same calls over the kernel as pin control, as something else? > Would you mind to re-submit to include the gpio/pinctlr list and the > maintainers, to get their opinion. And I will send immediately the same comment which I believe Linus W. supports. But who knows... Cc'ed to Linus as I mentioned him. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel