From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D632FC64E7C for ; Wed, 2 Dec 2020 13:17:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1368F217A0 for ; Wed, 2 Dec 2020 13:16:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1368F217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkS0A-0001vk-HL for qemu-devel@archiver.kernel.org; Wed, 02 Dec 2020 08:16:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkRz2-0001KP-89 for qemu-devel@nongnu.org; Wed, 02 Dec 2020 08:15:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kkRyv-0003SL-Vd for qemu-devel@nongnu.org; Wed, 02 Dec 2020 08:15:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606914940; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=wOYDlRM1J1TX4rNcpF87wktxTBIRfGv+/XJxtZaV5sU=; b=C1mVj2jti4hQSnpTGi+hp/JHi781zmoDPpfpLNXIt9L4h/RCJubvWUJvIgwo4eki+fGZgY /mGkiUoxfnf/itFpkbRBOrcpd/9o0HQ9XrXraqaZbywa9rNeWlwjNhpLkSHNuBz3T+OPZJ DivjnAf3VFxcGNx5+9GeqnOQ9qNcUys= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-hhEBAYH-N22WCabSod8-Cw-1; Wed, 02 Dec 2020 08:15:35 -0500 X-MC-Unique: hhEBAYH-N22WCabSod8-Cw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5B8D108E1A3 for ; Wed, 2 Dec 2020 13:15:34 +0000 (UTC) Received: from redhat.com (ovpn-115-57.ams2.redhat.com [10.36.115.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDBE310016F4; Wed, 2 Dec 2020 13:15:33 +0000 (UTC) Date: Wed, 2 Dec 2020 13:15:31 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Dr. David Alan Gilbert" Subject: Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming Message-ID: <20201202131531.GI2360260@redhat.com> References: <20201027182144.3315885-1-pbonzini@redhat.com> <20201027182144.3315885-25-pbonzini@redhat.com> <20201120163408.7740a92f@redhat.com> <0562d6fa-b619-7dc3-ef94-242a39436cfa@redhat.com> <20201202131037.GF3226@work-vm> MIME-Version: 1.0 In-Reply-To: <20201202131037.GF3226@work-vm> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Dec 02, 2020 at 01:10:37PM +0000, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonzini@redhat.com) wrote: > > On 20/11/20 16:34, Igor Mammedov wrote: > > > > qapi_event_send_migration(MIGRATION_STATUS_SETUP); > > > > - if (!strcmp(uri, "defer")) { > > > > - deferred_incoming_migration(errp); > > > > - } else if (strstart(uri, "tcp:", &p) || > > > > - strstart(uri, "unix:", NULL) || > > > > - strstart(uri, "vsock:", NULL)) { > > > considering the last hunk does won't call qmp_migrate_incoming > > > if 'defer' was used, wouldn't we will lose QAPI event here? > > > not sure how important it to users, > > > > Hmm yeah that's true. That might even be considered a bugfix (no setup is > > done until the "real" migrate-incoming command), but I can also add the > > event manually in qemu_init. > > > > (Libvirt doesn't use the SETUP case of the event but that's of course only > > part of the story). > > I'm more worried about how this stops a repeated 'migrate incoming' > or a 'migrate_incoming' that's issued following a qemu that's been > started with -incoming tcp:... but which a socket hasn't yet connected > to. Can someone remind me why we need to have an -incoming arg at all ? With snapshots, we can just start QEMU normally, using -S if desired, and then invoke "loadvm" to restore from a snapshot at any time. What is different thet means we can't just run "migrate_incoming" on any QEMU at any time, ignoring -incoming entirely ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|