From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE028C64E7C for ; Wed, 2 Dec 2020 13:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F7BB21D7A for ; Wed, 2 Dec 2020 13:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbgLBNxf (ORCPT ); Wed, 2 Dec 2020 08:53:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:58562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbgLBNxe (ORCPT ); Wed, 2 Dec 2020 08:53:34 -0500 Date: Wed, 2 Dec 2020 08:52:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606917174; bh=XoTqkyOnuVg8HpNdvuGD83rFYjABvTKLsBNEJ6NZteE=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=tPpaWrQ3dJTwskCY/56qUbgy+9tH8zCKhcUbfxZ0tpKQ88DuZjzz5VTpkG4ftYItF 9MhlhrJpcxN5psa1pw0e6F/GoxY+xnQH8Y/scMJcHQvN1oDVzcG6NvOBpLEaOMgrLG ur5Li3JIPz9mxkhZhg1z2LvRMes/t0QItF4ovQFQ= From: Sasha Levin To: Peter Zijlstra Cc: Vincent Guittot , Greg KH , "Guilherme G. Piccoli" , Ben Segall , Ingo Molnar , Phil Auld , Tao Zhou , "# v4 . 16+" , Gavin Guo , nivedita.singhvi@canonical.com, halves@canonical.com, Jay Vosburgh Subject: Re: FAILED: patch "[PATCH] sched/fair: Fix unthrottle_cfs_rq() for leaf_cfs_rq list" failed to apply to 5.4-stable tree Message-ID: <20201202135252.GW643756@sasha-vm> References: <20201202094428.GC3040@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201202094428.GC3040@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Dec 02, 2020 at 10:44:28AM +0100, Peter Zijlstra wrote: >On Wed, Dec 02, 2020 at 09:21:19AM +0100, Vincent Guittot wrote: >> On Wed, 2 Dec 2020 at 08:49, Greg KH wrote: >> > >> > On Tue, Dec 01, 2020 at 12:03:18PM -0300, Guilherme G. Piccoli wrote: >> > > Hey Sasha, sorry to annoy again, but maybe Peter is very busy - wouldn't >> > > be possible maybe to get that merged after a review from Ben or Ingo? I >> > > see them in the MAINTAINERS file, specially Ben as CONFIG_CFS_BANDWIDTH >> > > maintainer. >> > > >> > > I understand the confidence in this patch is relatively high, since it's >> > > a backport from the author, right? >> > >> > I still want to see an ack from the maintainer please. >> >> SCHEDULER > >> M: Vincent Guittot (SCHED_NORMAL) > >Vincent is also the one that knows that leaf code best, he did the >backport, you're not going to get better than that. So I've asked for someone else to review this because the backport is somehat different from the upstream commit. Ideally we want these types of backports to be peer reviewed, just like any other commit that lands upstream. If the sched folks feel good about that backport (as indicated above...) I'll happily merge it in. -- Thanks, Sasha