From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DAAC64E7B for ; Thu, 3 Dec 2020 08:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5C2D2223C for ; Thu, 3 Dec 2020 08:54:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbgLCIyX (ORCPT ); Thu, 3 Dec 2020 03:54:23 -0500 Received: from verein.lst.de ([213.95.11.211]:57654 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgLCIyX (ORCPT ); Thu, 3 Dec 2020 03:54:23 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id B9FC867373; Thu, 3 Dec 2020 09:53:39 +0100 (CET) Date: Thu, 3 Dec 2020 09:53:39 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Cc: Christoph Hellwig , Jens Axboe , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 1/4] block: add a hard-readonly flag to struct gendisk Message-ID: <20201203085339.GA17110@lst.de> References: <20201129181926.897775-1-hch@lst.de> <20201129181926.897775-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Dec 02, 2020 at 11:04:33PM -0500, Martin K. Petersen wrote: > > Hi Christoph! > > > - If BLKROSET is used to set a whole-disk device read-only, any > > partitions will end up in a read-only state until the user > > explicitly clears the flag. > > This no longer appears to be the case with your tweak. True. > > It's very common for database folks to twiddle the read-only state of > block devices and partitions. I know that our users will find it very > counter-intuitive that setting /dev/sda read-only won't prevent writes > to /dev/sda1. What I'm worried about it is that this would be a huge change from the historic behavior. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBEFC63777 for ; Thu, 3 Dec 2020 08:54:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD4FF22280 for ; Thu, 3 Dec 2020 08:54:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD4FF22280 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KwI0Bn+JWueTKM29ikeuCaSsRlW+sEWuUVWJCgDHjfE=; b=OqGC+Bbt3/sgy3kcBk6SKl+OO 4lwTe5szVfeiLiutLTu+sZjrCZsSSWL+k0B/Nm9ILzJa/vbm0/90oAHG6upWdtY8F7uvW4zzFqLCh coCSlEE+dosJjgRYeKra7z5OBDbAZ5U7NWYZgkensbVM7RU5KwfqzyteZVRKoPt2wE76DgluWFx6a WGNOx7tJJG/rWdU6nEs3cWlM+OtfmqFGCFIS74V48MOeuFf7f6o/tK4kkEJgR73yHbcZU1Msymq0o 2nUdCYkDPiNcKtocSY7rw4Q02nTzxgo7/8m1V9eo7CgWm3GhdQH6IjcLX1r+j310Jg7LxJwWzHKH1 EXaEPemBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkkNC-0007qk-C2; Thu, 03 Dec 2020 08:53:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkkN6-0007ou-0j for linux-nvme@lists.infradead.org; Thu, 03 Dec 2020 08:53:56 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B9FC867373; Thu, 3 Dec 2020 09:53:39 +0100 (CET) Date: Thu, 3 Dec 2020 09:53:39 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Subject: Re: [PATCH 1/4] block: add a hard-readonly flag to struct gendisk Message-ID: <20201203085339.GA17110@lst.de> References: <20201129181926.897775-1-hch@lst.de> <20201129181926.897775-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_035355_918502_78075261 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , ceph-devel@vger.kernel.org, Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, Ilya Dryomov , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 11:04:33PM -0500, Martin K. Petersen wrote: > > Hi Christoph! > > > - If BLKROSET is used to set a whole-disk device read-only, any > > partitions will end up in a read-only state until the user > > explicitly clears the flag. > > This no longer appears to be the case with your tweak. True. > > It's very common for database folks to twiddle the read-only state of > block devices and partitions. I know that our users will find it very > counter-intuitive that setting /dev/sda read-only won't prevent writes > to /dev/sda1. What I'm worried about it is that this would be a huge change from the historic behavior. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1949C71156 for ; Thu, 3 Dec 2020 08:54:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9AC72223C for ; Thu, 3 Dec 2020 08:54:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9AC72223C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-IMUlhvHLNT6t8iO2z7hyyQ-1; Thu, 03 Dec 2020 03:53:59 -0500 X-MC-Unique: IMUlhvHLNT6t8iO2z7hyyQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13AE31081B27; Thu, 3 Dec 2020 08:53:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926F55C1B4; Thu, 3 Dec 2020 08:53:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 335904EA6C; Thu, 3 Dec 2020 08:53:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B38roHn011209 for ; Thu, 3 Dec 2020 03:53:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7E8862166B29; Thu, 3 Dec 2020 08:53:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79AB42166B27 for ; Thu, 3 Dec 2020 08:53:48 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B8E1800B3B for ; Thu, 3 Dec 2020 08:53:48 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-QmbqKdjrMI2Pbx4Vp-A23A-1; Thu, 03 Dec 2020 03:53:43 -0500 X-MC-Unique: QmbqKdjrMI2Pbx4Vp-A23A-1 Received: by verein.lst.de (Postfix, from userid 2407) id B9FC867373; Thu, 3 Dec 2020 09:53:39 +0100 (CET) Date: Thu, 3 Dec 2020 09:53:39 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Message-ID: <20201203085339.GA17110@lst.de> References: <20201129181926.897775-1-hch@lst.de> <20201129181926.897775-2-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , ceph-devel@vger.kernel.org, Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, Ilya Dryomov , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 1/4] block: add a hard-readonly flag to struct gendisk X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Dec 02, 2020 at 11:04:33PM -0500, Martin K. Petersen wrote: > > Hi Christoph! > > > - If BLKROSET is used to set a whole-disk device read-only, any > > partitions will end up in a read-only state until the user > > explicitly clears the flag. > > This no longer appears to be the case with your tweak. True. > > It's very common for database folks to twiddle the read-only state of > block devices and partitions. I know that our users will find it very > counter-intuitive that setting /dev/sda read-only won't prevent writes > to /dev/sda1. What I'm worried about it is that this would be a huge change from the historic behavior. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel