From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kkntb-0000CX-E9 for mharc-grub-devel@gnu.org; Thu, 03 Dec 2020 07:39:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkntX-000091-Tn for grub-devel@gnu.org; Thu, 03 Dec 2020 07:39:37 -0500 Received: from dibed.net-space.pl ([84.10.22.86]:37217) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1kkntV-0004L6-3G for grub-devel@gnu.org; Thu, 03 Dec 2020 07:39:35 -0500 Received: from router-fw.i.net-space.pl ([192.168.52.1]:42174 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S143915AbgLCMj3 (ORCPT ); Thu, 3 Dec 2020 13:39:29 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Thu, 3 Dec 2020 13:39:26 +0100 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org, Patrick Steinhardt Subject: Re: [PATCH v6 02/12] luks2: Use more intuitive slot key instead of index in user messages. Message-ID: <20201203123926.fssu4c455wtzhqqr@tomti.i.net-space.pl> References: <3cd52834b9d76ed50720d64a0f05455e70dac0fb.1606467382.git.development@efficientek.com> <20201202172308.lqiigjxcf4wu4tnc@tomti.i.net-space.pl> <20201203012418.0aa8278f@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203012418.0aa8278f@crass-HP-ZBook-15-G2> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2020 12:39:37 -0000 On Thu, Dec 03, 2020 at 01:24:18AM -0600, Glenn Washburn wrote: > On Wed, 2 Dec 2020 18:23:08 +0100 > Daniel Kiper wrote: > > > On Fri, Nov 27, 2020 at 03:03:34AM -0600, Glenn Washburn wrote: > > > Use the slot key name in the json array rather than the 0 based > > > index in the json array for keyslots, segments, and digests. This > > > is less confusing for the end user. For example, say you have a > > > LUKS2 device with a key in slot 1 and slot 4. When using the > > > password for slot 4 to unlock the device, the messages using the > > > index of the keyslot will mention keyslot 1 (its a zero-based > > > index). Furthermore, with this change the keyslot number will align > > > with the number used to reference the keyslot when using the > > > --key-slot argument to cryptsetup. Error messages now distinguish > > > between indexes and slot keys. The former include the string > > > "index" in the error string, and the later are surrounded in quotes. > > > > This should be split into two separate patches. One should add "index" > > to the messages another should add quotes. Well, I am not convinced > > that quotes are good differentiators... I would drop them or rephrase > > messages to really differentiate indexes and slot keys. > > I thought the quotes would make more intuitive sense to a user because > the value would also be quoted in the json which would be output when > using cryptosetup with --debug-json. I can split it in to two patches, > but just tell me how you want me to rephrase and I will. No need for > another round of reviews. OK, let's stick with the quotes then. Daniel