From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F949C433FE for ; Fri, 4 Dec 2020 08:12:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7285B225A9 for ; Fri, 4 Dec 2020 08:12:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7285B225A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E8C76E134; Fri, 4 Dec 2020 08:12:04 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72EDC6E134 for ; Fri, 4 Dec 2020 08:12:03 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id r24so6476600lfm.8 for ; Fri, 04 Dec 2020 00:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=BUMYckdNXc2AgoK7KZmuMtqFktG5Sat51Ybj8L1C450=; b=G+aIVRCa0YPZ6Si9x86gPNFLJmlk8Pg9oDpYCt8XUfyiqZSqhyiUm6T2hUuWpxB1pR kKi0RQsqh5NurtXjj2bQxTsq0x2m8z2Yd4VfhQ2JNQRDpn3GvCbvSi64wM3ohXnkYHqF aZ1TDIMpaUe30IeqXRAAqWvFOsv/KBTicZvThkpg4ddX2dyc4nZZm1QC2FyL0gnn3Z5/ Op105mzPEyBJJ1VtSal+Q9F1X+bipV9euvNK7thj62ZqAoqWKTS63+Lp294hGil4KP2i ZLPRD1TAERQ/WUfFJSczG0g/SuGdSNdEobUzyq62AbbI66ZRtLjea6uORhFWeOWccFNj 82Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=BUMYckdNXc2AgoK7KZmuMtqFktG5Sat51Ybj8L1C450=; b=IZSO1s0/J6N65np5C0vOnqICwoEJ4MyA/VeagTcSEi3IzZDp/FpmzOVpii6mRhtBXr ZZGP8YvPj5xfHIEPHRtq7djMGMIhkqs5LqUBDM7vmXrZosNs6vEOh39QobUwysZFdKHn 6GtU3VCkKShs1fEs8BfXNuJ2fTjfctHTWnzoCq9K3gibcFv9VwBRoweG+6I6K5hyXxVw qDdYDqzjTeQKTWY/0WJi7C56AAgKKzAXAS6tWmDJr53NfQiRX+pelR+l2FByHz1+ePQG UpLoEzsBU9/uJJNv0TfHN9fsf0g/LDc1pbp76AAHwik47eTkUgqI9X7YjmKWtqEOnVyp G83A== X-Gm-Message-State: AOAM5306jySNzsyWLB+IefzqTJVjpgRDAbqngofLSiKlNZgihecT6NRe Uyg7fDkUkOvSjeS3wcbfjSs= X-Google-Smtp-Source: ABdhPJxGPo2Z1RAUJAMZyJLltyOJyrKN9cpT/3Jjdo0sEDLQ2chKNg7Yj5YbFyiyPH1Jy5zRhq5QjA== X-Received: by 2002:ac2:446f:: with SMTP id y15mr2884666lfl.415.1607069521822; Fri, 04 Dec 2020 00:12:01 -0800 (PST) Received: from eldfell ([194.136.85.206]) by smtp.gmail.com with ESMTPSA id v21sm1468229lfa.1.2020.12.04.00.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 00:12:01 -0800 (PST) Date: Fri, 4 Dec 2020 10:11:51 +0200 From: Pekka Paalanen To: Daniel Vetter Subject: Re: [PATCH] drm: Fix drm.h uapi header for Windows Message-ID: <20201204101151.55f487b8@eldfell> In-Reply-To: References: <1606816916-3724-1-git-send-email-jpark37@lagfreegames.com> <1606816916-3724-2-git-send-email-jpark37@lagfreegames.com> <2dbbc3dc-4df8-9ca4-4dce-808df0b24950@daenzer.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michel =?UTF-8?B?RMOkbnpl?= =?UTF-8?B?cg==?= , dri-devel , James Park , James Park Content-Type: multipart/mixed; boundary="===============1926994520==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1926994520== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/wq1la.68T1rXH/XrqTS7bf3"; protocol="application/pgp-signature" --Sig_/wq1la.68T1rXH/XrqTS7bf3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 3 Dec 2020 21:45:14 +0100 Daniel Vetter wrote: > On Thu, Dec 3, 2020 at 7:55 PM James Park w= rote: > > > > The trailing underscore for DRM_FOURCC_STANDALONE_ isn't > > intentional, right? Should I put all the integer types, or just the > > ones that are used in that file? =20 >=20 > Yeah that trailing _ just slipped in. And I'd just do the types > already used. I don't think anything else than __u32 (for drm fourcc) > and __u64 (for drm modifier) is needed. Hi, can that create conflicts if userspace first includes drm_fourcc.h and then drm.h? I would find it natural to userspace have generic headers including drm_fourcc.h and then DRM-specific C-files including drm.h as well (through libdrm headers). I think Weston might already do this. The generic userspace (weston) header would obviously #define DRM_FOURCC_STANDALONE, because it is used by non-DRM C-files as well. Thanks, pq --Sig_/wq1la.68T1rXH/XrqTS7bf3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAl/J70cACgkQI1/ltBGq qqerPA//aMgDYNIJ4sodrNOqSyvJ18uH96ST6BMNRiByVqcq2fjhsU3C+nWKWg5U vsHgMkCYbCp3wSUO9TRb9uhDMB0K8NyVDuzYZAt4HekHFPlF/USsFPvL1M85taDC +slkxDKk6gTuNxtTUhDlQAvSWxJy8Wl+Y0b0qcSY2NNtOQqaPcSF3iBLkEq+t/pC YSCaRC5fiBOkbcGehN2VXXoWMde+vRK19IDvAqS0VvgIR5eocn2hiX0BmPX5Pqh9 aRYOFTrdnS9w4wM0q2kMQ/ytZnbqhSGS0n+KJiNgou60e00P4rq5VyV1/heA0sMv 3rwxd//iVAz+/mtskmsQioCzeBB1OSOVMbbitYwYQzh3Y+6DLtS5j7/6OraCBQj4 S2SACrUZNCpYjhzHRl3tZS5WcjO/zR8o7JscPiIK9gZdpfw/0a3pbhP/QCka/+Xt WxWiL+MkupFCFNBhaNhIP3oaXzkr9Z4QzrqbQ+oiEPDNSDhL5Pip9FlgD1FVjSUN vqbBopNAP7TsXD1AqWXyvP2mk07C/GzAG2zF52JoKUmPTB0SQTNN1JKpAPW+ynTr +xzF/HmEuGS7UU8eC3XrFxMUNaqJ5zVh7Mkb9rvlQrICrpgisIGoaLBKy9ekPGgn SGMoeX1FxRcZPWOwdc0LLa1n4XV1rwiQas/+RqM2IBgngs8Lt9o= =+ndT -----END PGP SIGNATURE----- --Sig_/wq1la.68T1rXH/XrqTS7bf3-- --===============1926994520== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1926994520==--