From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448D4C4361A for ; Fri, 4 Dec 2020 11:23:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E846F22525 for ; Fri, 4 Dec 2020 11:23:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E846F22525 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.44490.79713 (Exim 4.92) (envelope-from ) id 1kl9Ay-0001SP-51; Fri, 04 Dec 2020 11:23:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 44490.79713; Fri, 04 Dec 2020 11:23:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kl9Ay-0001SI-1B; Fri, 04 Dec 2020 11:23:00 +0000 Received: by outflank-mailman (input) for mailman id 44490; Fri, 04 Dec 2020 11:22:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kl9Aw-0001S8-Ex for xen-devel@lists.xenproject.org; Fri, 04 Dec 2020 11:22:58 +0000 Received: from mail-wr1-f65.google.com (unknown [209.85.221.65]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d57d0a01-2d98-4f5e-87a5-cc8549f81204; Fri, 04 Dec 2020 11:22:57 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id p8so4962017wrx.5 for ; Fri, 04 Dec 2020 03:22:57 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id w15sm3149831wrp.52.2020.12.04.03.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 03:22:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d57d0a01-2d98-4f5e-87a5-cc8549f81204 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/C1k3MYuUx3p+eH57DxvaQx/eTuPkAfziW3cYF7b8P8=; b=EuYPVdfcZVHQ4gdsDd2SuNBWPRqxnboAmlBmanvUnutyMQOVtaD9ybL/APmZCHyt/M rcQNQ4nXMrUoMeV2SG2E/l9DzkXutovsFaPI6+tYNmDebtLRa8/2gLT39dI9wxU0Wu4q FeFrE1kJhPzfCbj3akfaEEJdknJ9hWuwAm21oAvegiAerdDOG8KzEDjZYoCAmpj4KUpl KksbmSebJgibQePThWwjlhV7ATbAb4MWx9wXjyRBz2s/+AYyxYUx0ng8bo7X0p6r2OTN PPw6D8lDVr7v92bmi2mpIZiuQyh9gYHQt813FCK3YPZKwyTTxszMm3Kep0vgFYicUqGf yv/g== X-Gm-Message-State: AOAM533X1/LJ+uFQZYk1DHhPNUvnrTqP3GSX0aHLThOJvutIEnxjuul9 pHvgTJ1mMkNXKF9gUQAcipE= X-Google-Smtp-Source: ABdhPJxqmdNPve4AUlGSPQ1ru0WCIQrbGe051mC2cxWGHbTxd9ipy5194eamfvBhsV+O6C7MXzZb1w== X-Received: by 2002:a5d:570d:: with SMTP id a13mr4442508wrv.193.1607080976614; Fri, 04 Dec 2020 03:22:56 -0800 (PST) Date: Fri, 4 Dec 2020 11:22:54 +0000 From: Wei Liu To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Paul Durrant , Oleksandr Andrushchenko , Ian Jackson , Wei Liu Subject: Re: [PATCH v5 09/23] libxl: remove unnecessary check from libxl__device_pci_add() Message-ID: <20201204112254.fjdfb4esxrb3wiil@liuwe-devbox-debian-v2> References: <20201203142534.4017-1-paul@xen.org> <20201203142534.4017-10-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203142534.4017-10-paul@xen.org> User-Agent: NeoMutt/20180716 On Thu, Dec 03, 2020 at 02:25:20PM +0000, Paul Durrant wrote: > From: Paul Durrant > > The code currently checks explicitly whether the device is already assigned, > but this is actually unnecessary as assigned devices do not form part of > the list returned by libxl_device_pci_assignable_list() and hence the > libxl_pci_assignable() test would have already failed. > > Signed-off-by: Paul Durrant > Reviewed-by: Oleksandr Andrushchenko Acked-by: Wei Liu