Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

[Jakub Kicinski <kuba@kernel.org>]

On Wed,  2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Thanks for the patches. Please drop the "metux IT consult" from the
addresses. The from space is supposed to be for your name.

> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..683e9e825b9e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -36,15 +36,10 @@
>  #include "vlan.h"
>  #include "vlanproc.h"
>  
> -#define DRV_VERSION "1.8"
> -
>  /* Global VLAN variables */
>  
>  unsigned int vlan_net_id __read_mostly;
>  
> -const char vlan_fullname[] = "802.1Q VLAN Support";
> -const char vlan_version[] = DRV_VERSION;

This patches does not build. Please redo it more carefully.

You'll need to fix and resend the entire series. When you do so please
provide a cover letter, even if it only contains a couple of sentences
and separate the patches for bluetooth and batman-adv out as stand
alone patches, so the respective maintainers can pick them up.