All of lore.kernel.org
 help / color / mirror / Atom feed
* + initramfs-fix-clang-build-failure.patch added to -mm tree
@ 2020-12-05  0:35 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2020-12-05  0:35 UTC (permalink / raw)
  To: arnd, brho, mm-commits, natechancellor, ndesaulniers


The patch titled
     Subject: initramfs: fix clang build failure
has been added to the -mm tree.  Its filename is
     initramfs-fix-clang-build-failure.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/initramfs-fix-clang-build-failure.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/initramfs-fix-clang-build-failure.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Arnd Bergmann <arnd@arndb.de>
Subject: initramfs: fix clang build failure

There is only one function in init/initramfs.c that is in the .text
section, and it is marked __weak.  When building with clang-12 and the
integrated assembler, this leads to a bug with recordmcount:

./scripts/recordmcount  "init/initramfs.o"
Cannot find symbol for section 2: .text.
init/initramfs.o: failed

I'm not quite sure what exactly goes wrong, but I notice that this
function is only ever called from an __init function, and normally
inlined.  Marking it __init as well is clearly correct and it leads to
recordmcount no longer complaining.

Link: https://lkml.kernel.org/r/20201204165742.3815221-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Barret Rhoden <brho@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 init/initramfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/init/initramfs.c~initramfs-fix-clang-build-failure
+++ a/init/initramfs.c
@@ -535,7 +535,7 @@ extern unsigned long __initramfs_size;
 #include <linux/initrd.h>
 #include <linux/kexec.h>
 
-void __weak free_initrd_mem(unsigned long start, unsigned long end)
+void __weak __init free_initrd_mem(unsigned long start, unsigned long end)
 {
 #ifdef CONFIG_ARCH_KEEP_MEMBLOCK
 	unsigned long aligned_start = ALIGN_DOWN(start, PAGE_SIZE);
_

Patches currently in -mm which might be from arnd@arndb.de are

selftest-fpu-avoid-clang-warning.patch
kbuild-avoid-static_assert-for-genksyms.patch
initramfs-fix-clang-build-failure.patch
elfcore-fix-building-with-clang.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-05  0:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-05  0:35 + initramfs-fix-clang-build-failure.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.