[failures] mm-memblock-use-a-more-appropriate-order-calculation-when-free-memblock-pages.patch removed from -mm tree

* [failures] mm-memblock-use-a-more-appropriate-order-calculation-when-free-memblock-pages.patch removed from -mm tree
@ 2020-12-05  0:59 akpm
  2020-12-06 20:51 ` Stephen Rothwell
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2020-12-05  0:59 UTC (permalink / raw)
  To: jonathanh, liu.hailong6, m.szyprowski, mm-commits, qcai, rppt, sfr


The patch titled
     Subject: mm/memblock: use a more appropriate order calculation when free memblock pages
has been removed from the -mm tree.  Its filename was
     mm-memblock-use-a-more-appropriate-order-calculation-when-free-memblock-pages.patch

This patch was dropped because it had testing failures

------------------------------------------------------
From: Hailong Liu <liu.hailong6@zte.com.cn>
Subject: mm/memblock: use a more appropriate order calculation when free memblock pages

When system in the booting stage, pages span from [start, end] of a
memblock are freed to buddy in a order as large as possible (less than
MAX_ORDER) at first, then decrease gradually to a proper order(less than
end) in a loop.

However, *min(MAX_ORDER - 1UL, __ffs(start))* can not get the largest
order in some cases.  Instead, *__ffs(end - start)* may be more
appropriate and meaningful.

Link: https://lkml.kernel.org/r/20201203152311.5272-1-carver4lio@163.com
Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Qian Cai <qcai@redhat.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/memblock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/memblock.c~mm-memblock-use-a-more-appropriate-order-calculation-when-free-memblock-pages
+++ a/mm/memblock.c
@@ -2010,7 +2010,7 @@ static void __init __free_pages_memory(u
 	int order;
 
 	while (start < end) {
-		order = min(MAX_ORDER - 1UL, __ffs(start));
+		order = min(MAX_ORDER - 1UL, __ffs(end - start));
 
 		while (start + (1UL << order) > end)
 			order--;
_

Patches currently in -mm which might be from liu.hailong6@zte.com.cn are



^ permalink raw reply	[flat|nested] 2+ messages in thread