From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7096AC433FE for ; Sat, 5 Dec 2020 06:09:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A83222D50 for ; Sat, 5 Dec 2020 06:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbgLEGJV (ORCPT ); Sat, 5 Dec 2020 01:09:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbgLEGJV (ORCPT ); Sat, 5 Dec 2020 01:09:21 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A462C061A4F for ; Fri, 4 Dec 2020 22:08:41 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id e23so4876988pgk.12 for ; Fri, 04 Dec 2020 22:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KyCltGo5Jh+2iRWxe0Q7oC+kYFctDXgmC6IuBeRcK5k=; b=yRdoGg3CcSs/UppaG2EdVs9NHQeHdSZGv4HNg+4XYZF4vRNG2plcNU9F+BsrBcy2Eg +aCzwKc3D5wc53CoPzn6j9ujqNu5KVvp+fyBDasjyuDn3GcODGbZB8ugXaE/tlZ8/qXh cT8qbYq92aIms6eCIDpp+o+7aQbB6bcy2B12p6BQsOOef8MnptTc01JKCnUqq/ySIOAD UqDfs9PnRHPJMf586NPY0Xf0ixadWdsXjOG5jAdAIxpa8t3QBrD572GiiJvMPZAnovBA jrNglt54qPeS+IXHLgP6NgbieCF/dcIT3WQTaTF7tvNvJ5Nnjamd15nCnyDNCIYOw7IJ lydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KyCltGo5Jh+2iRWxe0Q7oC+kYFctDXgmC6IuBeRcK5k=; b=Br+to0U3SZMXyyaqmNGyIdyUMfI3tDVM6xWkEO8TdRXhvFh3qoCo0IXQpa+lCJrKxu iqbLN7Pu0RdRQmAnQ9pRuPIzYyopX1TmpNFD1/o2R0MEz06ZQf1//ymyYo2qhEU+pK7R vOozzCPmjeAFQo8kSprudq9HU06TJrqXlYu7oH7NxsEl+bDw4y9VyECYaw+GCx2e0BSU MzfK5KSpVNjufdor2fmixX1SuQRX5ddFQtNN8FvG6sSzpXY7L8brxZo/8UflMhOvM2Cw FRfTbe4Ma8WrQSzn3j0SHvBXQztCUIKmlVTahiJJOw/AE3VDJ+FvVcEOA721kmBeyoBy ocTQ== X-Gm-Message-State: AOAM5333Oqq7WmCuleD6O17c21lTOxBfLYNUWHCkw7ajwbX6+Y22TK9t NgzlwusJrWwuIMZpbwKwjrnH X-Google-Smtp-Source: ABdhPJwgqYSKX9/t+x42f5dD9qUaRlQ86l6l2+sMNxDOx43O7XkVzMyQhapssOtj1pRzRiXvd/IoOg== X-Received: by 2002:a63:1b11:: with SMTP id b17mr10315665pgb.1.1607148520425; Fri, 04 Dec 2020 22:08:40 -0800 (PST) Received: from thinkpad ([2409:4072:648e:8bd1:74b2:a4d8:e3fe:225b]) by smtp.gmail.com with ESMTPSA id m18sm7119878pff.144.2020.12.04.22.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 22:08:39 -0800 (PST) Date: Sat, 5 Dec 2020 11:38:31 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Vinod Koul , Dan Williams , Andreas =?iso-8859-1?Q?F=E4rber?= , Rob Herring , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Message-ID: <20201205060831.GA4068@thinkpad> References: <20201128073045.GU3077@thinkpad> <20201129182421.GD696261@BV030612LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201129182421.GD696261@BV030612LT> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Sun, Nov 29, 2020 at 08:24:21PM +0200, Cristian Ciocaltea wrote: > On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote: > > > The DMA controller present on the Actions Semi S500 SoC is compatible > > > with the S900 variant, so add it to the list of devices supported by > > > the Actions Semi Owl DMA driver. > > > > > > Signed-off-by: Cristian Ciocaltea > > > > I hope that you have verified both Memcpy and Slave transfers... > > I have been using 'dmatest' module as documented in: > https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html > > I tested all the available channels and could not find any signs of > possible issues. Bellow is an excerpt from the kernel ring buffer: > > [ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0) > [ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0) > [ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0) > > Should I perform some additional tests? > Nope, this is sufficient. Since you have tested slave transfer with MMC driver, running dmatest for memcpy is fine. Thanks, Mani > Thanks, > Cristi > > > Reviewed-by: Manivannan Sadhasivam > > > > Thanks, > > Mani > > > > > --- > > > drivers/dma/owl-dma.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > > > index 9fede32641e9..54e509de66e2 100644 > > > --- a/drivers/dma/owl-dma.c > > > +++ b/drivers/dma/owl-dma.c > > > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec, > > > static const struct of_device_id owl_dma_match[] = { > > > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,}, > > > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,}, > > > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,}, > > > { /* sentinel */ }, > > > }; > > > MODULE_DEVICE_TABLE(of, owl_dma_match); > > > -- > > > 2.29.2 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E558FC433FE for ; Sat, 5 Dec 2020 06:10:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9722A22D3E for ; Sat, 5 Dec 2020 06:10:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9722A22D3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dPMt61+YavxJ509BQU9u2T2wfL6b5YhhBzA+SzfjZSI=; b=xiVfQdWHMNl+9mfhbPfH7XXb/ n5POeGzPxnhdhH3wo3/3qf+C6N6fY1kAfLMJ/sh4A0pLVhwxPPq0WazgxMZtgK0j7I/YOzejAD8fi k4blmqCuYXk427Bek1YyweUzuIx73HKqGsUauzUKbgBU7UzCxNG0Euhkz1JpLqBChLeFU9vK/TyPm sZuWgMRhc1F7IuQeAI8zKH4Gg+8uLkfpPkqinfUF/RWdAXByTXpuLtdCSbMn/38LP+qINOKF+372S 9ielGeCvU5wV6HrYZtRpcsUVjyrQwx0lJTgv86M593AKG2MweVyI5ANka0KZFOswG8qUns/CFv6Py 6svSkXVIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klQkQ-000750-6L; Sat, 05 Dec 2020 06:08:46 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klQkN-00074F-1E for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 06:08:44 +0000 Received: by mail-pg1-x541.google.com with SMTP id n7so4909678pgg.2 for ; Fri, 04 Dec 2020 22:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KyCltGo5Jh+2iRWxe0Q7oC+kYFctDXgmC6IuBeRcK5k=; b=yRdoGg3CcSs/UppaG2EdVs9NHQeHdSZGv4HNg+4XYZF4vRNG2plcNU9F+BsrBcy2Eg +aCzwKc3D5wc53CoPzn6j9ujqNu5KVvp+fyBDasjyuDn3GcODGbZB8ugXaE/tlZ8/qXh cT8qbYq92aIms6eCIDpp+o+7aQbB6bcy2B12p6BQsOOef8MnptTc01JKCnUqq/ySIOAD UqDfs9PnRHPJMf586NPY0Xf0ixadWdsXjOG5jAdAIxpa8t3QBrD572GiiJvMPZAnovBA jrNglt54qPeS+IXHLgP6NgbieCF/dcIT3WQTaTF7tvNvJ5Nnjamd15nCnyDNCIYOw7IJ lydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KyCltGo5Jh+2iRWxe0Q7oC+kYFctDXgmC6IuBeRcK5k=; b=Nf7KKjOTFnND5fR787STeL/d1Cber65hRQY38tlJAFR1xrdpNKRvjTP7EJTLvFTWbU +Yemt/kOFUqxUUcTeSBScivWPom0efCtTeGniJo7Goj/sPpi27wDkwq/J+0sz8Ea26Aj 0U4pYpzUu6+WBRqPMyuAG13x5KcPsmjefeHj4Nv/j1/evl08rtgIfO5zhc/7u9KO2GFF KY7rRVsCG2nWJES2D7vtDJ6mEKyBF6wMbWs1fliPFFR2Du/MOWR3tDyPTFxgNBiPwVeR Kvi5Ghmw7TUi4TrHgg49HZb3V98vweMp3L+l16DCN8dSjHKtig1r1wi7qkLGLf6QMKgE /Z5Q== X-Gm-Message-State: AOAM531b6Fn1yrmLP0h7Fkf4k5ruAJ4wx5cRHBpyYrj/KPr/ke6Nqt2j PuwLDkU3/moPWcsrV6FClmr6 X-Google-Smtp-Source: ABdhPJwgqYSKX9/t+x42f5dD9qUaRlQ86l6l2+sMNxDOx43O7XkVzMyQhapssOtj1pRzRiXvd/IoOg== X-Received: by 2002:a63:1b11:: with SMTP id b17mr10315665pgb.1.1607148520425; Fri, 04 Dec 2020 22:08:40 -0800 (PST) Received: from thinkpad ([2409:4072:648e:8bd1:74b2:a4d8:e3fe:225b]) by smtp.gmail.com with ESMTPSA id m18sm7119878pff.144.2020.12.04.22.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 22:08:39 -0800 (PST) Date: Sat, 5 Dec 2020 11:38:31 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Subject: Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Message-ID: <20201205060831.GA4068@thinkpad> References: <20201128073045.GU3077@thinkpad> <20201129182421.GD696261@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201129182421.GD696261@BV030612LT> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_010843_172290_D0C80FB1 X-CRM114-Status: GOOD ( 23.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Vinod Koul , Rob Herring , dmaengine@vger.kernel.org, Dan Williams , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 29, 2020 at 08:24:21PM +0200, Cristian Ciocaltea wrote: > On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote: > > > The DMA controller present on the Actions Semi S500 SoC is compatible > > > with the S900 variant, so add it to the list of devices supported by > > > the Actions Semi Owl DMA driver. > > > > > > Signed-off-by: Cristian Ciocaltea > > > > I hope that you have verified both Memcpy and Slave transfers... > > I have been using 'dmatest' module as documented in: > https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html > > I tested all the available channels and could not find any signs of > possible issues. Bellow is an excerpt from the kernel ring buffer: > > [ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0) > [ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0) > [ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0) > > Should I perform some additional tests? > Nope, this is sufficient. Since you have tested slave transfer with MMC driver, running dmatest for memcpy is fine. Thanks, Mani > Thanks, > Cristi > > > Reviewed-by: Manivannan Sadhasivam > > > > Thanks, > > Mani > > > > > --- > > > drivers/dma/owl-dma.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > > > index 9fede32641e9..54e509de66e2 100644 > > > --- a/drivers/dma/owl-dma.c > > > +++ b/drivers/dma/owl-dma.c > > > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec, > > > static const struct of_device_id owl_dma_match[] = { > > > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,}, > > > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,}, > > > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,}, > > > { /* sentinel */ }, > > > }; > > > MODULE_DEVICE_TABLE(of, owl_dma_match); > > > -- > > > 2.29.2 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel