From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD09C4361A for ; Sat, 5 Dec 2020 18:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F66622E03 for ; Sat, 5 Dec 2020 18:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgLESEQ (ORCPT ); Sat, 5 Dec 2020 13:04:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:44884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728178AbgLESAi (ORCPT ); Sat, 5 Dec 2020 13:00:38 -0500 Date: Sat, 5 Dec 2020 09:59:48 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607191189; bh=2XTj98FPwKYrzmdgVAroyFbBlTDM4KyJc/G+XYx1L5s=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=frCgoLvdzjdFmwlMnLFXg2EUZK1aRpWGIxlunb2Yx0PduLElndrQvqORfyMbcZjOY sA9u7JB/BbqjGMmWfSlHvzTfuaHo4ffWPpUsFsoskWCcjmrF/BYSL+n0ZpRnsZ84I1 AXu/7TgwP3/kiOWws2ZiPPHQBV7lzPs5PCujv3IBlUOAsF155AKtB+Ny2sy1wPcAQa 4vC/DK9p6mCU63qbakVs9iQh6l1Gg/N/ZbcFqczrYkFD330x1sn+sk5M3XOMhFIHBs 4R0snzIEAY6bW0JT1EVc55C+R8uX42sZU95qU/1ZyZER29WztsTZwKkNIyXBTKX1QC YIJx3ks2ohP/w== From: Jakub Kicinski To: Vinicius Costa Gomes Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, m-karicheri2@ti.com, vladimir.oltean@nxp.com, Jose.Abreu@synopsys.com, po.liu@nxp.com, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com Subject: Re: [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers Message-ID: <20201205095948.5e0eba28@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201202045325.3254757-9-vinicius.gomes@intel.com> References: <20201202045325.3254757-1-vinicius.gomes@intel.com> <20201202045325.3254757-9-vinicius.gomes@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 1 Dec 2020 20:53:24 -0800 Vinicius Costa Gomes wrote: > Expose the Frame Preemption counters, so the number of > express/preemptible packets can be monitored by userspace. > > These registers are cleared when read, so the value shown is the > number of events that happened since the last read. > > Signed-off-by: Vinicius Costa Gomes You mean expose in a register dump? That's not great user experience.. Are there any stats that the standards mandate? It'd be great if we could come up with some common set and expose them via ethtool like the pause frame statistics. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Sat, 5 Dec 2020 09:59:48 -0800 Subject: [Intel-wired-lan] [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers In-Reply-To: <20201202045325.3254757-9-vinicius.gomes@intel.com> References: <20201202045325.3254757-1-vinicius.gomes@intel.com> <20201202045325.3254757-9-vinicius.gomes@intel.com> Message-ID: <20201205095948.5e0eba28@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, 1 Dec 2020 20:53:24 -0800 Vinicius Costa Gomes wrote: > Expose the Frame Preemption counters, so the number of > express/preemptible packets can be monitored by userspace. > > These registers are cleared when read, so the value shown is the > number of events that happened since the last read. > > Signed-off-by: Vinicius Costa Gomes You mean expose in a register dump? That's not great user experience.. Are there any stats that the standards mandate? It'd be great if we could come up with some common set and expose them via ethtool like the pause frame statistics.