From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4351EC4361B for ; Sat, 5 Dec 2020 20:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BC7423106 for ; Sat, 5 Dec 2020 20:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbgLEUtl (ORCPT ); Sat, 5 Dec 2020 15:49:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:53440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEUtl (ORCPT ); Sat, 5 Dec 2020 15:49:41 -0500 Date: Sat, 5 Dec 2020 12:48:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607201340; bh=Z/co9+Pvv4I2LEXBmRkaa+SbLCbOTc8rgFmjC1Xh5BE=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=b5YMJNMCZCfyg5q1n2W38CE2FJV1cE/SGuJQswCsFwAHd2DZZuSwp96xp+6VFOO5H +0NENDzKlpibTPJOLOIputW6E1ygv8HL009zzQqLN7KRildM1ok2bWEcKCiNWWNmLi BeUdnTEBQQNXrZx1kgjBXiP6dD9/m0OXJyEC8BUDxmrUJIdZG64C1ccMPNAwTYdXmj rjWSftpNvlepD/9lW0YGcfl8jiKhmxeyL5WyvMds9a95Wp/4gkCYQsbPUft7i8agE9 8ElUQIUu2NO0tzKtBdW7UqswCC7+tjGIWimSTGgyIEm/SAi4yYJlnY+COwrxod9c/x XRqQSevUDRDNQ== From: Jakub Kicinski To: Rasmus Villemoes Cc: Li Yang , "David S. Miller" , Zhao Qiang , Vladimir Oltean , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove() Message-ID: <20201205124859.60d045e6@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205191744.7847-12-rasmus.villemoes@prevas.dk> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> <20201205191744.7847-12-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote: > - unregister_netdev(dev); > - free_netdev(dev); > ucc_geth_memclean(ugeth); > if (of_phy_is_fixed_link(np)) > of_phy_deregister_fixed_link(np); > of_node_put(ugeth->ug_info->tbi_node); > of_node_put(ugeth->ug_info->phy_node); > + unregister_netdev(dev); > + free_netdev(dev); Are you sure you want to move the unregister_netdev() as well as the free? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375D1C4361A for ; Sat, 5 Dec 2020 20:52:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89054230F9 for ; Sat, 5 Dec 2020 20:52:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89054230F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CpMGQ1wyfzDqjg for ; Sun, 6 Dec 2020 07:52:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=b5YMJNMC; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CpMB76pmkzDqhS for ; Sun, 6 Dec 2020 07:49:03 +1100 (AEDT) Date: Sat, 5 Dec 2020 12:48:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607201340; bh=Z/co9+Pvv4I2LEXBmRkaa+SbLCbOTc8rgFmjC1Xh5BE=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=b5YMJNMCZCfyg5q1n2W38CE2FJV1cE/SGuJQswCsFwAHd2DZZuSwp96xp+6VFOO5H +0NENDzKlpibTPJOLOIputW6E1ygv8HL009zzQqLN7KRildM1ok2bWEcKCiNWWNmLi BeUdnTEBQQNXrZx1kgjBXiP6dD9/m0OXJyEC8BUDxmrUJIdZG64C1ccMPNAwTYdXmj rjWSftpNvlepD/9lW0YGcfl8jiKhmxeyL5WyvMds9a95Wp/4gkCYQsbPUft7i8agE9 8ElUQIUu2NO0tzKtBdW7UqswCC7+tjGIWimSTGgyIEm/SAi4yYJlnY+COwrxod9c/x XRqQSevUDRDNQ== From: Jakub Kicinski To: Rasmus Villemoes Subject: Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove() Message-ID: <20201205124859.60d045e6@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205191744.7847-12-rasmus.villemoes@prevas.dk> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> <20201205191744.7847-12-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Oltean , linux-kernel@vger.kernel.org, Li Yang , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Zhao Qiang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote: > - unregister_netdev(dev); > - free_netdev(dev); > ucc_geth_memclean(ugeth); > if (of_phy_is_fixed_link(np)) > of_phy_deregister_fixed_link(np); > of_node_put(ugeth->ug_info->tbi_node); > of_node_put(ugeth->ug_info->phy_node); > + unregister_netdev(dev); > + free_netdev(dev); Are you sure you want to move the unregister_netdev() as well as the free?