From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF848C4361A for ; Sat, 5 Dec 2020 20:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6798323106 for ; Sat, 5 Dec 2020 20:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgLEUyd (ORCPT ); Sat, 5 Dec 2020 15:54:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:54570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEUyc (ORCPT ); Sat, 5 Dec 2020 15:54:32 -0500 Date: Sat, 5 Dec 2020 12:53:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607201632; bh=uUWQNjkzP7jsDA3hiG3fn47VNCNDg6puRbpmbUSoqew=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=XjLCieWXIm6u9BddBMaTSLjRjSBqYozZZtAuX4WYNSgGOXBggGw8bQpNXPv4mCFkx aJVrWlp0Y4044T/EwN1cyjYjsHfe5S48jhYbjkX3GjJLoA5akyMU8ZYn7fEJC46TFL oNf8l5w+376M2S+L39d1/Jv9YsOyH8omIEnsPi3A3YGfXdIp3z1IJsAuXlWIPpsDoh Yov5Hh5MsUQZih8EIlQ6fKakYy5AWIwEwp6mXeENpv/0PQtHfojcpfz+AcbS3viH89 vUV7ZsgC0V3/fyF6A309vg4zjwek9xtHUpT38hiYneb7CVmvwOnQsCI36tZkRqMJEO /rMzuG1EiWr7A== From: Jakub Kicinski To: Rasmus Villemoes Cc: Li Yang , "David S. Miller" , Qiang Zhao , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vladimir Oltean Subject: Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications Message-ID: <20201205125351.41e89579@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > While trying to figure out how to allow bumping the MTU with the > ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > bunch of issues of varying importance - some are outright bug fixes, > while most are a matter of simplifying the code to make it more > accessible. > > At the end of digging around the code and data sheet to figure out how > it all works, I think the MTU issue might be fixed by a one-liner, but > I'm not sure it can be that simple. It does seem to work (ping -s X > works for larger values of X, and wireshark confirms that the packets > are not fragmented). > > Re patch 2, someone in NXP should check how the hardware actually > works and make an updated reference manual available. Looks like a nice clean up on a quick look. Please separate patches 1 and 11 (which are the two bug fixes I see) rebase (retest) and post them against the net tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ so they are available for backports. The reset should go into net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Please indicate the tree in the tag like [PATCH net] or [PATCH net-next] so the test bots know which base to use for testing. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E82BC4361A for ; Sat, 5 Dec 2020 20:58:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B45A523106 for ; Sat, 5 Dec 2020 20:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B45A523106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CpMNg1WpDzDqLJ for ; Sun, 6 Dec 2020 07:58:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XjLCieWX; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CpMHl0ztlzDqKD for ; Sun, 6 Dec 2020 07:53:54 +1100 (AEDT) Date: Sat, 5 Dec 2020 12:53:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607201632; bh=uUWQNjkzP7jsDA3hiG3fn47VNCNDg6puRbpmbUSoqew=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=XjLCieWXIm6u9BddBMaTSLjRjSBqYozZZtAuX4WYNSgGOXBggGw8bQpNXPv4mCFkx aJVrWlp0Y4044T/EwN1cyjYjsHfe5S48jhYbjkX3GjJLoA5akyMU8ZYn7fEJC46TFL oNf8l5w+376M2S+L39d1/Jv9YsOyH8omIEnsPi3A3YGfXdIp3z1IJsAuXlWIPpsDoh Yov5Hh5MsUQZih8EIlQ6fKakYy5AWIwEwp6mXeENpv/0PQtHfojcpfz+AcbS3viH89 vUV7ZsgC0V3/fyF6A309vg4zjwek9xtHUpT38hiYneb7CVmvwOnQsCI36tZkRqMJEO /rMzuG1EiWr7A== From: Jakub Kicinski To: Rasmus Villemoes Subject: Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications Message-ID: <20201205125351.41e89579@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Li Yang , Vladimir Oltean , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > While trying to figure out how to allow bumping the MTU with the > ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > bunch of issues of varying importance - some are outright bug fixes, > while most are a matter of simplifying the code to make it more > accessible. > > At the end of digging around the code and data sheet to figure out how > it all works, I think the MTU issue might be fixed by a one-liner, but > I'm not sure it can be that simple. It does seem to work (ping -s X > works for larger values of X, and wireshark confirms that the packets > are not fragmented). > > Re patch 2, someone in NXP should check how the hardware actually > works and make an updated reference manual available. Looks like a nice clean up on a quick look. Please separate patches 1 and 11 (which are the two bug fixes I see) rebase (retest) and post them against the net tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ so they are available for backports. The reset should go into net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Please indicate the tree in the tag like [PATCH net] or [PATCH net-next] so the test bots know which base to use for testing. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BAEC4361A for ; Sat, 5 Dec 2020 20:55:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33BA5230F9 for ; Sat, 5 Dec 2020 20:55:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33BA5230F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JPmIu46QduSu5L9XgadwdqocNDsJVHnsf5KA4+iRR+A=; b=TE6OUcJVw/hUfB3Fqs75p8TC1 nfjaDsfzxotCvbYGxtHr5WKC8RMJqb0fi3fBcxj8ULTQogLuiBfNcnPulUuhC/DMhwqvtjK0u5VCA 5yHz4wCli6pHdC1dztRJb2SOGITRzj+a85AKSBmfK9BvHnBZZF3n61fkJclLgmA6U6/xi8yAMIKhc lPOQj9Bz/geBSvvHaL/ZdpgAZoFqvin7CJIwWg0V3wc0Zi/mjTowqY4M3JazZuKEoNrtZxA6SzLfI E21q0ZqMoudZY2mQKQaCS28IumfiN+PyoMzvhA9LTYKLXM4uLNhxKEQAqwgjTnWUacXJcXhYaqhbU OheJYDLBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kleZ3-0003A6-Ml; Sat, 05 Dec 2020 20:53:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kleZ0-00039e-T8 for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 20:53:55 +0000 Date: Sat, 5 Dec 2020 12:53:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607201632; bh=uUWQNjkzP7jsDA3hiG3fn47VNCNDg6puRbpmbUSoqew=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=XjLCieWXIm6u9BddBMaTSLjRjSBqYozZZtAuX4WYNSgGOXBggGw8bQpNXPv4mCFkx aJVrWlp0Y4044T/EwN1cyjYjsHfe5S48jhYbjkX3GjJLoA5akyMU8ZYn7fEJC46TFL oNf8l5w+376M2S+L39d1/Jv9YsOyH8omIEnsPi3A3YGfXdIp3z1IJsAuXlWIPpsDoh Yov5Hh5MsUQZih8EIlQ6fKakYy5AWIwEwp6mXeENpv/0PQtHfojcpfz+AcbS3viH89 vUV7ZsgC0V3/fyF6A309vg4zjwek9xtHUpT38hiYneb7CVmvwOnQsCI36tZkRqMJEO /rMzuG1EiWr7A== From: Jakub Kicinski To: Rasmus Villemoes Subject: Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications Message-ID: <20201205125351.41e89579@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> References: <20201205191744.7847-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_155355_060997_136D39E6 X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Li Yang , Vladimir Oltean , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org, Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > While trying to figure out how to allow bumping the MTU with the > ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > bunch of issues of varying importance - some are outright bug fixes, > while most are a matter of simplifying the code to make it more > accessible. > > At the end of digging around the code and data sheet to figure out how > it all works, I think the MTU issue might be fixed by a one-liner, but > I'm not sure it can be that simple. It does seem to work (ping -s X > works for larger values of X, and wireshark confirms that the packets > are not fragmented). > > Re patch 2, someone in NXP should check how the hardware actually > works and make an updated reference manual available. Looks like a nice clean up on a quick look. Please separate patches 1 and 11 (which are the two bug fixes I see) rebase (retest) and post them against the net tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ so they are available for backports. The reset should go into net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Please indicate the tree in the tag like [PATCH net] or [PATCH net-next] so the test bots know which base to use for testing. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel