From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35336C4361B for ; Sun, 6 Dec 2020 21:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 760BC22581 for ; Sun, 6 Dec 2020 21:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbgLFVtG (ORCPT ); Sun, 6 Dec 2020 16:49:06 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:39320 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727427AbgLFVtF (ORCPT ); Sun, 6 Dec 2020 16:49:05 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 0BE65804EF; Sun, 6 Dec 2020 22:48:15 +0100 (CET) Date: Sun, 6 Dec 2020 22:48:14 +0100 From: Sam Ravnborg To: kernel test robot Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , kbuild-all@lists.01.org, Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Message-ID: <20201206214814.GA1884161@ravnborg.org> References: <20201206190247.1861316-6-sam@ravnborg.org> <202012070518.yJA9Vbbo-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Itgwjo3g c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=QyXUC8HyAAAA:8 a=KKAkSRfTAAAA:8 a=hAG5_4vcAAAA:8 a=VwQbUJbxAAAA:8 a=yC-0_ovQAAAA:8 a=JfrnYn6hAAAA:8 a=Z4Rwk6OoAAAA:8 a=kDhuXSaoqpb3RoiJoOIA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 a=8Bh8Pg2EFav9IBZ9i9Tn:22 a=AjGcO6oz07-iQ99wixmX:22 a=1CNFftbPRP8L7MoqJWF3:22 a=HkZW87K1Qel5hWWM3VKY:22 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org commit aa1f4345b5480502a4e61addf5c59d606fdbce8f Author: Sam Ravnborg Date: Mon Nov 30 22:09:29 2020 +0100 sh: Fix set but not used warnings with !CONFIG_MMU Building fbdev drivers for sh with W=1 produces the following warning: tmiofb.c: In function ‘tmiofb_remove’: tmiofb.c:805:21: warning: variable ‘par’ set but not used This is with allmodconfig and ARCH=sh This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used. v4: - Fix build error of ethernet driver (kernel test robot) Added missing () around macro parameter Signed-off-by: Sam Ravnborg Cc: kernel test robot Cc: Thomas Zimmermann Cc: Lee Jones Cc: Rich Felker Cc: Arnd Bergmann Cc: Geert Uytterhoeven Cc: Mike Rapoport Cc: Kuninori Morimoto Cc: Peter Zijlstra Cc: Sam Ravnborg Cc: Andrew Morton diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index 6d5c6463bc07..45082bcbd9aa 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size, #endif /* CONFIG_HAVE_IOREMAP_PROT */ #else /* CONFIG_MMU */ -#define iounmap(addr) do { } while (0) +#define iounmap(addr) do { (void)(addr); } while (0) #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) #endif /* CONFIG_MMU */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD53C4361B for ; Sun, 6 Dec 2020 21:48:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 532A1230FD for ; Sun, 6 Dec 2020 21:48:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 532A1230FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCB1D89D6C; Sun, 6 Dec 2020 21:48:20 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A905F89D6C for ; Sun, 6 Dec 2020 21:48:19 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 0BE65804EF; Sun, 6 Dec 2020 22:48:15 +0100 (CET) Date: Sun, 6 Dec 2020 22:48:14 +0100 From: Sam Ravnborg To: kernel test robot Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Message-ID: <20201206214814.GA1884161@ravnborg.org> References: <20201206190247.1861316-6-sam@ravnborg.org> <202012070518.yJA9Vbbo-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Itgwjo3g c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=QyXUC8HyAAAA:8 a=KKAkSRfTAAAA:8 a=hAG5_4vcAAAA:8 a=VwQbUJbxAAAA:8 a=yC-0_ovQAAAA:8 a=JfrnYn6hAAAA:8 a=Z4Rwk6OoAAAA:8 a=kDhuXSaoqpb3RoiJoOIA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 a=8Bh8Pg2EFav9IBZ9i9Tn:22 a=AjGcO6oz07-iQ99wixmX:22 a=1CNFftbPRP8L7MoqJWF3:22 a=HkZW87K1Qel5hWWM3VKY:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Rich Felker , kbuild-all@lists.01.org, Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , dri-devel@lists.freedesktop.org, Andrzej Hajda , Peter Jones , Lee Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Y29tbWl0IGFhMWY0MzQ1YjU0ODA1MDJhNGU2MWFkZGY1YzU5ZDYwNmZkYmNlOGYKQXV0aG9yOiBT YW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+CkRhdGU6ICAgTW9uIE5vdiAzMCAyMjowOToy OSAyMDIwICswMTAwCgogICAgc2g6IEZpeCBzZXQgYnV0IG5vdCB1c2VkIHdhcm5pbmdzIHdpdGgg IUNPTkZJR19NTVUKICAgIAogICAgQnVpbGRpbmcgZmJkZXYgZHJpdmVycyBmb3Igc2ggd2l0aCBX PTEgcHJvZHVjZXMgdGhlIGZvbGxvd2luZyB3YXJuaW5nOgogICAgCiAgICAgICAgdG1pb2ZiLmM6 IEluIGZ1bmN0aW9uIOKAmHRtaW9mYl9yZW1vdmXigJk6CiAgICAgICAgdG1pb2ZiLmM6ODA1OjIx OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhwYXLigJkgc2V0IGJ1dCBub3QgdXNlZAogICAgCiAgICBU aGlzIGlzIHdpdGggYWxsbW9kY29uZmlnIGFuZCBBUkNIPXNoCiAgICAKICAgIFRoaXMgYm9pbGVk IGRvd24gdG8gaW91bm1hcCgpIGRlZmluZWQgYXMgZW1wdHkgZm9yICFDT05GSUdfTU1VLgogICAg Rml4IHRoaXMgYnkgYnkgYWRkaW5nICIodm9pZClhZGRyOyIgdG8gdGVsbCB0aGUgY29tcGlsZXIg dGhlCiAgICBhcmd1bWVudCB0byBpb3VubWFwKCkgc2hvdWxkIGJlIGNvbnNpZGVyZWQgdXNlZC4K ICAgIAogICAgdjQ6CiAgICAgIC0gRml4IGJ1aWxkIGVycm9yIG9mIGV0aGVybmV0IGRyaXZlciAo a2VybmVsIHRlc3Qgcm9ib3QpCiAgICAgICAgQWRkZWQgbWlzc2luZyAoKSBhcm91bmQgbWFjcm8g cGFyYW1ldGVyCiAgICAKICAgIFNpZ25lZC1vZmYtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5i b3JnLm9yZz4KICAgIENjOiBrZXJuZWwgdGVzdCByb2JvdCA8bGtwQGludGVsLmNvbT4KICAgIENj OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KICAgIENjOiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgogICAgQ2M6IFJpY2ggRmVsa2VyIDxkYWxpYXNAbGli Yy5vcmc+CiAgICBDYzogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KICAgIENjOiBHZWVy dCBVeXR0ZXJob2V2ZW4gPGdlZXJ0K3JlbmVzYXNAZ2xpZGVyLmJlPgogICAgQ2M6IE1pa2UgUmFw b3BvcnQgPHJwcHRAa2VybmVsLm9yZz4KICAgIENjOiBLdW5pbm9yaSBNb3JpbW90byA8a3VuaW5v cmkubW9yaW1vdG8uZ3hAcmVuZXNhcy5jb20+CiAgICBDYzogUGV0ZXIgWmlqbHN0cmEgPHBldGVy ekBpbmZyYWRlYWQub3JnPgogICAgQ2M6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4K ICAgIENjOiBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgoKZGlmZiAt LWdpdCBhL2FyY2gvc2gvaW5jbHVkZS9hc20vaW8uaCBiL2FyY2gvc2gvaW5jbHVkZS9hc20vaW8u aAppbmRleCA2ZDVjNjQ2M2JjMDcuLjQ1MDgyYmNiZDlhYSAxMDA2NDQKLS0tIGEvYXJjaC9zaC9p bmNsdWRlL2FzbS9pby5oCisrKyBiL2FyY2gvc2gvaW5jbHVkZS9hc20vaW8uaApAQCAtMjcxLDcg KzI3MSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICppb3JlbWFwX3Byb3QocGh5c19h ZGRyX3Qgb2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCiAjZW5kaWYgLyogQ09ORklHX0hBVkVf SU9SRU1BUF9QUk9UICovCiAKICNlbHNlIC8qIENPTkZJR19NTVUgKi8KLSNkZWZpbmUgaW91bm1h cChhZGRyKQkJZG8geyB9IHdoaWxlICgwKQorI2RlZmluZSBpb3VubWFwKGFkZHIpCQlkbyB7ICh2 b2lkKShhZGRyKTsgfSB3aGlsZSAoMCkKICNkZWZpbmUgaW9yZW1hcChvZmZzZXQsIHNpemUpCSgo dm9pZCBfX2lvbWVtICopKHVuc2lnbmVkIGxvbmcpKG9mZnNldCkpCiAjZW5kaWYgLyogQ09ORklH X01NVSAqLwogCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8465658875188791799==" MIME-Version: 1.0 From: Sam Ravnborg To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Date: Sun, 06 Dec 2020 22:48:14 +0100 Message-ID: <20201206214814.GA1884161@ravnborg.org> In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com> List-Id: --===============8465658875188791799== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable commit aa1f4345b5480502a4e61addf5c59d606fdbce8f Author: Sam Ravnborg Date: Mon Nov 30 22:09:29 2020 +0100 sh: Fix set but not used warnings with !CONFIG_MMU = Building fbdev drivers for sh with W=3D1 produces the following warning: = tmiofb.c: In function =E2=80=98tmiofb_remove=E2=80=99: tmiofb.c:805:21: warning: variable =E2=80=98par=E2=80=99 set but no= t used = This is with allmodconfig and ARCH=3Dsh = This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used. = v4: - Fix build error of ethernet driver (kernel test robot) Added missing () around macro parameter = Signed-off-by: Sam Ravnborg Cc: kernel test robot Cc: Thomas Zimmermann Cc: Lee Jones Cc: Rich Felker Cc: Arnd Bergmann Cc: Geert Uytterhoeven Cc: Mike Rapoport Cc: Kuninori Morimoto Cc: Peter Zijlstra Cc: Sam Ravnborg Cc: Andrew Morton diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index 6d5c6463bc07..45082bcbd9aa 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t of= fset, unsigned long size, #endif /* CONFIG_HAVE_IOREMAP_PROT */ = #else /* CONFIG_MMU */ -#define iounmap(addr) do { } while (0) +#define iounmap(addr) do { (void)(addr); } while (0) #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) #endif /* CONFIG_MMU */ =20 --===============8465658875188791799==--