From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] soc: samsung: asv: don't defer early on not-supported SoCs
Date: Mon, 7 Dec 2020 09:10:05 +0100 [thread overview]
Message-ID: <20201207081005.GA6278@kozik-lap> (raw)
In-Reply-To: <20201207072928.20010-1-m.szyprowski@samsung.com>
On Mon, Dec 07, 2020 at 08:29:28AM +0100, Marek Szyprowski wrote:
> Check if the SoC is really supported before gathering the needed
> resources. This fixes endless deffered probe on some SoCs other than
> Exynos5422 (like Exynos5410).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
If it really causes endless deffer, then also Cc stable.
Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver")
There is one more problem here - on Exynos5410 or anything else with
such chipid node, this will cause -ENODEV probe failures. It should not.
Simply, it should not match for them.
This could be achieved with another compatible, but it won't really
describe the real case here, because it is not Chip ID which is
different. The CPU and bus voltages are different, the SoC is different.
Maybe this should not match to chip ID at all?
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-07 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201207072939eucas1p1029a121730bbc0f3e120c607ec5e3002@eucas1p1.samsung.com>
2020-12-07 7:29 ` [PATCH] soc: samsung: asv: don't defer early on not-supported SoCs Marek Szyprowski
2020-12-07 8:10 ` Krzysztof Kozlowski [this message]
2020-12-07 8:25 ` Krzysztof Kozlowski
2020-12-07 9:16 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207081005.GA6278@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.