linux-next: Fixes tag needs some work in the drm-msm tree

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi all,

In commit

  9b73bde39cf2 ("drm/msm: Fix use-after-free in msm_gem with carveout")

Fixes tag

  Fixes: 4b85f7f5cf7 ("drm/msm: support for an arbitrary number of address spaces")

has these problem(s):

  - SHA1 should be at least 12 digits long

In the furture, this can be avoided by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Iskren Chernev]

On 12/6/20 10:05 PM, Stephen Rothwell wrote:
 > Hi all,
 >
 > In commit
 >
 >   9b73bde39cf2 ("drm/msm: Fix use-after-free in msm_gem with carveout")
 >
 > Fixes tag
 >
 >   Fixes: 4b85f7f5cf7 ("drm/msm: support for an arbitrary number of 
address spaces")
 >
 > has these problem(s):
 >
 >   - SHA1 should be at least 12 digits long
 >
 > In the furture, this can be avoided by setting core.abbrev to 12 (or 
more)
 > or (for git v2.11 or later) just making sure it is not set (or set to
 > "auto").

I'm sorry, I copied and truncated the hash by hand. I should have used

     git log --pretty=reference

Also scripts/checkpatch.pl didn't notice it. Should I submit v3 of the
patch or it's too late.

Regards,
Iskren

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Iskren,

On Sun, 6 Dec 2020 23:05:30 +0200 Iskren Chernev <iskren.chernev@gmail.com> wrote:
>
> I'm sorry, I copied and truncated the hash by hand. I should have used
> 
>      git log --pretty=reference

We actually prefer

	git log -1 --format='Fixes: %h (\"%s\")'

for fixes tags.

> Also scripts/checkpatch.pl didn't notice it. Should I submit v3 of the
> patch or it's too late.

I don't think it matters for now, just in the future, please.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Hi all,

On Mon, 7 Dec 2020 08:57:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> We actually prefer
> 
> 	git log -1 --format='Fixes: %h (\"%s\")'

	git log -1 --format='Fixes: %h ("%s")'

sorry :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  e7855117de91 ("drm/msm/dp: stop event kernel thread when DP unbind")

Fixes tag

  Fixes: e91e3065a806 ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi all,

In commit

  adfed3ba1ecb ("drm/msm/disp/dpu1: set vbif hw config to NULL to avoid use after memory free during pm runtime resume")

Fixes tag

  Fixes: 25fdd5933e4 ("drm/msm: Add SDM845 DPU support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi all,

In commit

  4845d89f94a3 ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")

Fixes tag

  Fixes: 82c59ed16695 ("drm/msm/dp: Add eDP support via aux_bus")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 0d682843bfee ("drm/msm/dp: Add eDP support via aux_bus")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Dmitry Baryshkov]

On Wed, 2 Mar 2022 at 03:43, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   8661f450626f ("dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml")
>
> Fixes tag
>
>   Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for

It seems the Fixes tag got split by my mail client.
Rob, any chance to fix that?

>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over moe than one line or truncate them.
>
> --
> Cheers,
> Stephen Rothwell



-- 
With best wishes
Dmitry

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  8661f450626f ("dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml")

Fixes tag

  Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over moe than one line or truncate them.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hi all,

Fixes tag

  Fixes: 86c2a0f000c1 drm/msm: ("Small submitqueue creation cleanup")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi all,

In commit

  16c0ec8f006d ("drm/msm/dp: only signal audio when disconnected detected at dp_pm_resume")

Fixes tag

  Fixes: 078867ce04ed ("drm/msm/dp: signal audio plugged change at dp_pm_resume")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: afc9b8b6bab8 ("drm/msm/dp: signal audio plugged change at dp_pm_resume")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hi all,

In commit

  63d581450413 ("drm/msm/dp: power off DP phy at suspend")

Fixes tag

  Fixes: 8dbde399044b ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  8dbde399044b ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly")

Fixes tag

  Fixes: 94e58e2d06e3 ("drm/msm/dp: reset dp controller only at boot up and pm_resume")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ea9f337ce81e ("drm/msm/dp: reset dp controller only at boot up and pm_resume")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  d9aa6571b28b ("drm/msm/dp: check sink_count before update is_connected status")

Fixes tag

  Fixes: 94e58e2d06e3 ("drm/msm/dp: reset dp controller only at boot up and pm_resume")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ea9f337ce81e ("drm/msm/dp: reset dp controller only at boot up and pm_resume")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hi all,

In commit

  a0b21e0ad294 ("drm/msm: Add missing stub definition")

Fixes tag

  Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  4a8b6b60a159 ("drm/msm/adreno: fix gpu probe if no interconnect-names")

Fixes tag

  Fixes: 8e29fb37b301 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 08af4769c7d2 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  9e3d8cc1cfbc ("drm/msm/adreno: fix gpu probe if no interconnect-names")

Fixes tag

  Fixes: 8e29fb37b301 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 937c55f6b726 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  736fe23d544f ("drm/msm/dpu: request for display color blocks based on hw catalog entry")

Fixes tag

  Fixes: e47616df008b ("drm/msm/dpu: add support for color processing

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not truncate or split Fixes tag lines.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hi all,

In commit

  5fddd4f5db87 ("drm/msm/dpu: request for display color blocks based on hw catalog entry")

Fixes tag

  Fixes: e47616df008b ("drm/msm/dpu: add support for color processing

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not truncate Fixes tags or split them over more than one line.

Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]