All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Qiu <jack.qiu@huawei.com>
To: <linux-f2fs-devel@lists.sourceforge.net>
Subject: [f2fs-dev] [PATCH v3 1/3] f2fs: inline: correct comment in f2fs_recover_inline_data
Date: Mon, 7 Dec 2020 20:01:12 +0800	[thread overview]
Message-ID: <20201207120114.25642-2-jack.qiu@huawei.com> (raw)
In-Reply-To: <20201207120114.25642-1-jack.qiu@huawei.com>

In 3rd scene, it should remove data blocks instead of inline_data.

Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/inline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 70384e31788d..0399531efcd3 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -266,7 +266,7 @@ int f2fs_recover_inline_data(struct inode *inode, struct page *npage)
 	 * [prev.] [next] of inline_data flag
 	 *    o       o  -> recover inline_data
 	 *    o       x  -> remove inline_data, and then recover data blocks
-	 *    x       o  -> remove inline_data, and then recover inline_data
+	 *    x       o  -> remove data blocks, and then recover inline_data
 	 *    x       x  -> recover data blocks
 	 */
 	if (IS_INODE(npage))
--
2.17.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-12-07 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 12:01 [f2fs-dev] [PATCH v3 0/3] f2fs: inline: fix minor bugs in f2fs_recover_inline_data Jack Qiu
2020-12-07 12:01 ` Jack Qiu [this message]
2020-12-07 12:01 ` [f2fs-dev] [PATCH v3 2/3] f2fs: inline: remove redundant FI_DATA_EXIST set Jack Qiu
2020-12-07 14:47   ` Chao Yu
2020-12-07 16:49   ` Jaegeuk Kim
2020-12-08  1:25     ` Chao Yu
2020-12-08  1:38       ` Jaegeuk Kim
2020-12-08  2:15         ` Chao Yu
2020-12-08  7:07           ` Jaegeuk Kim
2020-12-09  1:31             ` Chao Yu
2020-12-09  2:51               ` Jaegeuk Kim
2020-12-07 12:01 ` [f2fs-dev] [PATCH v3 3/3] f2fs: inline: fix wrong inline inode stat Jack Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207120114.25642-2-jack.qiu@huawei.com \
    --to=jack.qiu@huawei.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.