All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: subashab@codeaurora.org, stranche@codeaurora.org,
	Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability
Date: Mon, 7 Dec 2020 12:16:54 -0800	[thread overview]
Message-ID: <20201207121654.17fac0ef@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <CAMZdPi-Nrus0JrHpjg02QaVwr0TKGU=p96BjXAtd4LALAvk2HQ@mail.gmail.com>

On Mon, 7 Dec 2020 17:45:17 +0100 Loic Poulain wrote:
> > This would need similar checks in the NETDEV_PRECHANGEMTU
> > netdev notifier.  
> 
> What about just returning an error on NETDEV_PRECHANGEMTU notification
> to prevent real device MTU change while virtual rmnet devices are
> linked? Not sure there is a more proper and thread safe way to manager
> that otherwise.

Can't you copy what vlan devices do?  That'd seem like a reasonable and
well tested precedent, no?

  reply	other threads:[~2020-12-07 20:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 17:40 [PATCH] net: rmnet: Adjust virtual device MTU on real device capability Loic Poulain
2020-12-04 21:56 ` subashab
2020-12-07 16:45   ` Loic Poulain
2020-12-07 20:16     ` Jakub Kicinski [this message]
2020-12-08  8:19       ` subashab
2020-12-08 14:50         ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207121654.17fac0ef@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.