[PATCH 6/6] nvme: allow revalidate to set a namespace read-only

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	Oleksii Kurochko <olkuroch@cisco.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	Mike Snitzer <snitzer@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	Dongsheng Yang <dongsheng.yang@easystack.cn>,
	ceph-devel@vger.kernel.org, dm-devel@redhat.com,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: [PATCH 6/6] nvme: allow revalidate to set a namespace read-only
Date: Mon,  7 Dec 2020 14:19:18 +0100	[thread overview]
Message-ID: <20201207131918.2252553-7-hch@lst.de> (raw)
In-Reply-To: <20201207131918.2252553-1-hch@lst.de>

Unconditionally call set_disk_ro now that it only updates the hardware
state.  This allows to properly set up the Linux devices read-only when
the controller turns a previously writable namespace read-only.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 24d7f64f14cb15..18cbf92fc4f957 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2114,9 +2114,8 @@ static void nvme_update_disk_info(struct gendisk *disk,
 	nvme_config_discard(disk, ns);
 	nvme_config_write_zeroes(disk, ns);
 
-	if ((id->nsattr & NVME_NS_ATTR_RO) ||
-	    test_bit(NVME_NS_FORCE_RO, &ns->flags))
-		set_disk_ro(disk, true);
+	set_disk_ro(disk, (id->nsattr & NVME_NS_ATTR_RO) ||
+		test_bit(NVME_NS_FORCE_RO, &ns->flags));
 }
 
 static inline bool nvme_first_scan(struct gendisk *disk)
-- 
2.29.2

WARNING: multiple messages have this Message-ID (diff)

From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Mike Snitzer <snitzer@redhat.com>,
	Oleksii Kurochko <olkuroch@cisco.com>,
	Dongsheng Yang <dongsheng.yang@easystack.cn>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-nvme@lists.infradead.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	ceph-devel@vger.kernel.org
Subject: [PATCH 6/6] nvme: allow revalidate to set a namespace read-only
Date: Mon,  7 Dec 2020 14:19:18 +0100	[thread overview]
Message-ID: <20201207131918.2252553-7-hch@lst.de> (raw)
In-Reply-To: <20201207131918.2252553-1-hch@lst.de>

Unconditionally call set_disk_ro now that it only updates the hardware
state.  This allows to properly set up the Linux devices read-only when
the controller turns a previously writable namespace read-only.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 24d7f64f14cb15..18cbf92fc4f957 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2114,9 +2114,8 @@ static void nvme_update_disk_info(struct gendisk *disk,
 	nvme_config_discard(disk, ns);
 	nvme_config_write_zeroes(disk, ns);
 
-	if ((id->nsattr & NVME_NS_ATTR_RO) ||
-	    test_bit(NVME_NS_FORCE_RO, &ns->flags))
-		set_disk_ro(disk, true);
+	set_disk_ro(disk, (id->nsattr & NVME_NS_ATTR_RO) ||
+		test_bit(NVME_NS_FORCE_RO, &ns->flags));
 }
 
 static inline bool nvme_first_scan(struct gendisk *disk)
-- 
2.29.2


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)

From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Mike Snitzer <snitzer@redhat.com>,
	Oleksii Kurochko <olkuroch@cisco.com>,
	Dongsheng Yang <dongsheng.yang@easystack.cn>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-nvme@lists.infradead.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	ceph-devel@vger.kernel.org
Subject: [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only
Date: Mon,  7 Dec 2020 14:19:18 +0100	[thread overview]
Message-ID: <20201207131918.2252553-7-hch@lst.de> (raw)
In-Reply-To: <20201207131918.2252553-1-hch@lst.de>

Unconditionally call set_disk_ro now that it only updates the hardware
state.  This allows to properly set up the Linux devices read-only when
the controller turns a previously writable namespace read-only.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 24d7f64f14cb15..18cbf92fc4f957 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2114,9 +2114,8 @@ static void nvme_update_disk_info(struct gendisk *disk,
 	nvme_config_discard(disk, ns);
 	nvme_config_write_zeroes(disk, ns);
 
-	if ((id->nsattr & NVME_NS_ATTR_RO) ||
-	    test_bit(NVME_NS_FORCE_RO, &ns->flags))
-		set_disk_ro(disk, true);
+	set_disk_ro(disk, (id->nsattr & NVME_NS_ATTR_RO) ||
+		test_bit(NVME_NS_FORCE_RO, &ns->flags));
 }
 
 static inline bool nvme_first_scan(struct gendisk *disk)
-- 
2.29.2

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

next prev parent reply	other threads:[~2020-12-07 13:23 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 13:19 split hard read-only vs read-only policy v2 Christoph Hellwig
2020-12-07 13:19 ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19 ` Christoph Hellwig
2020-12-07 13:19 ` [PATCH 1/6] dm: use bdev_read_only to check if a device is read-only Christoph Hellwig
2020-12-07 13:19   ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-08  5:23   ` Martin K. Petersen
2020-12-08  5:23     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:23     ` Martin K. Petersen
2020-12-08  9:59   ` Ming Lei
2020-12-08  9:59     ` [dm-devel] " Ming Lei
2020-12-08  9:59     ` Ming Lei
2020-12-07 13:19 ` [PATCH 2/6] block: remove the NULL bdev check in bdev_read_only Christoph Hellwig
2020-12-07 13:19   ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-08  5:23   ` Martin K. Petersen
2020-12-08  5:23     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:23     ` Martin K. Petersen
2020-12-08 10:06   ` Ming Lei
2020-12-08 10:06     ` [dm-devel] " Ming Lei
2020-12-08 10:06     ` Ming Lei
2020-12-07 13:19 ` [PATCH 3/6] block: add a hard-readonly flag to struct gendisk Christoph Hellwig
2020-12-07 13:19   ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-08  5:24   ` Martin K. Petersen
2020-12-08  5:24     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:24     ` Martin K. Petersen
2020-12-08  5:28   ` Martin K. Petersen
2020-12-08  5:28     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:28     ` Martin K. Petersen
2020-12-08 10:22   ` Ming Lei
2020-12-08 10:22     ` [dm-devel] " Ming Lei
2020-12-08 10:22     ` Ming Lei
2020-12-08 10:57     ` Christoph Hellwig
2020-12-08 10:57       ` [dm-devel] " Christoph Hellwig
2020-12-08 10:57       ` Christoph Hellwig
2020-12-07 13:19 ` [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions Christoph Hellwig
2020-12-07 13:19   ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-08  5:27   ` Martin K. Petersen
2020-12-08  5:27     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:27     ` Martin K. Petersen
2020-12-08  9:25     ` Christoph Hellwig
2020-12-08  9:25       ` [dm-devel] " Christoph Hellwig
2020-12-08  9:25       ` Christoph Hellwig
2020-12-08 12:41       ` Johannes Thumshirn
2020-12-08 12:41         ` [dm-devel] " Johannes Thumshirn
2020-12-08 12:41         ` Johannes Thumshirn
2020-12-08 10:29   ` Ming Lei
2020-12-08 10:29     ` [dm-devel] " Ming Lei
2020-12-08 10:29     ` Ming Lei
2020-12-08 10:59     ` Christoph Hellwig
2020-12-08 10:59       ` [dm-devel] " Christoph Hellwig
2020-12-08 10:59       ` Christoph Hellwig
2020-12-09  1:23       ` Ming Lei
2020-12-09  1:23         ` [dm-devel] " Ming Lei
2020-12-09  1:23         ` Ming Lei
2020-12-07 13:19 ` [PATCH 5/6] rbd: remove the ->set_read_only method Christoph Hellwig
2020-12-07 13:19   ` [dm-devel] " Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-07 14:57   ` Ilya Dryomov
2020-12-07 14:57     ` [dm-devel] " Ilya Dryomov
2020-12-07 14:57     ` Ilya Dryomov
2020-12-08  5:30   ` Martin K. Petersen
2020-12-08  5:30     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:30     ` Martin K. Petersen
2020-12-07 13:19 ` Christoph Hellwig [this message]
2020-12-07 13:19   ` [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2020-12-07 13:19   ` Christoph Hellwig
2020-12-07 18:13   ` Keith Busch
2020-12-07 18:13     ` [dm-devel] " Keith Busch
2020-12-07 18:13     ` Keith Busch
2020-12-08  5:29   ` Martin K. Petersen
2020-12-08  5:29     ` [dm-devel] " Martin K. Petersen
2020-12-08  5:29     ` Martin K. Petersen
2020-12-10  7:50 ` split hard read-only vs read-only policy v2 Christoph Hellwig
2020-12-10  7:50   ` [dm-devel] " Christoph Hellwig
2020-12-10  7:50   ` Christoph Hellwig
2020-12-08 16:28 split hard read-only vs read-only policy v3 Christoph Hellwig
2020-12-08 16:28 ` [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2020-12-08 16:28   ` Christoph Hellwig
2020-12-08 16:49   ` Hannes Reinecke
2020-12-08 16:49     ` Hannes Reinecke
2020-12-09  2:54   ` Ming Lei
2020-12-09  2:54     ` Ming Lei
2021-01-09 10:42 split hard read-only vs read-only policy v3 (resend) Christoph Hellwig
2021-01-09 10:42 ` [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2021-01-09 10:42   ` Christoph Hellwig
2021-01-09 20:27   ` Chaitanya Kulkarni
2021-01-09 20:27     ` Chaitanya Kulkarni
2021-01-10 15:01   ` Hannes Reinecke
2021-01-10 15:01     ` Hannes Reinecke

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:24d7f64f14cb1 dfblob:24d7f64f14cb1 dfblob:24d7f64f14cb1
dfblob:18cbf92fc4f95 dfblob:18cbf92fc4f95 dfblob:18cbf92fc4f95
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207131918.2252553-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dm-devel@redhat.com \
    --cc=dongsheng.yang@easystack.cn \
    --cc=idryomov@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=olkuroch@cisco.com \
    --cc=sagi@grimberg.me \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.