From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F7DC4361B for ; Mon, 7 Dec 2020 13:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E36423437 for ; Mon, 7 Dec 2020 13:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgLGNW0 (ORCPT ); Mon, 7 Dec 2020 08:22:26 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53205 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgLGNWZ (ORCPT ); Mon, 7 Dec 2020 08:22:25 -0500 Received: by mail-wm1-f66.google.com with SMTP id a6so11451489wmc.2; Mon, 07 Dec 2020 05:22:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MJwMrUj3WNQ0Z6JF3rMMT8PRx7qig2o2mEv5ta9FJhk=; b=iPJwYcwjjFrBn3UILT6Ut20S2nzO+hxf+Kk52/R5f5e0smBaU1Z/PeyVMDiL7t+1kg eg27v6L2dOZ0bHO085FQxYAg7YiZi5AF4Juy6ergY6vTWUj9RGQpVkTYExcghp1u+V+e rSGaCgGQ+HYeDk8P4sfxJ2+mTsx8mmXeM1Xae+ukHaP53SFa0zssqyWA7JEC+zW9wjIc SOtan1b+JH0SmCREKHap6795F9FDJ/++gmkKfRgu0BVAtpviNrnRyMRbLcNQ5SQ82g5E hjxl2UFhX9vKMeQ1leAu5pwrx58rqgE44lcUy72zUV9nFart5We8lg9qMuDZl7aluXwI YHtg== X-Gm-Message-State: AOAM533KQJE+Hs+2z0s4iB5Ja83FrQLa/0cTfDCPY3x3sGKSy/HKAXCl U4ZfAdjTMHF6BI1xkziDVgA= X-Google-Smtp-Source: ABdhPJyO70ZClWQf3G0rlUyq9BYbIJl9dRorKgaLYiVZ7ua/tO2HTRt3sifgwB+7CESnraCvF7RTjg== X-Received: by 2002:a7b:c2e8:: with SMTP id e8mr18172792wmk.103.1607347303289; Mon, 07 Dec 2020 05:21:43 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id y6sm15005491wmg.39.2020.12.07.05.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 05:21:41 -0800 (PST) Date: Mon, 7 Dec 2020 14:21:40 +0100 From: Krzysztof Kozlowski To: Shengjiu Wang Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name Message-ID: <20201207132140.GA31982@kozik-lap> References: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > Error log: > sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus' > > The spba bus name is duplicate with aips bus name. > Refine spba bus name to fix this issue. > > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter") > Signed-off-by: Shengjiu Wang > --- > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index fd669c0f3fe5..30762eb4f0a7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -246,7 +246,7 @@ aips1: bus@30000000 { > #size-cells = <1>; > ranges; > > - spba: bus@30000000 { > + spba: spba-bus@30000000 { The proper node name is "bus" so basically you introduce wrong name to other problem. Introducing wrong names at least requires a comment. However the actual problem here is not in node names but in addresses: aips1: bus@30000000 { spba: bus@30000000 { You have to devices with the same unit address. How do you share the address space? I think this should be rather fixed. Best regards, Krzysztof > compatible = "fsl,spba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B93AC433FE for ; Mon, 7 Dec 2020 13:23:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F4D23436 for ; Mon, 7 Dec 2020 13:23:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32F4D23436 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2aQCo5H0Thz7D2KdcNXuaSrh4YpGuvHOQrsS3kfZwE4=; b=oWTWf8qdOOZPcnxgad0ngfAHx TFEEMAWuJcFTNpjU1dauXss3pJO+PnWB5NfQ/8e04Zf+JfsR4TgMCxrtCdT9A9lfbES3h3IV8Lykl 5XmH5DrNyrdKuHSfp+eog5QR1cfKTcqMWKJFlFWsmVNGNRtOYsmC7B/lGyTUIfVe6+ORHfzzxW5Yk qOUU5MhJWO9Jt2z1i44Tjto2wpUvaB4e2D+YlVGQ4/rTxa6rCYaMwbq/GRj0tMmROHUVGEvDiZqgi 9BAGxp3Dac6x24lWuRnpfZXFUT/TygZkUuGBOKUyEG8pdnWhasZlHfiCjMvxfmqZWAGP4auVs89lV RXLEpy8pQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGSa-0005yN-Rq; Mon, 07 Dec 2020 13:21:48 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGSW-0005wW-QJ for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 13:21:45 +0000 Received: by mail-wm1-f65.google.com with SMTP id h21so13656344wmb.2 for ; Mon, 07 Dec 2020 05:21:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MJwMrUj3WNQ0Z6JF3rMMT8PRx7qig2o2mEv5ta9FJhk=; b=K8vl7CqKZra6BYUeG7A18eIUtMAPyMoyTRCC9XktgX3O2MselHUcDfK3/3XzEtYCks zSJNZ3vlGSXlGYKcrutxjkVyF3E/Xu3JXFzW3+yVklYrJzTp51yNH6QRLEuZMBoNseq5 JJroydTWslpnWK9c7jnQulEpY05sTeZZyUtEjO1xLmTcAwBBxVFuq4A2XRRVhRaWJwCe qphKP1XUag10bgvXxUG9MJQSOdKQShoLoa6UkfnYO+lEu32RBegVJ5bB80lPiT0Ttux/ EMD8LBdxUJW4hohz4tyGYoR+aB7/BmjIg/OZDN7PjhNPb2PbYk8xJQ4jAOV9biEG4DOI sfSA== X-Gm-Message-State: AOAM532W//GSabM+/09/88xpGmg7eyTcty8n4ZSNNDOA6igykWH9q5Le FySUJ1R4ygu4ZO5brx3mcbE= X-Google-Smtp-Source: ABdhPJyO70ZClWQf3G0rlUyq9BYbIJl9dRorKgaLYiVZ7ua/tO2HTRt3sifgwB+7CESnraCvF7RTjg== X-Received: by 2002:a7b:c2e8:: with SMTP id e8mr18172792wmk.103.1607347303289; Mon, 07 Dec 2020 05:21:43 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id y6sm15005491wmg.39.2020.12.07.05.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 05:21:41 -0800 (PST) Date: Mon, 7 Dec 2020 14:21:40 +0100 From: Krzysztof Kozlowski To: Shengjiu Wang Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name Message-ID: <20201207132140.GA31982@kozik-lap> References: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_082144_918155_0796F464 X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > Error log: > sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus' > > The spba bus name is duplicate with aips bus name. > Refine spba bus name to fix this issue. > > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter") > Signed-off-by: Shengjiu Wang > --- > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index fd669c0f3fe5..30762eb4f0a7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -246,7 +246,7 @@ aips1: bus@30000000 { > #size-cells = <1>; > ranges; > > - spba: bus@30000000 { > + spba: spba-bus@30000000 { The proper node name is "bus" so basically you introduce wrong name to other problem. Introducing wrong names at least requires a comment. However the actual problem here is not in node names but in addresses: aips1: bus@30000000 { spba: bus@30000000 { You have to devices with the same unit address. How do you share the address space? I think this should be rather fixed. Best regards, Krzysztof > compatible = "fsl,spba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel