From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08442C433FE for ; Mon, 7 Dec 2020 21:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A816622C7C for ; Mon, 7 Dec 2020 21:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbgLGVoT (ORCPT ); Mon, 7 Dec 2020 16:44:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:43344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgLGVoS (ORCPT ); Mon, 7 Dec 2020 16:44:18 -0500 Date: Mon, 7 Dec 2020 13:43:35 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607377417; bh=ZdgCiySmxnYeCPG0fk38ET6CeRw/+tGlOaM4V7yjNFY=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=inxD7cCzD2PcOzMiozfvnpJXTywf4sbP7Ixew2J9yxnJPBOqWMOQUTo8wbWX+e0PR rUYP5WNZL1iuvOqZ5Gj+QRms+1oYhusPdEE5k3bdTnKkmBbFmGogDsBslccBySLx64 KcW21gRyNPnXJN+qVQcRdNRZHAERUcusgYDE/VFx2fdlf2IBypZAtljx0PIen+ncgh HMdpj9+3UuyQ/090OsjCpowU9lM+HNsxoCyVfX+lwwaBIzPXKU0h244QOiOnuoLTQ3 TV5OMRm2luTV+2RkGk++nsqsO9vBjTruiFXCROvjlmmHN8tK90dvDtYgBrLJDBvR11 /zOP6Q0LPyxQw== From: Jakub Kicinski To: Aleksander Jan Bajkowski Cc: hauke@hauke-m.de, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, robh+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330 Message-ID: <20201207134335.6ef718c9@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201206132713.13452-2-olek2@wp.pl> References: <20201206132713.13452-1-olek2@wp.pl> <20201206132713.13452-2-olek2@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 6 Dec 2020 14:27:12 +0100 Aleksander Jan Bajkowski wrote: > This patch allows to use all PHYs on GRX300 and GRX330. The ARX300 has 3 > and the GRX330 has 4 integrated PHYs connected to different ports compared > to VRX200. >=20 > Port configurations: >=20 > xRX200: > GMAC0: RGMII/MII/REVMII/RMII port > GMAC1: RGMII/MII/REVMII/RMII port > GMAC2: GPHY0 (GMII) > GMAC3: GPHY0 (MII) > GMAC4: GPHY1 (GMII) > GMAC5: GPHY1 (MII) or RGMII port >=20 > xRX300: > GMAC0: RGMII port > GMAC1: GPHY2 (GMII) > GMAC2: GPHY0 (GMII) > GMAC3: GPHY0 (MII) > GMAC4: GPHY1 (GMII) > GMAC5: GPHY1 (MII) or RGMII port >=20 > xRX330: > GMAC0: RGMII/GMII/RMII port > GMAC1: GPHY2 (GMII) > GMAC2: GPHY0 (GMII) > GMAC3: GPHY0 (MII) or GPHY3 (GMII) > GMAC4: GPHY1 (GMII) > GMAC5: GPHY1 (MII) or RGMII/RMII port >=20 > Tested on D-Link DWR966 with OpenWRT. >=20 > Signed-off-by: Aleksander Jan Bajkowski Please make sure you don't add W=3D1 C=3D1 build warnings: In file included from ../include/linux/kasan-checks.h:5, from ../include/asm-generic/rwonce.h:26, from ./arch/x86/include/generated/asm/rwonce.h:1, from ../include/linux/compiler.h:246, from ../include/linux/err.h:5, from ../include/linux/clk.h:12, from ../drivers/net/dsa/lantiq_gswip.c:28: drivers/net/dsa/lantiq_gswip.c: In function =E2=80=98gswip_xrx300_phylink_v= alidate=E2=80=99: drivers/net/dsa/lantiq_gswip.c:1496:35: warning: unused variable =E2=80=98m= ask=E2=80=99 [-Wunused-variable] 1496 | __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) =3D { 0, }; | ^~~~ include/linux/types.h:11:16: note: in definition of macro =E2=80=98DECLARE_= BITMAP=E2=80=99 11 | unsigned long name[BITS_TO_LONGS(bits)] | ^~~~ drivers/net/dsa/lantiq_gswip.c:1496:2: note: in expansion of macro =E2=80= =98__ETHTOOL_DECLARE_LINK_MODE_MASK=E2=80=99 1496 | __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) =3D { 0, }; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/lantiq_gswip.c: At top level: drivers/net/dsa/lantiq_gswip.c:2079:9: warning: initialization discards =E2= =80=98const=E2=80=99 qualifier from pointer target type [-Wdiscarded-qualif= iers] 2079 | .ops =3D &gswip_xrx200_switch_ops, | ^ drivers/net/dsa/lantiq_gswip.c:2085:9: warning: initialization discards =E2= =80=98const=E2=80=99 qualifier from pointer target type [-Wdiscarded-qualif= iers] 2085 | .ops =3D &gswip_xrx300_switch_ops, | ^ drivers/net/dsa/lantiq_gswip.c:2079:17: warning: incorrect type in initiali= zer (different modifiers) drivers/net/dsa/lantiq_gswip.c:2079:17: expected struct dsa_switch_ops *= ops drivers/net/dsa/lantiq_gswip.c:2079:17: got struct dsa_switch_ops const * drivers/net/dsa/lantiq_gswip.c:2085:17: warning: incorrect type in initiali= zer (different modifiers) drivers/net/dsa/lantiq_gswip.c:2085:17: expected struct dsa_switch_ops *= ops drivers/net/dsa/lantiq_gswip.c:2085:17: got struct dsa_switch_ops const *