From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20AF5C4167B for ; Mon, 7 Dec 2020 16:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E20642388E for ; Mon, 7 Dec 2020 16:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgLGQuc (ORCPT ); Mon, 7 Dec 2020 11:50:32 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:38022 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbgLGQub (ORCPT ); Mon, 7 Dec 2020 11:50:31 -0500 Received: by mail-ot1-f68.google.com with SMTP id b62so13062988otc.5; Mon, 07 Dec 2020 08:50:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UuU157skWGSfcX1NxkRT5BCxvQhS6DEbdRKPwY10+n0=; b=hCK6FDD4WU2yynGVHiEr7PlQf2WEC969EJ0vecyIyYzNyLdcXCpFPiT+cIt868FFn/ XGrut0KXl74RIs+evyFoUkUYQbC+XwrGOZ0ppEEFnG1cRgpueDcFoxNES6n++AFfEyhv sEx6PYMh57zw9RLk7TV22Ac2HuN9YUbf4X9UaXEV24ZozqpVO9PM8mlMx9M7PF1dG59E oSNgUNNTSrzyaAb0u33l5Grg3rfEEGEMNefIvsWS6HAVdj6vXSO9e/zCebJsyOOPeWDw opJTzKxJ879dJAXKMPsJUPkdr0OeZPkDyUiu68XRKf10P4FjsHl8VtSRbK0owYbAjT3r +alA== X-Gm-Message-State: AOAM531z9b6RvfIUU77KY3tXS4Q1gS6J8vksaFaXOQ3VvNvk829MAInq HZcAd8eugS4mutGD5MAf8A== X-Google-Smtp-Source: ABdhPJxmcf4zm/wuxPhsKUoUScvOLy83vfBUwi8g1uPSshO3b0CcihsttcupDMYjJmpikbuM3HuZZw== X-Received: by 2002:a9d:7304:: with SMTP id e4mr4414560otk.228.1607359790146; Mon, 07 Dec 2020 08:49:50 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x72sm3040778oia.16.2020.12.07.08.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:49:48 -0800 (PST) Received: (nullmailer pid 420892 invoked by uid 1000); Mon, 07 Dec 2020 16:49:47 -0000 Date: Mon, 7 Dec 2020 10:49:47 -0600 From: Rob Herring To: Serge Semin Cc: Roger Quadros , linux-kernel@vger.kernel.org, Martin Blumenstingl , devicetree@vger.kernel.org, Serge Semin , Felipe Balbi , Mathias Nyman , Ahmad Zainie , Rob Herring , Neil Armstrong , Pavel Parkhomenko , linux-mips@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Yoshihiro Shimoda , Lad Prabhakar , Chunfeng Yun , Kevin Hilman , linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski , Alexey Malahov , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , linux-usb@vger.kernel.org, Manu Gautam Subject: Re: [PATCH v5 10/19] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201207164947.GA420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 05 Dec 2020 18:24:17 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note 1. we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Note 2. The clock-related properties are marked as optional to match the > DWC USB3 driver expectation and to improve the bindings mainainability > so in case if there is a glue-node it would the responsible for the > clocks initialization. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > > Changelog v3: > - Apply usb-xhci.yaml# schema only if the controller is supposed to work > as either host or otg. > > Changelog v4: > - Apply usb-drd.yaml schema first. If the controller is configured > to work in a gadget mode only, then apply the usb.yaml schema too, > otherwise apply the usb-xhci.yaml schema. > - Discard the Rob'es Reviewed-by tag. Please review the patch one more > time. > > Changelog v5: > - Add "snps,dis-split-quirk" property to the DWC USB3 DT schema. > - Add a commit log text about the clock-related property changes. > - Make sure dr_mode exist to apply the USB-gadget-only schema. > --- > .../devicetree/bindings/usb/dwc3.txt | 128 ------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 312 ++++++++++++++++++ > 2 files changed, 312 insertions(+), 128 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:55:4: [warning] wrong indentation: expected 4 but found 3 (indentation) dtschema/dtc warnings/errors: Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/usb/usb-drd.yaml' xargs: dt-doc-validate: exited with status 255; aborting make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 124 make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1411582 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09291C4361B for ; Mon, 7 Dec 2020 16:52:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A11F23884 for ; Mon, 7 Dec 2020 16:52:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A11F23884 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CqTqg0tNPzDqWn for ; Tue, 8 Dec 2020 03:51:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.67; helo=mail-ot1-f67.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CqTnL2wGHzDqNS for ; Tue, 8 Dec 2020 03:49:55 +1100 (AEDT) Received: by mail-ot1-f67.google.com with SMTP id h18so9078378otq.12 for ; Mon, 07 Dec 2020 08:49:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UuU157skWGSfcX1NxkRT5BCxvQhS6DEbdRKPwY10+n0=; b=mfB/zgwm52k/mM7TNF2my5V5G3RlhUxfL0VYykI7FhA8buNad1OiL5HFKunqHNfdsW BQ/MKp61pfnYYCk0ck3oZLdWVN6u7F6dmh/Ptn2iv/nl9Z8Ha/eubI9uOOzJcGsx3R/s MNmSdG0J1mLHAx7bmJ4jvuXlSW6I0hiDd47Ry2swSV4jtYmkQq+Kj2zQHamBimY5qI9A hUt1KI4kL2MSSnP864UZa6bEIQzTkwTwavxV2YS4VlQ317A/r13Caj7UYMmgVQttqfrk pDNFXPSMJkEY6F+X4RCWSPpAAMUdmpV3ay8ckF50KjDMWWDfUO4WeB0kZroJ+QhkHS/t +0/g== X-Gm-Message-State: AOAM531z2/+PP0pW+fN63LFYg15gb4437GPQoAiMBqpwynMwxrQRd1E9 TiYykLrzQejBuhmqcBQ5rw== X-Google-Smtp-Source: ABdhPJxmcf4zm/wuxPhsKUoUScvOLy83vfBUwi8g1uPSshO3b0CcihsttcupDMYjJmpikbuM3HuZZw== X-Received: by 2002:a9d:7304:: with SMTP id e4mr4414560otk.228.1607359790146; Mon, 07 Dec 2020 08:49:50 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x72sm3040778oia.16.2020.12.07.08.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:49:48 -0800 (PST) Received: (nullmailer pid 420892 invoked by uid 1000); Mon, 07 Dec 2020 16:49:47 -0000 Date: Mon, 7 Dec 2020 10:49:47 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 10/19] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201207164947.GA420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 05 Dec 2020 18:24:17 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note 1. we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Note 2. The clock-related properties are marked as optional to match the > DWC USB3 driver expectation and to improve the bindings mainainability > so in case if there is a glue-node it would the responsible for the > clocks initialization. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > > Changelog v3: > - Apply usb-xhci.yaml# schema only if the controller is supposed to work > as either host or otg. > > Changelog v4: > - Apply usb-drd.yaml schema first. If the controller is configured > to work in a gadget mode only, then apply the usb.yaml schema too, > otherwise apply the usb-xhci.yaml schema. > - Discard the Rob'es Reviewed-by tag. Please review the patch one more > time. > > Changelog v5: > - Add "snps,dis-split-quirk" property to the DWC USB3 DT schema. > - Add a commit log text about the clock-related property changes. > - Make sure dr_mode exist to apply the USB-gadget-only schema. > --- > .../devicetree/bindings/usb/dwc3.txt | 128 ------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 312 ++++++++++++++++++ > 2 files changed, 312 insertions(+), 128 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:55:4: [warning] wrong indentation: expected 4 but found 3 (indentation) dtschema/dtc warnings/errors: Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/usb/usb-drd.yaml' xargs: dt-doc-validate: exited with status 255; aborting make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 124 make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1411582 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2316BC433FE for ; Mon, 7 Dec 2020 16:49:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D286F23787 for ; Mon, 7 Dec 2020 16:49:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D286F23787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TquIVBdHkfUJ92t2EVg32q5kffyoKffvut+5rvMCpi0=; b=TCINlYUV2ulo9M7bRqx1C9YTH isou2MHUF633Vw5w1nMjHkRAA0STOGXfa0SJENkeCoarQGq+d31kaQDQ7xW8J9Uf+EBa2s/dlnVSf P8ZCdmFTf5UFGP/RpBDUPhihqLAb/Q43jU0+IMzluzZIE7y+MdcCQeUKIbzENiZ/n8GtZ9gDZIaP7 A1fidWG0XKguKf2ky95wnMp5fVHfExIepeaNpGT5bZKD5S1H5YTCNS2cqckWo89rQnKp40KUXBQN3 FVjqvhuoAuJepwqKXk4cl9Xp3/khg+gEbypBCGd4V5zsbesaNgjp+zxEQYdJd0wY9ScqBmyMQLo9c dmXBqPQgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJhy-0004NS-4N; Mon, 07 Dec 2020 16:49:54 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJhv-0004N0-WF; Mon, 07 Dec 2020 16:49:52 +0000 Received: by mail-ot1-f65.google.com with SMTP id o11so10377719ote.4; Mon, 07 Dec 2020 08:49:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UuU157skWGSfcX1NxkRT5BCxvQhS6DEbdRKPwY10+n0=; b=VNtOHiyPcF11TMPliAaASI5CUHy0bnbHjRvKQhQ84AlZAEFdekmX9IjEVG1kBN/x97 LXeaDyXIVfqjB/HwEb0W2UlXEOJ/tlD7OsXLYUn//kyCDz/fAhoUnPqyrrK9c35HzJ0/ FM+oYxA03exGxjA5fEU+3jd4hf0Go4Mc4pJ2z885HFaq7lwwYjvLDr3fDuFqtSHCdS1M w5GGLfprRUjMxeD56UP45F8FjXefVi0oFlZEcFcjIC9kxCfkd7kgj0rkm+pKk52uDGb0 Zn6WvMebI9FTVpXYbDK73B23MRQMZXnxndxZjp9SHjIDdZfhzyC3U+Vo92FK1iDAf1uq 9r6w== X-Gm-Message-State: AOAM531Y4jIPdRc6XiGOXO0ijQRXnIHwGjfaMSdlbzjNVylNSYUjzCJ8 6BDd0fG9gg9eA5m/YC6vZQ== X-Google-Smtp-Source: ABdhPJxmcf4zm/wuxPhsKUoUScvOLy83vfBUwi8g1uPSshO3b0CcihsttcupDMYjJmpikbuM3HuZZw== X-Received: by 2002:a9d:7304:: with SMTP id e4mr4414560otk.228.1607359790146; Mon, 07 Dec 2020 08:49:50 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x72sm3040778oia.16.2020.12.07.08.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:49:48 -0800 (PST) Received: (nullmailer pid 420892 invoked by uid 1000); Mon, 07 Dec 2020 16:49:47 -0000 Date: Mon, 7 Dec 2020 10:49:47 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 10/19] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201207164947.GA420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_114952_082099_D86B963F X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Sat, 05 Dec 2020 18:24:17 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note 1. we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Note 2. The clock-related properties are marked as optional to match the > DWC USB3 driver expectation and to improve the bindings mainainability > so in case if there is a glue-node it would the responsible for the > clocks initialization. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > > Changelog v3: > - Apply usb-xhci.yaml# schema only if the controller is supposed to work > as either host or otg. > > Changelog v4: > - Apply usb-drd.yaml schema first. If the controller is configured > to work in a gadget mode only, then apply the usb.yaml schema too, > otherwise apply the usb-xhci.yaml schema. > - Discard the Rob'es Reviewed-by tag. Please review the patch one more > time. > > Changelog v5: > - Add "snps,dis-split-quirk" property to the DWC USB3 DT schema. > - Add a commit log text about the clock-related property changes. > - Make sure dr_mode exist to apply the USB-gadget-only schema. > --- > .../devicetree/bindings/usb/dwc3.txt | 128 ------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 312 ++++++++++++++++++ > 2 files changed, 312 insertions(+), 128 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:55:4: [warning] wrong indentation: expected 4 but found 3 (indentation) dtschema/dtc warnings/errors: Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/usb/usb-drd.yaml' xargs: dt-doc-validate: exited with status 255; aborting make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 124 make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1411582 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02865C4361B for ; Mon, 7 Dec 2020 16:51:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 964B723787 for ; Mon, 7 Dec 2020 16:51:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964B723787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fesB3UxXVtLBvvMyS+PkKLxpJrUiFATPbJTwcn1K8cY=; b=itCycR7btp26bsgBHHzg114Z8 4zKEsS27ClD3gkgSVyqika3RsLnwKa+95HNvHbQ3FxT9g9/10F2mdar9CxEqyw8X764gWfmrGt1OF FnK5AYGbTRgjlgateWmq6xxwGDSxmzda/vlEK81zaSz9H32WU4QD7jd/UZm3muwEBrr573eN94Qn+ ZWlIR2Fzq3KgksOumMSrS293+21q8aE8TUYqYv2UAAb7IXqgu5b0F0rdzmQj09DfsSnpxvRDPtt3C 8z7qhrCX3FZckeUlX/NbtDERX2sPQDLr96aeVwCLjXT+twr73ieSu47hQaV/KMu7xdEOAVSfkqpGF En+D1l6Jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJhz-0004Nd-2F; Mon, 07 Dec 2020 16:49:55 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJhv-0004N0-WF; Mon, 07 Dec 2020 16:49:52 +0000 Received: by mail-ot1-f65.google.com with SMTP id o11so10377719ote.4; Mon, 07 Dec 2020 08:49:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UuU157skWGSfcX1NxkRT5BCxvQhS6DEbdRKPwY10+n0=; b=VNtOHiyPcF11TMPliAaASI5CUHy0bnbHjRvKQhQ84AlZAEFdekmX9IjEVG1kBN/x97 LXeaDyXIVfqjB/HwEb0W2UlXEOJ/tlD7OsXLYUn//kyCDz/fAhoUnPqyrrK9c35HzJ0/ FM+oYxA03exGxjA5fEU+3jd4hf0Go4Mc4pJ2z885HFaq7lwwYjvLDr3fDuFqtSHCdS1M w5GGLfprRUjMxeD56UP45F8FjXefVi0oFlZEcFcjIC9kxCfkd7kgj0rkm+pKk52uDGb0 Zn6WvMebI9FTVpXYbDK73B23MRQMZXnxndxZjp9SHjIDdZfhzyC3U+Vo92FK1iDAf1uq 9r6w== X-Gm-Message-State: AOAM531Y4jIPdRc6XiGOXO0ijQRXnIHwGjfaMSdlbzjNVylNSYUjzCJ8 6BDd0fG9gg9eA5m/YC6vZQ== X-Google-Smtp-Source: ABdhPJxmcf4zm/wuxPhsKUoUScvOLy83vfBUwi8g1uPSshO3b0CcihsttcupDMYjJmpikbuM3HuZZw== X-Received: by 2002:a9d:7304:: with SMTP id e4mr4414560otk.228.1607359790146; Mon, 07 Dec 2020 08:49:50 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x72sm3040778oia.16.2020.12.07.08.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:49:48 -0800 (PST) Received: (nullmailer pid 420892 invoked by uid 1000); Mon, 07 Dec 2020 16:49:47 -0000 Date: Mon, 7 Dec 2020 10:49:47 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 10/19] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201207164947.GA420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201205152427.29537-11-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_114952_082099_D86B963F X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 05 Dec 2020 18:24:17 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note 1. we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Note 2. The clock-related properties are marked as optional to match the > DWC USB3 driver expectation and to improve the bindings mainainability > so in case if there is a glue-node it would the responsible for the > clocks initialization. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > > Changelog v3: > - Apply usb-xhci.yaml# schema only if the controller is supposed to work > as either host or otg. > > Changelog v4: > - Apply usb-drd.yaml schema first. If the controller is configured > to work in a gadget mode only, then apply the usb.yaml schema too, > otherwise apply the usb-xhci.yaml schema. > - Discard the Rob'es Reviewed-by tag. Please review the patch one more > time. > > Changelog v5: > - Add "snps,dis-split-quirk" property to the DWC USB3 DT schema. > - Add a commit log text about the clock-related property changes. > - Make sure dr_mode exist to apply the USB-gadget-only schema. > --- > .../devicetree/bindings/usb/dwc3.txt | 128 ------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 312 ++++++++++++++++++ > 2 files changed, 312 insertions(+), 128 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:55:4: [warning] wrong indentation: expected 4 but found 3 (indentation) dtschema/dtc warnings/errors: Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/usb/usb-drd.yaml' xargs: dt-doc-validate: exited with status 255; aborting make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 124 make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1411582 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel