From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF56C0018C for ; Mon, 7 Dec 2020 16:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8827723787 for ; Mon, 7 Dec 2020 16:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbgLGQvA (ORCPT ); Mon, 7 Dec 2020 11:51:00 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42822 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgLGQvA (ORCPT ); Mon, 7 Dec 2020 11:51:00 -0500 Received: by mail-oi1-f193.google.com with SMTP id l200so16056907oig.9; Mon, 07 Dec 2020 08:50:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sVqHnk5+Qd48rsQgEdxe7AzLNS+jRVeavbI0MHrpgH8=; b=mhFKflBCMObZSH17lQMjW+k3zK24dBGsXUr6Y+btuZdO16J3yUt5JGOsFD3bRKdbS9 /9h38T7Ow3YgKGoIbdFiUYxxOf/LpMq041vSSXtMED5zSBru666D31v+uh8P8VKUPuQ9 ACeV179mAd/+Fn0PwYjttm+I/PdpTjKoKSkcgC190EzdtH/LPva/UpRvksLmBIXXh32C 6/KIWuiYiXQ0uPSCqGhul7li4HxzaSyvQCGgp7LGL8cyaAJRuJ2I7ueprfXaAxut3yih 8og4+gIPJePZ6B2mYKiBbMVbAen8s23gjE7S5DfiUtuCYGmwn4oetotp38irmw31Kl2i 41gQ== X-Gm-Message-State: AOAM532Boizf4foSujcvyXZQ2ZWR4Xu6P951zRGk+MHYSa0DbpVwmzoI aS7nr3692EcwoUDLalx2PA== X-Google-Smtp-Source: ABdhPJyi1wFJCXTTwPWZTDNSZYVtXEjaTrMTXAL1g/vcuUtmd8ZXTbe7OhMA8bMQ/ovZiNG8xiPfvg== X-Received: by 2002:aca:ccc1:: with SMTP id c184mr10424948oig.121.1607359813295; Mon, 07 Dec 2020 08:50:13 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j62sm2730022otc.49.2020.12.07.08.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:50:12 -0800 (PST) Received: (nullmailer pid 421441 invoked by uid 1000); Mon, 07 Dec 2020 16:50:10 -0000 Date: Mon, 7 Dec 2020 10:50:10 -0600 From: Rob Herring To: Serge Semin Cc: Alexey Malahov , linux-usb@vger.kernel.org, Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, Greg Kroah-Hartman , Mathias Nyman , devicetree@vger.kernel.org, Bjorn Andersson , Kevin Hilman , Ahmad Zainie , Pavel Parkhomenko , Krzysztof Kozlowski , Roger Quadros , linux-kernel@vger.kernel.org, Chunfeng Yun , Neil Armstrong , Lad Prabhakar , Andy Gross , Felipe Balbi , Rob Herring , Manu Gautam , Serge Semin , Martin Blumenstingl Subject: Re: [PATCH v5 01/19] dt-bindings: usb: usb-hcd: Detach generic USB controller properties Message-ID: <20201207165010.GB420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 05 Dec 2020 18:24:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect common properties in a common DT schema and specific > properties in dedicated schemas. Seeing the usb-hcd.yaml DT schema is > dedicated for the USB host controllers only, let's move some common > properties from there into the usb.yaml schema. So the later would be > available to evaluate all currently supported types of the USB > controllers. > > While at it add an explicit "additionalProperties: true" into the > usb-hcd.yaml as setting the additionalProperties/unevaluateProperties > properties is going to be get mandatory soon. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created as a result of the comment left > by Chunfeng Yun in v3 > > Changelog v5: > - Discard duplicated additionalProperties property definition. > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 14 ++------- > .../devicetree/bindings/usb/usb.yaml | 29 +++++++++++++++++++ > 2 files changed, 31 insertions(+), 12 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/usb.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: 'anyOf' conditional failed, one must be fixed: 'properties' is a required property 'patternProperties' is a required property schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/usb/usb-hcd.yaml schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema dt-validate: recursion error: Check for prior errors in a referenced schema See https://patchwork.ozlabs.org/patch/1411574 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA52C4361B for ; Mon, 7 Dec 2020 16:54:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2AC623888 for ; Mon, 7 Dec 2020 16:54:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2AC623888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CqTt224bJzDqWh for ; Tue, 8 Dec 2020 03:54:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.195; helo=mail-oi1-f195.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CqTnh3yFHzDqVV for ; Tue, 8 Dec 2020 03:50:16 +1100 (AEDT) Received: by mail-oi1-f195.google.com with SMTP id v85so5511286oia.6 for ; Mon, 07 Dec 2020 08:50:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sVqHnk5+Qd48rsQgEdxe7AzLNS+jRVeavbI0MHrpgH8=; b=Mkv4zgGQZEXQgdAOkMiAMBPz5GKBKRJ+Cic0t8Yt6BhvZxYoc5OfLoBnw2A2sMV/an YGQ0B8oHgGqcrevgA91dR0ObR3xFmW1kinR5pjbELLvPZ0Ta1hRmBcPluXDaPsrUFQSI KyO5twkqBARMxxszA5VfckIJV6SqTKJEXDuBHqGDIhH/EAdkVpYmDDfRvLidNCwcxvsD hL9yuQ+hsYGUfMRENZBYK7NKYkHAVXF+czMDaAQCuorS065+4YUnYWH576Rc7anzT6/g +XfgPGbhD5NnOTOWe16lUHUSGJ7409olTr67v55LI8rJAW7NAseHzGLaCoTfvV+WIVEZ ryAw== X-Gm-Message-State: AOAM533ZuoqAgKbIR7u1GsXOYlPK00J/Y/hjqopOYlXU4ySUctF/CMMV +OjJ2xMaVAUWYuRcD+77tw== X-Google-Smtp-Source: ABdhPJyi1wFJCXTTwPWZTDNSZYVtXEjaTrMTXAL1g/vcuUtmd8ZXTbe7OhMA8bMQ/ovZiNG8xiPfvg== X-Received: by 2002:aca:ccc1:: with SMTP id c184mr10424948oig.121.1607359813295; Mon, 07 Dec 2020 08:50:13 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j62sm2730022otc.49.2020.12.07.08.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:50:12 -0800 (PST) Received: (nullmailer pid 421441 invoked by uid 1000); Mon, 07 Dec 2020 16:50:10 -0000 Date: Mon, 7 Dec 2020 10:50:10 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 01/19] dt-bindings: usb: usb-hcd: Detach generic USB controller properties Message-ID: <20201207165010.GB420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 05 Dec 2020 18:24:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect common properties in a common DT schema and specific > properties in dedicated schemas. Seeing the usb-hcd.yaml DT schema is > dedicated for the USB host controllers only, let's move some common > properties from there into the usb.yaml schema. So the later would be > available to evaluate all currently supported types of the USB > controllers. > > While at it add an explicit "additionalProperties: true" into the > usb-hcd.yaml as setting the additionalProperties/unevaluateProperties > properties is going to be get mandatory soon. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created as a result of the comment left > by Chunfeng Yun in v3 > > Changelog v5: > - Discard duplicated additionalProperties property definition. > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 14 ++------- > .../devicetree/bindings/usb/usb.yaml | 29 +++++++++++++++++++ > 2 files changed, 31 insertions(+), 12 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/usb.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: 'anyOf' conditional failed, one must be fixed: 'properties' is a required property 'patternProperties' is a required property schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/usb/usb-hcd.yaml schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema dt-validate: recursion error: Check for prior errors in a referenced schema See https://patchwork.ozlabs.org/patch/1411574 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00271C433FE for ; Mon, 7 Dec 2020 16:50:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96E4823787 for ; Mon, 7 Dec 2020 16:50:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96E4823787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DuSk91yzLkbn7YQ1vLESuPOdrlMMs1wluv9hb2huIiU=; b=cGNUCYrtzbdoPaKrqE7pWTYT1 jRxiI72wX5ieBwSFZkUKmtYIPbgdAf5GPP7x86OBg7SRMCncaxrYcuql4Ke0F52/iEFv/Jg60tbE2 pOUNaLV/BXnkTbGwJ6Ms1vLQEnF6DdYLGh5ZZFAUIYsZl7NVaOEj2J2cSjea7nChebnZVdTCLSjAt V16TqQopZ22iccI+W7ALok1Uj1T48Iy3AkToRGzInq1PTummaL8rwmAnlSyfZ85N7JQAiLwLpedlw c28nocEZUIfPRS9iMn4f3AuUVB0ZqWniEmyXueMspTI5iJFSc2ZHsQdQUSBysU/sk7aQzVIUn6aOz F1DZYxewg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJiN-0004RS-PS; Mon, 07 Dec 2020 16:50:19 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJiI-0004Ps-3p; Mon, 07 Dec 2020 16:50:14 +0000 Received: by mail-oi1-f194.google.com with SMTP id 15so4889988oix.8; Mon, 07 Dec 2020 08:50:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sVqHnk5+Qd48rsQgEdxe7AzLNS+jRVeavbI0MHrpgH8=; b=G6j7ptQtpE1QNzzRZ+1f5YS7pWK7rcZ0Gj+30EFqcySM8uisB0g2EI+ShgDF2QFlau ZD/H5R8ZtBH0+PjHwH8dqpg0hMCcVq9SqoE6R2E4RtsZlK46xlPaXzBnvxB50ipMAbj+ +yq0ge0Nl225sqwkdbBSyG7TjQ0Ho0x4mIWKJs85hFe1rz+m6sbTKJFZxdILz/guhUEQ AOu1rsyz82lkkyxTPEtoDhT8AhGnv91duNOOfQI43VXrnc0/g1yxnPw4zGFBk2HPP709 eGHTM4TAMIQxpjtfXXK9vROiXs2EJNIJ1EpIExquhd09fLbiA7BvTHyMKDKxCjpxcbNN dAQw== X-Gm-Message-State: AOAM531sQkRRdvlWkey9hFLcTFUlaL2HUQXejsQbnbIRkzbKJ/5hMkp0 xbXGHHCVGgz3sxgP4lizqw== X-Google-Smtp-Source: ABdhPJyi1wFJCXTTwPWZTDNSZYVtXEjaTrMTXAL1g/vcuUtmd8ZXTbe7OhMA8bMQ/ovZiNG8xiPfvg== X-Received: by 2002:aca:ccc1:: with SMTP id c184mr10424948oig.121.1607359813295; Mon, 07 Dec 2020 08:50:13 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j62sm2730022otc.49.2020.12.07.08.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:50:12 -0800 (PST) Received: (nullmailer pid 421441 invoked by uid 1000); Mon, 07 Dec 2020 16:50:10 -0000 Date: Mon, 7 Dec 2020 10:50:10 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 01/19] dt-bindings: usb: usb-hcd: Detach generic USB controller properties Message-ID: <20201207165010.GB420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_115014_191997_7F372617 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Sat, 05 Dec 2020 18:24:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect common properties in a common DT schema and specific > properties in dedicated schemas. Seeing the usb-hcd.yaml DT schema is > dedicated for the USB host controllers only, let's move some common > properties from there into the usb.yaml schema. So the later would be > available to evaluate all currently supported types of the USB > controllers. > > While at it add an explicit "additionalProperties: true" into the > usb-hcd.yaml as setting the additionalProperties/unevaluateProperties > properties is going to be get mandatory soon. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created as a result of the comment left > by Chunfeng Yun in v3 > > Changelog v5: > - Discard duplicated additionalProperties property definition. > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 14 ++------- > .../devicetree/bindings/usb/usb.yaml | 29 +++++++++++++++++++ > 2 files changed, 31 insertions(+), 12 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/usb.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: 'anyOf' conditional failed, one must be fixed: 'properties' is a required property 'patternProperties' is a required property schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/usb/usb-hcd.yaml schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema dt-validate: recursion error: Check for prior errors in a referenced schema See https://patchwork.ozlabs.org/patch/1411574 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDA6C4361B for ; Mon, 7 Dec 2020 16:51:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5DAB23787 for ; Mon, 7 Dec 2020 16:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5DAB23787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nzlhMWZy9WzVQTMg6L0y4jiRXrc6dJu7XY3UbzR9hkk=; b=C914QwErNjtgPD21ctocECbWB 6jjjepwP2hLj0ki6dj3L4545BfjRmlub5TPSU/eKkAZFPIkrrZv2C4FyDfQGdNYyF4UfUyyYKI5CI yE/YPf/EuiAEBcC0lkFJC+r/7yS22izu41xceGWQW1X79OG3IFdqAsEWNCFzzJ5IHZ83U26EP2PYd 7E3ArMEE8PbFjQF+W9lyV2vd39fSRKvpyCSgnGmgjmZVUGjfiF8b4ma/h5j0uBDVUYmr+H+/GcWuq H7AhLExl0h9P76sUUGHBKQfbxrJKYMl05ggRqjvPV9iX3tX+m+HkgrxpzVouya5fCqRsRpfnzWdkM 9gQ80fiCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJiL-0004Qd-2l; Mon, 07 Dec 2020 16:50:17 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmJiI-0004Ps-3p; Mon, 07 Dec 2020 16:50:14 +0000 Received: by mail-oi1-f194.google.com with SMTP id 15so4889988oix.8; Mon, 07 Dec 2020 08:50:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sVqHnk5+Qd48rsQgEdxe7AzLNS+jRVeavbI0MHrpgH8=; b=G6j7ptQtpE1QNzzRZ+1f5YS7pWK7rcZ0Gj+30EFqcySM8uisB0g2EI+ShgDF2QFlau ZD/H5R8ZtBH0+PjHwH8dqpg0hMCcVq9SqoE6R2E4RtsZlK46xlPaXzBnvxB50ipMAbj+ +yq0ge0Nl225sqwkdbBSyG7TjQ0Ho0x4mIWKJs85hFe1rz+m6sbTKJFZxdILz/guhUEQ AOu1rsyz82lkkyxTPEtoDhT8AhGnv91duNOOfQI43VXrnc0/g1yxnPw4zGFBk2HPP709 eGHTM4TAMIQxpjtfXXK9vROiXs2EJNIJ1EpIExquhd09fLbiA7BvTHyMKDKxCjpxcbNN dAQw== X-Gm-Message-State: AOAM531sQkRRdvlWkey9hFLcTFUlaL2HUQXejsQbnbIRkzbKJ/5hMkp0 xbXGHHCVGgz3sxgP4lizqw== X-Google-Smtp-Source: ABdhPJyi1wFJCXTTwPWZTDNSZYVtXEjaTrMTXAL1g/vcuUtmd8ZXTbe7OhMA8bMQ/ovZiNG8xiPfvg== X-Received: by 2002:aca:ccc1:: with SMTP id c184mr10424948oig.121.1607359813295; Mon, 07 Dec 2020 08:50:13 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j62sm2730022otc.49.2020.12.07.08.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 08:50:12 -0800 (PST) Received: (nullmailer pid 421441 invoked by uid 1000); Mon, 07 Dec 2020 16:50:10 -0000 Date: Mon, 7 Dec 2020 10:50:10 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v5 01/19] dt-bindings: usb: usb-hcd: Detach generic USB controller properties Message-ID: <20201207165010.GB420349@robh.at.kernel.org> References: <20201205152427.29537-1-Sergey.Semin@baikalelectronics.ru> <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201205152427.29537-2-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_115014_191997_7F372617 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-mips@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Krzysztof Kozlowski , Ahmad Zainie , Andy Gross , Chunfeng Yun , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Martin Blumenstingl , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 05 Dec 2020 18:24:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect common properties in a common DT schema and specific > properties in dedicated schemas. Seeing the usb-hcd.yaml DT schema is > dedicated for the USB host controllers only, let's move some common > properties from there into the usb.yaml schema. So the later would be > available to evaluate all currently supported types of the USB > controllers. > > While at it add an explicit "additionalProperties: true" into the > usb-hcd.yaml as setting the additionalProperties/unevaluateProperties > properties is going to be get mandatory soon. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created as a result of the comment left > by Chunfeng Yun in v3 > > Changelog v5: > - Discard duplicated additionalProperties property definition. > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 14 ++------- > .../devicetree/bindings/usb/usb.yaml | 29 +++++++++++++++++++ > 2 files changed, 31 insertions(+), 12 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/usb.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: 'anyOf' conditional failed, one must be fixed: 'properties' is a required property 'patternProperties' is a required property schemas/usb/usb-hcd.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb-hcd.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/usb/usb-hcd.yaml schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema schemas/usb/usb-hcd.yaml: ignoring, error in schema: dt-validate: recursion error: Check for prior errors in a referenced schema dt-validate: recursion error: Check for prior errors in a referenced schema See https://patchwork.ozlabs.org/patch/1411574 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel