From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0BEC433FE for ; Mon, 7 Dec 2020 21:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6B7323440 for ; Mon, 7 Dec 2020 21:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbgLGVAf (ORCPT ); Mon, 7 Dec 2020 16:00:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgLGVAf (ORCPT ); Mon, 7 Dec 2020 16:00:35 -0500 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E18BCC061749 for ; Mon, 7 Dec 2020 12:59:54 -0800 (PST) Received: by mail-qk1-x735.google.com with SMTP id 19so6493208qkm.8 for ; Mon, 07 Dec 2020 12:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SsoIYjBoSOJL9ZsEeEbVAcU4nkxuyAtiLgrYShov/wE=; b=i1it63IPF7Tvk8uDkG0531W5MNt7LWyQnwaM2j4BTI/61OlhQiI+VJ+wpKpxZtDvPg vEbdjngT0eARrKE1T1aDZ5DUhPlRd6VaejmMAMYVKthNBOHrPSsuBBQ1ZuENokzB6dtF yhrP4xK+GkxHP/lT20KBd8CQD8v9ddhEUt4KyKzk90DAVyxhAhPv2/fOScXi86WtSoDS pxFsfOu40Viw5B0+ZIGnOOGOs/6fZWDZT73kzeOZ+cW8r4ZP6WIiNfwcU4nfgYwCvIn9 HnuENOVvoflwLViv82Sro/eJNtOgTprMrJh9VG29iHH8wAWpwGeiaNDBl54i69ekJJuK THvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SsoIYjBoSOJL9ZsEeEbVAcU4nkxuyAtiLgrYShov/wE=; b=jJtBPy8p2VpZaMnqAcKLRu7zS02Y5y5TRDcBnD41v/e7jk1ZJuetrWb48AoDn8xrS1 W1CV3fZvHTM/JSJ0ZX+0wEuBHjw2q9D8/cd2f9ja4pXQz+6HXbSEC4KNeM1gtmc45jjM yaYS0iiFf9livTo9Zt8rl48r0xhE3WoqYfyFVyho0mRzN3lytb2e3/g6aotjEKXRVX0/ LMBMyp6U2BiAMdxvvfr96qIyQYs1jBLP8iBa+xyN7qVfRk6zvLZWGMLZcIXozsW7QKu4 NbmhH7NXin7Chj2SSNHEpxfRSc/7+BOVohcbU+IKcFAahY18TYYOC2Bd+F+vWBWXQzbI xNlw== X-Gm-Message-State: AOAM531PNUeUmnA/RGMoShpJNlY55N+fINPADMmK6C3+Q0jVuoaH0TX4 CfRokbuNx+t+47WqdpYiqj9bGA== X-Google-Smtp-Source: ABdhPJy/AObM5SP970JiKVbzk0clsLDS7Pku3nuk+S/w0OWrxn3W3HE1Z7GvrEj0qJrW03GFHY7u/Q== X-Received: by 2002:a05:620a:138b:: with SMTP id k11mr25874513qki.323.1607374794219; Mon, 07 Dec 2020 12:59:54 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id s8sm11621645qtw.61.2020.12.07.12.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 12:59:53 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kmNbs-007fZb-Sn; Mon, 07 Dec 2020 16:59:52 -0400 Date: Mon, 7 Dec 2020 16:59:52 -0400 From: Jason Gunthorpe To: Thomas Gleixner Cc: LKML , Alexandre Belloni , Miroslav Lichvar , John Stultz , Prarit Bhargava , Alessandro Zummo , linux-rtc@vger.kernel.org, Peter Zijlstra Subject: Re: [patch 6/8] ntp, rtc: Move rtc_set_ntp_time() to ntp code Message-ID: <20201207205952.GL5487@ziepe.ca> References: <20201206214613.444124194@linutronix.de> <20201206220542.166871172@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201206220542.166871172@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 06, 2020 at 10:46:19PM +0100, Thomas Gleixner wrote: > rtc_set_ntp_time() is not really RTC functionality as the code is just a > user of RTC. Move it into the NTP code which allows further cleanups. > > Requested-by: Alexandre Belloni > Signed-off-by: Thomas Gleixner > --- > drivers/rtc/Makefile | 1 > drivers/rtc/systohc.c | 61 ---------------------------------- > include/linux/rtc.h | 34 ------------------- > kernel/time/ntp.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++-- > 4 files changed, 85 insertions(+), 99 deletions(-) Fair enough, it is asymmetric with how HCTOSYS works, but not a big deal Reviewed-by: Jason Gunthorpe Jason