From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9E9C433FE for ; Tue, 8 Dec 2020 03:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64E2D238E8 for ; Tue, 8 Dec 2020 03:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbgLHDPx (ORCPT ); Mon, 7 Dec 2020 22:15:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50624 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgLHDPw (ORCPT ); Mon, 7 Dec 2020 22:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607397266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mthuFi5TW9YsKTeZpnIHZUZ93ckX2z2UHw2lFllgY/0=; b=TIhed8bOwJ6uzgkc9VAfoWSw2dRqsE4hTczOhgR5Mh8YBqEy+sBfIq0VmUKG6BkTgfLQB+ CKAnjheT5Gabqi/zkOaRIIADindLNHQYWpPrM1zxcm/QsGPsbXEKptMVCRl/zwL33HvUsJ H/YKhSrSjOPDnzohrzqwQT1W/hbzrBo= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-WvlGpe9xNWiKvMT0yM9qVg-1; Mon, 07 Dec 2020 22:14:24 -0500 X-MC-Unique: WvlGpe9xNWiKvMT0yM9qVg-1 Received: by mail-pl1-f197.google.com with SMTP id e11so5980882pld.0 for ; Mon, 07 Dec 2020 19:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mthuFi5TW9YsKTeZpnIHZUZ93ckX2z2UHw2lFllgY/0=; b=SVWIE7BSqfmvegPJYwOSSHHKXyqXx/3Qc6+MdGQsJVmmKu1NzB3xYjxZTbz6KuAxr5 0PV5jwNQ0PTpyU9POnYbdAZWNmzBW8h1yp6KnwhiafjbvP7XRzabVov2zvpBMI0NZckD LnMaBDTjkZaWqOfRdwUNkxaqHpqUKbC5D6zC+ilSZiKFcuWTAK3QJU4yb2YeTQta2glV 302MxtUIw+ORXn1D4RRcpvIi0aBiG6+agQ/vpsw//NnCeZxIfYgV+38NapykZkx+ugeb E8z4S0PNfE37TOR1Jl11VaUwlJBqPBTea+ZOcLeP2UcBATIzNAgdSlnQ2IRfxhUB8DvM rCwA== X-Gm-Message-State: AOAM5329l7PfoDdMcl87V6tS9CBfucojIixPJto/fBAPTfNw+MJpOQXy yY3EBmV29bdHUFM/cQTbxG+83b7VGyWF30zjjxUPehWGsxX/XRTGk1blW0pnsYEL0FoBQ6yepK2 056qJB9CTF9RLBRH0bu9Xy33M X-Received: by 2002:a63:1346:: with SMTP id 6mr21055465pgt.330.1607397263334; Mon, 07 Dec 2020 19:14:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyL9m0kS6AeCJmmwicuLitmZb+KGqh/Eyv/pgMonwN3yI3VDUnAIQSSKutvLGtoYviZJC0HeQ== X-Received: by 2002:a63:1346:: with SMTP id 6mr21055447pgt.330.1607397263111; Mon, 07 Dec 2020 19:14:23 -0800 (PST) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id c6sm13738832pgl.38.2020.12.07.19.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 19:14:22 -0800 (PST) Date: Tue, 8 Dec 2020 11:14:12 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , Chao Yu , Chao Yu Subject: Re: [PATCH v2 1/3] erofs: get rid of magical Z_EROFS_MAPPING_STAGING Message-ID: <20201208031412.GA3006985@xiangao.remote.csb> References: <20201207012346.2713857-1-hsiangkao@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201207012346.2713857-1-hsiangkao@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, On Mon, Dec 07, 2020 at 09:23:44AM +0800, Gao Xiang wrote: > Previously, we played around with magical page->mapping for short-lived > temporary pages since we need to identify different types of pages in > the same pcluster but both invalidated and short-lived temporary pages > can have page->mapping == NULL. It was considered as safe because that > temporary pages are all non-LRU / non-movable pages. > > This patch tends to use specific page->private to identify short-lived > pages instead so it won't rely on page->mapping anymore. Details are > described in "compress.h" as well. > > Signed-off-by: Gao Xiang > --- > tested with ro_fsstress for a whole night. > > The old "[PATCH 4/4] erofs: complete a missing case for inplace I/O" is > temporarily dropped since ro_fsstress failed with such modification, > will look into later. > Do you have some extra bandwidth to review these commits? plus a commit from Vladimir Zapolskiy: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/commit/?id=c8390cfaa07cb9e9ccaa946a1919b69dfb34bad1 The merge window will be open the next week. I have to prepare the submission from now. Thanks, Gao Xiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C742BC4361B for ; Tue, 8 Dec 2020 03:14:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5D8623A58 for ; Tue, 8 Dec 2020 03:14:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5D8623A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Cqlf74cJHzDqYB for ; Tue, 8 Dec 2020 14:14:39 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=hsiangkao@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TIhed8bO; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TIhed8bO; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Cqlf03tCzzDqW4 for ; Tue, 8 Dec 2020 14:14:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607397266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mthuFi5TW9YsKTeZpnIHZUZ93ckX2z2UHw2lFllgY/0=; b=TIhed8bOwJ6uzgkc9VAfoWSw2dRqsE4hTczOhgR5Mh8YBqEy+sBfIq0VmUKG6BkTgfLQB+ CKAnjheT5Gabqi/zkOaRIIADindLNHQYWpPrM1zxcm/QsGPsbXEKptMVCRl/zwL33HvUsJ H/YKhSrSjOPDnzohrzqwQT1W/hbzrBo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607397266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mthuFi5TW9YsKTeZpnIHZUZ93ckX2z2UHw2lFllgY/0=; b=TIhed8bOwJ6uzgkc9VAfoWSw2dRqsE4hTczOhgR5Mh8YBqEy+sBfIq0VmUKG6BkTgfLQB+ CKAnjheT5Gabqi/zkOaRIIADindLNHQYWpPrM1zxcm/QsGPsbXEKptMVCRl/zwL33HvUsJ H/YKhSrSjOPDnzohrzqwQT1W/hbzrBo= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-2VZ1zaJfOPO_zI2K2H6Qxg-1; Mon, 07 Dec 2020 22:14:24 -0500 X-MC-Unique: 2VZ1zaJfOPO_zI2K2H6Qxg-1 Received: by mail-pl1-f198.google.com with SMTP id c12so5979346pll.12 for ; Mon, 07 Dec 2020 19:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mthuFi5TW9YsKTeZpnIHZUZ93ckX2z2UHw2lFllgY/0=; b=D9zHrRLrchBllrzrlKPvbJLXeuIhi5qtOujj7RaHSEfndNuk56HfKZ0l4amqHUMIJB bajyQoccP1Mgw8MGraMPuhGrB0qxwvWFFk1f3QGbDcxC8JvtO8tymXGzQwrTSQcNtu1t 6L53haEbZ32KhTHKcIaqqQsO36THLRNK5MNJ9RSzNw+CryO/JsNh9VKis4GSe60tgOVe 2KWu8rwVfMNH8X1/NqUPrTX4xrZO7S9BMnQ8z53Ynbim/QhcOYht84VYPQ+QssMNHFsc R16uH8wDeDWIlY3fMUIjrggtvNGAUaes7/tjNSifdUw9Jm6psbKkDlfy3EGRcdcmyS22 7oqw== X-Gm-Message-State: AOAM532DH8xMiNmxj3jZx69Gvb5oVZGsHrLFwSnjp1P4trC0nN8ukPO6 QQEIpKNxrDSiDk1DSeQVqiUlSZMgoiwJyC5p2Mql/wonhBc1hOC9qoPcmiL2duC5XXbEpclmY9b VKGa/vWyfp7fiICDNAoZGuHuouyAhc8u3qDpaYzFVn/KESDIVwCAUPOye99HAvqMuUyACxsIKg8 10+Q== X-Received: by 2002:a63:1346:: with SMTP id 6mr21055469pgt.330.1607397263396; Mon, 07 Dec 2020 19:14:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyL9m0kS6AeCJmmwicuLitmZb+KGqh/Eyv/pgMonwN3yI3VDUnAIQSSKutvLGtoYviZJC0HeQ== X-Received: by 2002:a63:1346:: with SMTP id 6mr21055447pgt.330.1607397263111; Mon, 07 Dec 2020 19:14:23 -0800 (PST) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id c6sm13738832pgl.38.2020.12.07.19.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 19:14:22 -0800 (PST) Date: Tue, 8 Dec 2020 11:14:12 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Subject: Re: [PATCH v2 1/3] erofs: get rid of magical Z_EROFS_MAPPING_STAGING Message-ID: <20201208031412.GA3006985@xiangao.remote.csb> References: <20201207012346.2713857-1-hsiangkao@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201207012346.2713857-1-hsiangkao@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hsiangkao@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Hi Chao, On Mon, Dec 07, 2020 at 09:23:44AM +0800, Gao Xiang wrote: > Previously, we played around with magical page->mapping for short-lived > temporary pages since we need to identify different types of pages in > the same pcluster but both invalidated and short-lived temporary pages > can have page->mapping == NULL. It was considered as safe because that > temporary pages are all non-LRU / non-movable pages. > > This patch tends to use specific page->private to identify short-lived > pages instead so it won't rely on page->mapping anymore. Details are > described in "compress.h" as well. > > Signed-off-by: Gao Xiang > --- > tested with ro_fsstress for a whole night. > > The old "[PATCH 4/4] erofs: complete a missing case for inplace I/O" is > temporarily dropped since ro_fsstress failed with such modification, > will look into later. > Do you have some extra bandwidth to review these commits? plus a commit from Vladimir Zapolskiy: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/commit/?id=c8390cfaa07cb9e9ccaa946a1919b69dfb34bad1 The merge window will be open the next week. I have to prepare the submission from now. Thanks, Gao Xiang