From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4287DC4167B for ; Tue, 8 Dec 2020 08:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E77CC23A7E for ; Tue, 8 Dec 2020 08:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbgLHIux (ORCPT ); Tue, 8 Dec 2020 03:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbgLHIux (ORCPT ); Tue, 8 Dec 2020 03:50:53 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CFBC061749 for ; Tue, 8 Dec 2020 00:50:12 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id f23so23531282ejk.2 for ; Tue, 08 Dec 2020 00:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=FZ0lHPANfEWsj+/iVtzHykLTQO6ijRLMLun67MC83GxuH1p2GZvrYjVFI3LNftNYmi /WF/Ppj7Wq5wn6x5qlhZ7poOpmvIzR9WmdgY8pxNF30wGY0Co7IAbS2881d+bH0E6Byn bpioRfSGZZ4HMfmUGGDYIBx8I9lWUbAfa90kVnGyoX+TsCLBzuOSbLyiDTiWf1LMert8 UgTYEKxN95dU+dYig9SnYr/1zjEk7X1WFDFui6Zn9YsLNmnCV9FZ9w0tvEVe2ihnVf8w L9O0G22F2V+wSKewS6KowfEZDIuF/m1OLAcCf+VIX9oZBeQmp9GyjwPdaUayPjCGVMO+ P38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=uEqXlfN2fs47QO+iIzwr66alR/NRggE8BRU2L7NDWTUE1+OBe76UZjBTbShIDMTLp2 /ymyXRP79AlKMHI6KOoZpV3mMypeB3DeaQtDP+cxz3p8v+DRx5dv4+L231maRpDpUIFn OU9/YjoQcHhr6MDfJjKUz7zbN8VMh6xdWSPfOh+gi6EvEXeQbrL3M4jiQnZG3m8nsEG7 29DGtv6fcmEI4U55XG+Jrl9jlElwFKUrUtWrmm9EKSHfi0TSUfZjy+ILaSld6VwUoxws +55o0gFLvzW3CX4+LKOAwt1aj4hqi0dvAUw2qC953puJXtiG4TSXQfrmGYWj9hcaMP3f wl0g== X-Gm-Message-State: AOAM530VDIOTzCMdbOV14YfGADX2P01f9ijXKuTEmT+BKeJKflVTO9wj a0Irx4Zo/CPeCLsILcR5QPU= X-Google-Smtp-Source: ABdhPJww+kwZb8018JvYoa53FIBJf92vPUO/fyV4DEOGl5s9UG9EkjlxM/dxQWfVsgIsKRCS5yIpUg== X-Received: by 2002:a17:906:3c11:: with SMTP id h17mr21899491ejg.20.1607417411619; Tue, 08 Dec 2020 00:50:11 -0800 (PST) Received: from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id d6sm14878522ejy.114.2020.12.08.00.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:50:10 -0800 (PST) Date: Tue, 8 Dec 2020 08:50:09 +0000 From: Stefan Hajnoczi To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: qemu-devel@nongnu.org, Lars Ganrot , virtualization@lists.linux-foundation.org, Salil Mehta , "Michael S. Tsirkin" , Liran Alon , Rob Miller , Max Gurtovoy , Alex Barba , Stefan Hajnoczi , Jim Harford , Jason Wang , Harpreet Singh Anand , Christophe Fontaine , vm , Daniel Daly , Michael Lilja , Stefano Garzarella , Nitin Shrivastav , Lee Ballard , Dmytro Kazantsev , Juan Quintela , kvm@vger.kernel.org, Howard Cai , Xiao W Wang , Sean Mooney , Parav Pandit , Eli Cohen , Siwei Liu , Stephen Finucane Subject: Re: [RFC PATCH 20/27] vhost: Return used buffers Message-ID: <20201208085009.GV203660@stefanha-x1.localdomain> References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-21-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t" Content-Disposition: inline In-Reply-To: <20201120185105.279030-21-eperezma@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org --YnIutncTLXsDZs5t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 20, 2020 at 07:50:58PM +0100, Eugenio P=E9rez wrote: > @@ -1028,6 +1061,7 @@ static int vhost_sw_live_migration_start(struct vho= st_dev *dev) > =20 > for (idx =3D 0; idx < dev->nvqs; ++idx) { > struct vhost_virtqueue *vq =3D &dev->vqs[idx]; > + unsigned num =3D virtio_queue_get_num(dev->vdev, idx); > struct vhost_vring_addr addr =3D { > .index =3D idx, > }; > @@ -1044,6 +1078,12 @@ static int vhost_sw_live_migration_start(struct vh= ost_dev *dev) > r =3D dev->vhost_ops->vhost_set_vring_addr(dev, &addr); > assert(r =3D=3D 0); > =20 > + r =3D vhost_backend_update_device_iotlb(dev, addr.used_user_addr, > + addr.used_user_addr, > + sizeof(vring_used_elem_t) = * num, > + IOMMU_RW); I don't remember seeing iotlb setup for the rest of the vring or guest memory. Maybe this should go into a single patch so it's easy to review the iova space layout. --YnIutncTLXsDZs5t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl/PPkEACgkQnKSrs4Gr c8jbGwf+OqBpKYq3vRs1xwb03191eAU1RZXGSRe283/ocJlVX8EMuoRMZPbbEXgt +OqCILt/QQuvQloLfm23ggS9XXUgKfQSPG16bFM0RE6j5lDUqDWESbduxFWxWl5k YAZhTPElTlaGeJbRpW4Ls2bqKSIkd77wtZu+AdPGGfr6IiZxE2rC3Rut3qhzl6A4 C2dhtR3TPweeG5bL8ls6tv3t9+J0n4tap8b93aX920+9ksgj1uYEZNjRk6jEWiMG 2vy5eEgE/SJcaNSFafSgYQGGscP3nAHCcwgkUs7MjiGyVXiMNi0xDGunPdQ1R/f/ /Sto7Mj12OlDF0kbMRUuNi5FfF3wOA== =vcmP -----END PGP SIGNATURE----- --YnIutncTLXsDZs5t-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C062AC4361B for ; Tue, 8 Dec 2020 08:51:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01B3023A79 for ; Tue, 8 Dec 2020 08:51:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01B3023A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmYiI-0001RM-IU for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 03:51:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmYhK-0000tn-M0 for qemu-devel@nongnu.org; Tue, 08 Dec 2020 03:50:14 -0500 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:37691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmYhJ-0004vC-23 for qemu-devel@nongnu.org; Tue, 08 Dec 2020 03:50:14 -0500 Received: by mail-ej1-x641.google.com with SMTP id ga15so23520009ejb.4 for ; Tue, 08 Dec 2020 00:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=FZ0lHPANfEWsj+/iVtzHykLTQO6ijRLMLun67MC83GxuH1p2GZvrYjVFI3LNftNYmi /WF/Ppj7Wq5wn6x5qlhZ7poOpmvIzR9WmdgY8pxNF30wGY0Co7IAbS2881d+bH0E6Byn bpioRfSGZZ4HMfmUGGDYIBx8I9lWUbAfa90kVnGyoX+TsCLBzuOSbLyiDTiWf1LMert8 UgTYEKxN95dU+dYig9SnYr/1zjEk7X1WFDFui6Zn9YsLNmnCV9FZ9w0tvEVe2ihnVf8w L9O0G22F2V+wSKewS6KowfEZDIuF/m1OLAcCf+VIX9oZBeQmp9GyjwPdaUayPjCGVMO+ P38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=PzAFvH/THVwXltDfMnBy1AfjDGQJxxFIuwiGkY/+nM3CHeZ8yWqroDyNC/5UDsgGeO uLVBDCZOdwA8KJ62oFf7jLnbnA9rljZSWVN8P2BOM4SIYShrxThULLx0FIlwgZPu3hly wMBl3eQQ1HaJWcAqvS++I358Z9YaCUDhPWa8nXY8QzNS6nUCd+SNbkhEEC6X63VGFS5a ASTxFtqpYnddj7vLWD1+SJ1O4zKI+sQVWd+HzG8OJrJBDo4KWXp1xyQeBishO7nmpPFd THWdLENDl6rqmr06UWLA6q4d7B3STReTXJK/Or9Kppf6vvC8O6Gxp+oCK4SDq2COUSmU 36kg== X-Gm-Message-State: AOAM531Q3nx7UfG+9bw6MLMJqVMXHgTpFjfySSiFyJByTfe7QiHU+f2i MQr7vJ9zsG9oJGUXO9lUbKg= X-Google-Smtp-Source: ABdhPJww+kwZb8018JvYoa53FIBJf92vPUO/fyV4DEOGl5s9UG9EkjlxM/dxQWfVsgIsKRCS5yIpUg== X-Received: by 2002:a17:906:3c11:: with SMTP id h17mr21899491ejg.20.1607417411619; Tue, 08 Dec 2020 00:50:11 -0800 (PST) Received: from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id d6sm14878522ejy.114.2020.12.08.00.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:50:10 -0800 (PST) Date: Tue, 8 Dec 2020 08:50:09 +0000 From: Stefan Hajnoczi To: Eugenio =?iso-8859-1?Q?P=E9rez?= Subject: Re: [RFC PATCH 20/27] vhost: Return used buffers Message-ID: <20201208085009.GV203660@stefanha-x1.localdomain> References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-21-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t" Content-Disposition: inline In-Reply-To: <20201120185105.279030-21-eperezma@redhat.com> Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=stefanha@gmail.com; helo=mail-ej1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Daniel Daly , virtualization@lists.linux-foundation.org, Liran Alon , Eli Cohen , Nitin Shrivastav , Alex Barba , Christophe Fontaine , Juan Quintela , Lee Ballard , Lars Ganrot , Rob Miller , Stefano Garzarella , Howard Cai , Parav Pandit , vm , Salil Mehta , Stephen Finucane , Xiao W Wang , Sean Mooney , Stefan Hajnoczi , Jim Harford , Dmytro Kazantsev , Siwei Liu , Harpreet Singh Anand , Michael Lilja , Max Gurtovoy Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --YnIutncTLXsDZs5t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 20, 2020 at 07:50:58PM +0100, Eugenio P=E9rez wrote: > @@ -1028,6 +1061,7 @@ static int vhost_sw_live_migration_start(struct vho= st_dev *dev) > =20 > for (idx =3D 0; idx < dev->nvqs; ++idx) { > struct vhost_virtqueue *vq =3D &dev->vqs[idx]; > + unsigned num =3D virtio_queue_get_num(dev->vdev, idx); > struct vhost_vring_addr addr =3D { > .index =3D idx, > }; > @@ -1044,6 +1078,12 @@ static int vhost_sw_live_migration_start(struct vh= ost_dev *dev) > r =3D dev->vhost_ops->vhost_set_vring_addr(dev, &addr); > assert(r =3D=3D 0); > =20 > + r =3D vhost_backend_update_device_iotlb(dev, addr.used_user_addr, > + addr.used_user_addr, > + sizeof(vring_used_elem_t) = * num, > + IOMMU_RW); I don't remember seeing iotlb setup for the rest of the vring or guest memory. Maybe this should go into a single patch so it's easy to review the iova space layout. --YnIutncTLXsDZs5t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl/PPkEACgkQnKSrs4Gr c8jbGwf+OqBpKYq3vRs1xwb03191eAU1RZXGSRe283/ocJlVX8EMuoRMZPbbEXgt +OqCILt/QQuvQloLfm23ggS9XXUgKfQSPG16bFM0RE6j5lDUqDWESbduxFWxWl5k YAZhTPElTlaGeJbRpW4Ls2bqKSIkd77wtZu+AdPGGfr6IiZxE2rC3Rut3qhzl6A4 C2dhtR3TPweeG5bL8ls6tv3t9+J0n4tap8b93aX920+9ksgj1uYEZNjRk6jEWiMG 2vy5eEgE/SJcaNSFafSgYQGGscP3nAHCcwgkUs7MjiGyVXiMNi0xDGunPdQ1R/f/ /Sto7Mj12OlDF0kbMRUuNi5FfF3wOA== =vcmP -----END PGP SIGNATURE----- --YnIutncTLXsDZs5t-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E56DDC4361B for ; Tue, 8 Dec 2020 08:50:53 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43F7B23A79 for ; Tue, 8 Dec 2020 08:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43F7B23A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C63C586644; Tue, 8 Dec 2020 08:50:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EJuX0ElSHalD; Tue, 8 Dec 2020 08:50:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6BE82864B5; Tue, 8 Dec 2020 08:50:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 58EC0C0893; Tue, 8 Dec 2020 08:50:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id BAD5CC013B for ; Tue, 8 Dec 2020 08:50:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B524C8720A for ; Tue, 8 Dec 2020 08:50:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QNpSOnbljMLT for ; Tue, 8 Dec 2020 08:50:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id 2DDF2871AF for ; Tue, 8 Dec 2020 08:50:13 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id jx16so23476594ejb.10 for ; Tue, 08 Dec 2020 00:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=FZ0lHPANfEWsj+/iVtzHykLTQO6ijRLMLun67MC83GxuH1p2GZvrYjVFI3LNftNYmi /WF/Ppj7Wq5wn6x5qlhZ7poOpmvIzR9WmdgY8pxNF30wGY0Co7IAbS2881d+bH0E6Byn bpioRfSGZZ4HMfmUGGDYIBx8I9lWUbAfa90kVnGyoX+TsCLBzuOSbLyiDTiWf1LMert8 UgTYEKxN95dU+dYig9SnYr/1zjEk7X1WFDFui6Zn9YsLNmnCV9FZ9w0tvEVe2ihnVf8w L9O0G22F2V+wSKewS6KowfEZDIuF/m1OLAcCf+VIX9oZBeQmp9GyjwPdaUayPjCGVMO+ P38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TZXwYDaCWS7e1DN18P4hTw8qRki8SYJYAh/bIEvt7VA=; b=P3TVnQIIlvXzANOqWd+QuvIMvjQDxzqrjBNPUTyJOP7s3UxUTTvTIOpWBfQvXCUuuq hgy9MUDAcLMZN/Ug/lBCm4qIpUmN6cfHCLcm8LTa4uAvdiha0ustSzaWsCIbmpl2J+IP udwuVSUJYOcmB0fFdgVEQiGiHvqGvh4L00P+GOw9VycuPqUKv7F36aYh1BEIIpe6K2Nh rNYomMYuTZNTfoO3fmoN+LmXhtdK7rC9OEK9JU2aLbbxhQP8p0qriEu3r4jtsnSaStQX d7gBCGZo5WabeC4jBaeaM1rXaZso0x8rs5vksxDKnzKtnT2i/WspbZg89YTIcgnbtrdt XlFA== X-Gm-Message-State: AOAM5317XPX0G/0H9grptibu3C1PzN8EfJt8+xOyUciVnyvpwvkNSPzc sAopnMuav9ammLoGJ/k6pws= X-Google-Smtp-Source: ABdhPJww+kwZb8018JvYoa53FIBJf92vPUO/fyV4DEOGl5s9UG9EkjlxM/dxQWfVsgIsKRCS5yIpUg== X-Received: by 2002:a17:906:3c11:: with SMTP id h17mr21899491ejg.20.1607417411619; Tue, 08 Dec 2020 00:50:11 -0800 (PST) Received: from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id d6sm14878522ejy.114.2020.12.08.00.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:50:10 -0800 (PST) Date: Tue, 8 Dec 2020 08:50:09 +0000 From: Stefan Hajnoczi To: Eugenio =?iso-8859-1?Q?P=E9rez?= Subject: Re: [RFC PATCH 20/27] vhost: Return used buffers Message-ID: <20201208085009.GV203660@stefanha-x1.localdomain> References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-21-eperezma@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201120185105.279030-21-eperezma@redhat.com> Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Daniel Daly , virtualization@lists.linux-foundation.org, Liran Alon , Eli Cohen , Nitin Shrivastav , Alex Barba , Christophe Fontaine , Lee Ballard , Lars Ganrot , Rob Miller , Howard Cai , Parav Pandit , vm , Salil Mehta , Stephen Finucane , Xiao W Wang , Sean Mooney , Stefan Hajnoczi , Jim Harford , Dmytro Kazantsev , Siwei Liu , Harpreet Singh Anand , Michael Lilja , Max Gurtovoy X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0583181825994252544==" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" --===============0583181825994252544== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t" Content-Disposition: inline --YnIutncTLXsDZs5t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 20, 2020 at 07:50:58PM +0100, Eugenio P=E9rez wrote: > @@ -1028,6 +1061,7 @@ static int vhost_sw_live_migration_start(struct vho= st_dev *dev) > =20 > for (idx =3D 0; idx < dev->nvqs; ++idx) { > struct vhost_virtqueue *vq =3D &dev->vqs[idx]; > + unsigned num =3D virtio_queue_get_num(dev->vdev, idx); > struct vhost_vring_addr addr =3D { > .index =3D idx, > }; > @@ -1044,6 +1078,12 @@ static int vhost_sw_live_migration_start(struct vh= ost_dev *dev) > r =3D dev->vhost_ops->vhost_set_vring_addr(dev, &addr); > assert(r =3D=3D 0); > =20 > + r =3D vhost_backend_update_device_iotlb(dev, addr.used_user_addr, > + addr.used_user_addr, > + sizeof(vring_used_elem_t) = * num, > + IOMMU_RW); I don't remember seeing iotlb setup for the rest of the vring or guest memory. Maybe this should go into a single patch so it's easy to review the iova space layout. --YnIutncTLXsDZs5t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl/PPkEACgkQnKSrs4Gr c8jbGwf+OqBpKYq3vRs1xwb03191eAU1RZXGSRe283/ocJlVX8EMuoRMZPbbEXgt +OqCILt/QQuvQloLfm23ggS9XXUgKfQSPG16bFM0RE6j5lDUqDWESbduxFWxWl5k YAZhTPElTlaGeJbRpW4Ls2bqKSIkd77wtZu+AdPGGfr6IiZxE2rC3Rut3qhzl6A4 C2dhtR3TPweeG5bL8ls6tv3t9+J0n4tap8b93aX920+9ksgj1uYEZNjRk6jEWiMG 2vy5eEgE/SJcaNSFafSgYQGGscP3nAHCcwgkUs7MjiGyVXiMNi0xDGunPdQ1R/f/ /Sto7Mj12OlDF0kbMRUuNi5FfF3wOA== =vcmP -----END PGP SIGNATURE----- --YnIutncTLXsDZs5t-- --===============0583181825994252544== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization --===============0583181825994252544==--